From: "Laszlo Ersek" <lersek@redhat.com>
To: Leif Lindholm <leif.lindholm@linaro.org>,
Liming Gao <liming.gao@intel.com>
Cc: devel@edk2.groups.io, Andrew Fish <afish@apple.com>,
Michael D Kinney <michael.d.kinney@intel.com>
Subject: Re: [Patch] Maintainers.txt: Remove Network maintainers for MdeModulePkg/Universal/Network
Date: Tue, 4 Jun 2019 18:55:46 +0200 [thread overview]
Message-ID: <8f05b731-113f-2952-26b1-16133d33e206@redhat.com> (raw)
In-Reply-To: <20190604143500.pd2ee3thcrhync2t@bivouac.eciton.net>
On 06/04/19 16:35, Leif Lindholm wrote:
> On Tue, Jun 04, 2019 at 10:10:59PM +0800, Liming Gao wrote:
>> MdeModulePkg/Universal/Network has been moved to NetworkPkg. So,
>> MdeModulePkg/Universal/Network can be removed in Maintainers.txt.
>>
>> Signed-off-by: Liming Gao <liming.gao@intel.com>
>> Cc: Andrew Fish <afish@apple.com>
>> Cc: Laszlo Ersek <lersek@redhat.com>
>> Cc: Leif Lindholm <leif.lindholm@linaro.org>
>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>> ---
>> Because MdeModulePkg/Universal/Network has been moved to NetworkPkg,
>> I suggest to fix Maintainers.txt for 201905 stable tag.
>
> I agree. Since
> 1) it is not a code fix
> and
> 2) it corrects the maintainership state at the time of the stable tag
>
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Thanks!
Laszlo
>> Maintainers.txt | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/Maintainers.txt b/Maintainers.txt
>> index 010ec31404..3bab8a2db4 100644
>> --- a/Maintainers.txt
>> +++ b/Maintainers.txt
>> @@ -161,8 +161,6 @@ MdeModulePkg
>> W: https://github.com/tianocore/tianocore.github.io/wiki/MdeModulePkg
>> M: Jian J Wang <jian.j.wang@intel.com>
>> M: Hao A Wu <hao.a.wu@intel.com>
>> -M: NetworkPkg maintainers
>> - (Universal/Network and related libraries, header files)
>> R: Ray Ni <ray.ni@intel.com>
>> (especially for Bus, Universal/Console, Universal/Disk,
>> Universal/BdsDxe and related libraries, header files)
>> --
>> 2.13.0.windows.1
>>
next prev parent reply other threads:[~2019-06-04 16:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 14:10 [Patch] Maintainers.txt: Remove Network maintainers for MdeModulePkg/Universal/Network Liming Gao
2019-06-04 14:35 ` Leif Lindholm
2019-06-04 16:55 ` Laszlo Ersek [this message]
2019-06-05 8:23 ` Liming Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f05b731-113f-2952-26b1-16133d33e206@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox