From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Tue, 04 Jun 2019 09:56:06 -0700 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5F9302F8BC7; Tue, 4 Jun 2019 16:55:50 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-251.ams2.redhat.com [10.36.117.251]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3055C60566; Tue, 4 Jun 2019 16:55:47 +0000 (UTC) Subject: Re: [Patch] Maintainers.txt: Remove Network maintainers for MdeModulePkg/Universal/Network To: Leif Lindholm , Liming Gao Cc: devel@edk2.groups.io, Andrew Fish , Michael D Kinney References: <20190604141059.21608-1-liming.gao@intel.com> <20190604143500.pd2ee3thcrhync2t@bivouac.eciton.net> From: "Laszlo Ersek" Message-ID: <8f05b731-113f-2952-26b1-16133d33e206@redhat.com> Date: Tue, 4 Jun 2019 18:55:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190604143500.pd2ee3thcrhync2t@bivouac.eciton.net> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 04 Jun 2019 16:55:55 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 06/04/19 16:35, Leif Lindholm wrote: > On Tue, Jun 04, 2019 at 10:10:59PM +0800, Liming Gao wrote: >> MdeModulePkg/Universal/Network has been moved to NetworkPkg. So, >> MdeModulePkg/Universal/Network can be removed in Maintainers.txt. >> >> Signed-off-by: Liming Gao >> Cc: Andrew Fish >> Cc: Laszlo Ersek >> Cc: Leif Lindholm >> Cc: Michael D Kinney >> --- >> Because MdeModulePkg/Universal/Network has been moved to NetworkPkg, >> I suggest to fix Maintainers.txt for 201905 stable tag. > > I agree. Since > 1) it is not a code fix > and > 2) it corrects the maintainership state at the time of the stable tag > > Reviewed-by: Leif Lindholm Reviewed-by: Laszlo Ersek Thanks! Laszlo >> Maintainers.txt | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/Maintainers.txt b/Maintainers.txt >> index 010ec31404..3bab8a2db4 100644 >> --- a/Maintainers.txt >> +++ b/Maintainers.txt >> @@ -161,8 +161,6 @@ MdeModulePkg >> W: https://github.com/tianocore/tianocore.github.io/wiki/MdeModulePkg >> M: Jian J Wang >> M: Hao A Wu >> -M: NetworkPkg maintainers >> - (Universal/Network and related libraries, header files) >> R: Ray Ni >> (especially for Bus, Universal/Console, Universal/Disk, >> Universal/BdsDxe and related libraries, header files) >> -- >> 2.13.0.windows.1 >>