Re: [Patch v3 03/22] requirements.txt: Add python pip requirements file

["Laszlo Ersek" <lersek@redhat.com>]

On 10/30/19 03:27, Leif Lindholm wrote:
> On Tue, Oct 29, 2019 at 12:54:58PM -0700, Michael D Kinney wrote:
>> From: Sean Brogan <sean.brogan@microsoft.com>
>>
>> https://bugzilla.tianocore.org/show_bug.cgi?id=2315
>>
>> Add pip requirements file that is used to install the
>> python pip modules build from the edk2-pytool-library and
>> edk2-pytool-extensions repositories.
>>
>> These python modules provide the extensions required to
>> perform EDK II Continuous Integration(CI) builds.
>>
>> Cc: Andrew Fish <afish@apple.com>
>> Cc: Laszlo Ersek <lersek@redhat.com>
>> Cc: Leif Lindholm <leif.lindholm@linaro.org>
>> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
>> ---
>>  requirements.txt | 2 ++
> 
> This ia an extremely generic name for a file with very specific
> content. Is this a magic name, or could we rename it (for example)
> pip-requirements.txt?

+1, I find the name of the file, especially with the file placed in the
project root dir, very confusing.

Thanks
Laszlo

> 
> /
>     Leif
> 
>>  1 file changed, 2 insertions(+)
>>  create mode 100644 requirements.txt
>>
>> diff --git a/requirements.txt b/requirements.txt
>> new file mode 100644
>> index 0000000000..d4610f81c5
>> --- /dev/null
>> +++ b/requirements.txt
>> @@ -0,0 +1,2 @@
>> +edk2-pytool-library==0.10.*
>> +edk2-pytool-extensions==0.12.*
>> -- 
>> 2.21.0.windows.1
>>