From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web10.3461.1572512379182059280 for ; Thu, 31 Oct 2019 01:59:39 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ixovH9qt; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1572512378; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rAhrvrnjMWPw4z7CjxPKggjnvdpVLfMY1kiNDBe9Lf0=; b=ixovH9qtLPOlcSnmKzW/HHuK45/dJuQw3Al4IbH2abSEPGk+6I1oAfINRqUHFtq/YKYl7k 5BAPSoYUi8Cp0mg//U9Cr7KLfMZBmYbuhM+1FHrI5nJ9PMJTvtmoE7TswsVoi44oAUEwht uiuCpWepX5f6NUZFqeG2DpEdR7jz1Qo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-361-ryi2swJ-OJC6LaWNNeEaHQ-1; Thu, 31 Oct 2019 04:59:36 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DB8AB81A334; Thu, 31 Oct 2019 08:59:35 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-6.ams2.redhat.com [10.36.117.6]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9F60967154; Thu, 31 Oct 2019 08:59:34 +0000 (UTC) Subject: Re: [Patch v3 03/22] requirements.txt: Add python pip requirements file To: Leif Lindholm , Michael D Kinney Cc: devel@edk2.groups.io, Sean Brogan , Andrew Fish References: <20191029195517.20028-1-michael.d.kinney@intel.com> <20191029195517.20028-4-michael.d.kinney@intel.com> <20191030022757.GS16820@bivouac.eciton.net> From: "Laszlo Ersek" Message-ID: <8f240794-d53f-c4f9-1460-fcafa1170633@redhat.com> Date: Thu, 31 Oct 2019 09:59:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20191030022757.GS16820@bivouac.eciton.net> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: ryi2swJ-OJC6LaWNNeEaHQ-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/30/19 03:27, Leif Lindholm wrote: > On Tue, Oct 29, 2019 at 12:54:58PM -0700, Michael D Kinney wrote: >> From: Sean Brogan >> >> https://bugzilla.tianocore.org/show_bug.cgi?id=3D2315 >> >> Add pip requirements file that is used to install the >> python pip modules build from the edk2-pytool-library and >> edk2-pytool-extensions repositories. >> >> These python modules provide the extensions required to >> perform EDK II Continuous Integration(CI) builds. >> >> Cc: Andrew Fish >> Cc: Laszlo Ersek >> Cc: Leif Lindholm >> Signed-off-by: Michael D Kinney >> --- >> requirements.txt | 2 ++ >=20 > This ia an extremely generic name for a file with very specific > content. Is this a magic name, or could we rename it (for example) > pip-requirements.txt? +1, I find the name of the file, especially with the file placed in the project root dir, very confusing. Thanks Laszlo >=20 > / > Leif >=20 >> 1 file changed, 2 insertions(+) >> create mode 100644 requirements.txt >> >> diff --git a/requirements.txt b/requirements.txt >> new file mode 100644 >> index 0000000000..d4610f81c5 >> --- /dev/null >> +++ b/requirements.txt >> @@ -0,0 +1,2 @@ >> +edk2-pytool-library=3D=3D0.10.* >> +edk2-pytool-extensions=3D=3D0.12.* >> --=20 >> 2.21.0.windows.1 >>