From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=192.55.52.151; helo=mga17.intel.com; envelope-from=ryszard.knop@linux.intel.com; receiver=edk2-devel@lists.01.org Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8E829211BD612 for ; Wed, 30 Jan 2019 07:26:49 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jan 2019 07:26:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,540,1539673200"; d="scan'208";a="316169201" Received: from linux.intel.com ([10.54.29.200]) by fmsmga005.fm.intel.com with ESMTP; 30 Jan 2019 07:26:48 -0800 Received: from torii (torii.igk.intel.com [10.102.24.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTPS id ED965580297; Wed, 30 Jan 2019 07:26:46 -0800 (PST) Message-ID: <8f2a52415a37264affc4f4adf0545e337778277f.camel@linux.intel.com> From: Ryszard Knop To: Ard Biesheuvel , edk2-devel@lists.01.org Cc: kamil.kacperski@intel.com, eric.jin@intel.com, pawel.orlowski@intel.com, michael.d.kinney@intel.com, harry.l.hsiung@intel.com Date: Wed, 30 Jan 2019 16:26:44 +0100 In-Reply-To: <20181106175833.26964-16-ard.biesheuvel@linaro.org> References: <20181106175833.26964-1-ard.biesheuvel@linaro.org> <20181106175833.26964-16-ard.biesheuvel@linaro.org> Organization: Intel Corporation User-Agent: Evolution 3.30.4 Mime-Version: 1.0 Subject: Re: [PATCH edk2-staging 15/19] IntelUndiPkg/GigUndiDxe: remove forward declaration of non-existent function X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:26:49 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Reviewed-by: Ryszard Knop On Tue, 2018-11-06 at 18:58 +0100, ard.biesheuvela wrote: > Remove the forward declaration of e1000_disable_ulp_lpt_lp (), which > is never defined anywhere in the code. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c > b/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c > index 7669630a5c03..e9fc5394ab28 100644 > --- a/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c > +++ b/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c > @@ -103,9 +103,6 @@ STATIC s32 e1000_reset_hw_ich8lan(struct > e1000_hw *hw); > STATIC s32 e1000_init_hw_ich8lan(struct e1000_hw *hw); > STATIC s32 e1000_setup_link_ich8lan(struct e1000_hw *hw); > STATIC s32 e1000_setup_copper_link_ich8lan(struct e1000_hw *hw); > -#if !defined(NO_ULP_IN_S5_SUPPORT) > -STATIC s32 e1000_disable_ulp_lpt_lp(struct e1000_hw *hw, bool > force); > -#endif /* !NO_ULP_IN_S5_SUPPORT && !ULP_IN_D0_SUPPORT */ > STATIC s32 e1000_setup_copper_link_pch_lpt(struct e1000_hw *hw); > STATIC s32 e1000_get_link_up_info_ich8lan(struct e1000_hw *hw, > u16 *speed, u16 *duplex);