From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 7868A7803E7 for ; Tue, 9 Jul 2024 14:44:50 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Uv6DSaMTxLx4aONrjn17dPlkReeMh9BgbOqwIfARko4=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1720536290; v=1; b=E1qCovU3z0fyImVnmbzjEU5M5wZVKus/p/62golaE/fOSmppmR8/gT4hxB9yDcCXj2Ngh6wT ExhFE7gj4tetukIQkoVRfOWuwlhEHDp1OV210YZ/tEiwqGy1jhBCvAJFJasXnX286Atfh0NRgSk wAReRRMHh4FtnuyW+g9qdSuLAyKyuPUCYzoSaiBrXN8knTqVi3zVzJQuJ023QZdtVA7+ZLNM2fC rCSTGH0lAKVgc82ROjx5TwW8HbcdQ+syiekSRkJ1P/fOxaLJFQ5zJsgv9C/aUv3Q+mAcM36DcC+ N3FRC7H98YCIrDztk84+MJoDVBM9X/SNv2I9z6ANdRV/A== X-Received: by 127.0.0.2 with SMTP id P0krYY7687511xoA02LDnPrx; Tue, 09 Jul 2024 07:44:48 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.14710.1720536288242060605 for ; Tue, 09 Jul 2024 07:44:48 -0700 X-Received: from [10.6.0.181] (unknown [20.39.63.13]) by linux.microsoft.com (Postfix) with ESMTPSA id 7EC4420B7165; Tue, 9 Jul 2024 07:44:47 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 7EC4420B7165 Message-ID: <8f418b6d-c3d3-49b9-ab90-3e1acb0b880a@linux.microsoft.com> Date: Tue, 9 Jul 2024 10:44:46 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] github impact:breaking-change To: Leif Lindholm , "devel@edk2.groups.io" Cc: "discuss@edk2.groups.io" , "Kinney, Michael D" References: <4f3b1520-065f-4f43-9950-162cbdc0266a@quicinc.com> From: "Michael Kubacki" In-Reply-To: <4f3b1520-065f-4f43-9950-162cbdc0266a@quicinc.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 09 Jul 2024 07:44:48 -0700 Resent-From: mikuback@linux.microsoft.com Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: zJ3n7zqgdMTFVBvdADV9QcMtx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=E1qCovU3; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Leif, Thanks for raising this. The label was intended to be set from the PR=20 template which has an explanation: https://github.com/tianocore/edk2/blob/master/.github/pull_request_template= .md If the breaking change box is checked, it will be added automatically. I added a description in GitHub for the label as well: https://github.com/tianocore/edk2/labels Thanks, Michael On 7/8/2024 7:00 AM, Leif Lindholm wrote: > Hi, >=20 > I'm seeing something in several PRs in flight (and merged) that have=20 > "impact:breaking-change" set, where the purpose of the PR is to fix said= =20 > breakage, not introduce API compatibilities. >=20 > Am I correct in my understanding that this is not the intended use, and= =20 > if so how do we address the misconception? > Can we start by adding a description for the label? It currently has none= . >=20 > Mu uses "Requires integration attention", which matches my=20 > understanding, but feels a bit abstract. How about > "This change breaks existing APIs" > or > "This change may require corresponding updates to code in other=20 > repositories"? >=20 > / > =C2=A0=C2=A0=C2=A0 Leif -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119849): https://edk2.groups.io/g/devel/message/119849 Mute This Topic: https://groups.io/mt/107100295/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-