public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Evan Lloyd <Evan.Lloyd@arm.com>,
	"edk2-devel (edk2-devel@lists.01.org)" <edk2-devel@ml01.01.org>
Cc: Leif Lindholm <leif.lindholm@linaro.org>,
	"liming.gao@intel.com" <liming.gao@intel.com>
Subject: Re: File mode problem on Github edk2-BaseTools-win32
Date: Fri, 11 Nov 2016 12:24:17 +0100	[thread overview]
Message-ID: <8f47b193-8855-8a0c-5e97-9eb9373d6d66@redhat.com> (raw)
In-Reply-To: <AM5PR0801MB17623DC1E7BAC5FE521B72E58BBB0@AM5PR0801MB1762.eurprd08.prod.outlook.com>

On 11/11/16 12:05, Evan Lloyd wrote:
> There is a minor, but annoying, problem with file modes on the Github edk2-BaseTools-win32 repository.
> Git maintains a limited internal record of the Unix style file modes.
> edk2-BaseTools-win32 currently causes Git to set the file's modes to 660.
> So, after a checkout or pull of master, the builds fail because the files do not have Windows' "Read & Execute" permission.
> This is simple to fix, but one has to remember (or, ofttimes, get reminded) to do it every time there is an update.
> 
> Liming,
> Because this is purely a permission problem in the Git repository, and .exe files are not amenable to patching,

They are -- I think if you change the file mode bits, git will see that, and will create a patch that has no content hunks, just the file mode changes.

For example, in the BaseTools/Conf/ directory, we happen have two template files that have gratuitous execute permissions. If I remove those permissions, "git diff" shows

> diff --git a/BaseTools/Conf/build_rule.template b/BaseTools/Conf/build_rule.template
> old mode 100755
> new mode 100644
> diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template
> old mode 100755
> new mode 100644

The same should be possible on Windows too. (You just need the inverse operation right now, chmod +x.)

(The above patch is one I could submit genuinely, but I'm too lazy. :))

> I have raised a pull request on  https://github.com/tianocore/edk2-BaseTools-win32/pulls
> This is only a minor thing, but I would deem it a great favour were you to accept the pull request.
> It has me tearing my hair out, and I have little enough to begin with.  :-{

It is fine to send pull requests, but:
- they should be mailed to the list (not opened on github),
- the patches have to be reviewed first, anyway.

(Speaking about the edk2 repo at least -- I realize this is a different repo.)

Thanks
Laszlo


  reply	other threads:[~2016-11-11 11:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-11 11:05 File mode problem on Github edk2-BaseTools-win32 Evan Lloyd
2016-11-11 11:24 ` Laszlo Ersek [this message]
2016-11-11 13:12   ` Evan Lloyd
2016-11-11 13:57     ` Gao, Liming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8f47b193-8855-8a0c-5e97-9eb9373d6d66@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox