Re: File mode problem on Github edk2-BaseTools-win32

[Laszlo Ersek <lersek@redhat.com>]

On 11/11/16 12:05, Evan Lloyd wrote:
> There is a minor, but annoying, problem with file modes on the Github edk2-BaseTools-win32 repository.
> Git maintains a limited internal record of the Unix style file modes.
> edk2-BaseTools-win32 currently causes Git to set the file's modes to 660.
> So, after a checkout or pull of master, the builds fail because the files do not have Windows' "Read & Execute" permission.
> This is simple to fix, but one has to remember (or, ofttimes, get reminded) to do it every time there is an update.
> 
> Liming,
> Because this is purely a permission problem in the Git repository, and .exe files are not amenable to patching,

They are -- I think if you change the file mode bits, git will see that, and will create a patch that has no content hunks, just the file mode changes.

For example, in the BaseTools/Conf/ directory, we happen have two template files that have gratuitous execute permissions. If I remove those permissions, "git diff" shows

> diff --git a/BaseTools/Conf/build_rule.template b/BaseTools/Conf/build_rule.template
> old mode 100755
> new mode 100644
> diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template
> old mode 100755
> new mode 100644

The same should be possible on Windows too. (You just need the inverse operation right now, chmod +x.)

(The above patch is one I could submit genuinely, but I'm too lazy. :))

> I have raised a pull request on  https://github.com/tianocore/edk2-BaseTools-win32/pulls
> This is only a minor thing, but I would deem it a great favour were you to accept the pull request.
> It has me tearing my hair out, and I have little enough to begin with.  :-{

It is fine to send pull requests, but:
- they should be mailed to the list (not opened on github),
- the patches have to be reviewed first, anyway.

(Speaking about the edk2 repo at least -- I realize this is a different repo.)

Thanks
Laszlo