Re: [platforms PATCH 1/2] Marvell/Drivers: MvFvbDxe: Adjust to new dependencies

[Laszlo Ersek <lersek@redhat.com>]

On 04/17/18 07:15, Marcin Wojtas wrote:
> 2018-04-16 21:41 GMT+02:00 Laszlo Ersek <lersek@redhat.com>:

>> There's also a bit of whitespace mangling here that's not compatible
>> with either multiline function call style that we like in edk2, but
>> perhaps edk2-platforms treats that more laxly.
>>
> 
> We had some discussions last year - I followed the coding standards:
> 
> Function (
>   Argument1,
>   Argument2,
>   Argument3
>   );

Right, this is option #1.

> But was requested to place Argument1 to the function line and the last
> bracket to Argument3 line:
> 
> Function (Argument1,
>   Argument2,
>   Argument3);

In this case I prefer compressing the arguments as much as possible, for
example

  Status = ProtocolInstance->LongMemberFunctionName (Argument1,
                               Argument2, Argument3, Argument4,
                               Argument5, Argument6);

So either break the first argument and the closing paren as well to new
lines, or else keep all arguments compressed -- break them to new lines
only when the max line width dictates so.

No need to resubmit the patch because of this, I just wanted to clarify
my remark.

Thanks
Laszlo