From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id ACD3C22590E25 for ; Tue, 17 Apr 2018 00:20:54 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E9B9D40711B2; Tue, 17 Apr 2018 07:20:52 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-161.rdu2.redhat.com [10.10.120.161]) by smtp.corp.redhat.com (Postfix) with ESMTP id 94EB77C3C; Tue, 17 Apr 2018 07:20:51 +0000 (UTC) To: Marcin Wojtas Cc: Ard Biesheuvel , Hua Jing , Grzegorz Jaszczyk , "edk2-devel@lists.01.org" , Leif Lindholm , Nadav Haklai , Neta Zur Hershkovits References: <1523855353-9262-1-git-send-email-mw@semihalf.com> <1523855353-9262-2-git-send-email-mw@semihalf.com> <487cbdc8-72f7-e990-f53b-354c88370ba8@redhat.com> From: Laszlo Ersek Message-ID: <8f48b191-a74a-d7c1-0103-c15a6505549a@redhat.com> Date: Tue, 17 Apr 2018 09:20:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Tue, 17 Apr 2018 07:20:52 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Tue, 17 Apr 2018 07:20:52 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [platforms PATCH 1/2] Marvell/Drivers: MvFvbDxe: Adjust to new dependencies X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Apr 2018 07:20:54 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 04/17/18 07:15, Marcin Wojtas wrote: > 2018-04-16 21:41 GMT+02:00 Laszlo Ersek : >> There's also a bit of whitespace mangling here that's not compatible >> with either multiline function call style that we like in edk2, but >> perhaps edk2-platforms treats that more laxly. >> > > We had some discussions last year - I followed the coding standards: > > Function ( > Argument1, > Argument2, > Argument3 > ); Right, this is option #1. > But was requested to place Argument1 to the function line and the last > bracket to Argument3 line: > > Function (Argument1, > Argument2, > Argument3); In this case I prefer compressing the arguments as much as possible, for example Status = ProtocolInstance->LongMemberFunctionName (Argument1, Argument2, Argument3, Argument4, Argument5, Argument6); So either break the first argument and the closing paren as well to new lines, or else keep all arguments compressed -- break them to new lines only when the max line width dictates so. No need to resubmit the patch because of this, I just wanted to clarify my remark. Thanks Laszlo