Re: [PATCH edk2/MdePkg v1] MdePkg ACPI: Add some macros for PPTT

["Huangming (Mark)" <huangming23@huawei.com>]

Any comments for this patch?

On 2018/2/2 11:30, Heyi Guo wrote:
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang <huangming23@huawei.com>
> Signed-off-by: Heyi Guo <heyi.guo@linaro.org>
> ---
>  MdePkg/Include/IndustryStandard/Acpi62.h | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/MdePkg/Include/IndustryStandard/Acpi62.h b/MdePkg/Include/IndustryStandard/Acpi62.h
> index 2904d34..30faba9 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi62.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi62.h
> @@ -2557,6 +2557,12 @@ typedef struct {
>  } EFI_ACPI_6_2_PPTT_STRUCTURE_HEADER;
>  
>  ///
> +/// Value for valid fields in PPTT struct
> +///
> +#define EFI_ACPI_6_2_PPTT_INVALID            0x0
> +#define EFI_ACPI_6_2_PPTT_VALID              0x1
> +
> +///
>  /// Processor hierarchy node structure flags
>  ///
>  typedef struct {
> @@ -2593,6 +2599,18 @@ typedef struct {
>  } EFI_ACPI_6_2_PPTT_STRUCTURE_CACHE_FLAGS;
>  
>  ///
> +/// For cache attributes
> +///
> +#define EFI_ACPI_6_2_CACHE_ATTRIBUTES_ALLOCATION_READ            0x0
> +#define EFI_ACPI_6_2_CACHE_ATTRIBUTES_ALLOCATION_WRITE           0x1
> +#define EFI_ACPI_6_2_CACHE_ATTRIBUTES_ALLOCATION_READ_WRITE      0x2
> +#define EFI_ACPI_6_2_CACHE_ATTRIBUTES_CACHE_TYPE_DATA            0x0
> +#define EFI_ACPI_6_2_CACHE_ATTRIBUTES_CACHE_TYPE_INSTRUCTION     0x1
> +#define EFI_ACPI_6_2_CACHE_ATTRIBUTES_CACHE_TYPE_UNIFIED         0x2
> +#define EFI_ACPI_6_2_CACHE_ATTRIBUTES_WRITE_POLICY_WRITE_BACK    0x0
> +#define EFI_ACPI_6_2_CACHE_ATTRIBUTES_WRITE_POLICY_WRITE_THROUGH 0x1
> +
> +///
>  /// Cache Type Structure cache attributes
>  ///
>  typedef struct {
> 

-- 
Best Regards,

Ming