From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: philmd@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Tue, 24 Sep 2019 08:38:33 -0700 Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id ECB0E81F31 for ; Tue, 24 Sep 2019 15:38:32 +0000 (UTC) Received: by mail-wr1-f70.google.com with SMTP id n6so736877wrm.20 for ; Tue, 24 Sep 2019 08:38:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=udcznGNFbAidHrTggXUHGsapOCBmz3dvdIrlY/lE+4U=; b=CAMRFlog4uMVHq5GBO/1BEgJMlDLv9eT425K5R4xSjMUEkKrtrPQvPgZB1pXx8sUsb 3+IsTxbVZVE/byQa+uqGEiVtESwOOI4rBqDtljniqSaqXqdg0Z2qynO2RNcjzswmiPI5 o1tFa/u3Iqrxd46/knICQgmK1K52Qk1QEb5Bu/ewIKeDCGWmhdH4t39U9NnQWUBVSH+V dbpR3Ov28r4GTUsBwG2DG+NVG6l7bh8+kt4btLL3lBT4c66N93cvL4mSfVIcRDJst69i 8Lc80nUKdrNt2R0nS9menA9CgBQ5I/3gQl3WlGrkmjgYCnEy9jBFairWsIGCCwSti0v4 OQrw== X-Gm-Message-State: APjAAAU8H9hI/e4eCUu1RLna6Q/rT9Q7blHAlQBaz2yb6qh//bliZmye qQ7muSBmQPxBIg5jju47ozjYy04iE99NUy6LbO5XVqSi6PLDTCrTHdSYFLJIdih7fLWHrTcBECM 6LyYzezODw2wXhQ== X-Received: by 2002:a5d:458c:: with SMTP id p12mr3104786wrq.356.1569339511711; Tue, 24 Sep 2019 08:38:31 -0700 (PDT) X-Google-Smtp-Source: APXvYqxdtUbpGz3zt0FKnuuAmriObHE+MeSQashg4+fD3kSWT23FnNw8tPavl6SGpyDfvqVboWQxWQ== X-Received: by 2002:a5d:458c:: with SMTP id p12mr3104759wrq.356.1569339511444; Tue, 24 Sep 2019 08:38:31 -0700 (PDT) Received: from [192.168.1.115] (240.red-88-21-68.staticip.rima-tde.net. [88.21.68.240]) by smtp.gmail.com with ESMTPSA id a13sm3812431wrf.73.2019.09.24.08.38.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Sep 2019 08:38:30 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH 17/35] MdePkg/DxeServicesLib: remove bogus cast To: devel@edk2.groups.io, lersek@redhat.com Cc: Liming Gao , Michael D Kinney References: <20190917194935.24322-1-lersek@redhat.com> <20190917194935.24322-18-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: <8f96cb3d-6071-ea3a-b9ed-d0e8b1ebc139@redhat.com> Date: Tue, 24 Sep 2019 17:38:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190917194935.24322-18-lersek@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 9/17/19 9:49 PM, Laszlo Ersek wrote: > The HandleProtocol() boot service takes an EFI_HANDLE, not an > (EFI_HANDLE*). Remove the bogus cast in the > InternalImageHandleToFvHandle() function. > > This is a semantic cleanup; there is no change in behavior. > > Cc: Liming Gao > Cc: Michael D Kinney > Signed-off-by: Laszlo Ersek > --- > > Notes: > lightly tested, most probably: it's practically impossible to build a > platform without consuming DxeServicesLib > > MdePkg/Library/DxeServicesLib/DxeServicesLib.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MdePkg/Library/DxeServicesLib/DxeServicesLib.c b/MdePkg/Library/DxeServicesLib/DxeServicesLib.c > index c416b2dd8c65..0735b2f80400 100644 > --- a/MdePkg/Library/DxeServicesLib/DxeServicesLib.c > +++ b/MdePkg/Library/DxeServicesLib/DxeServicesLib.c > @@ -49,7 +49,7 @@ InternalImageHandleToFvHandle ( > ASSERT (ImageHandle != NULL); > > Status = gBS->HandleProtocol ( > - (EFI_HANDLE *) ImageHandle, > + ImageHandle, > &gEfiLoadedImageProtocolGuid, > (VOID **) &LoadedImage > ); > Reviewed-by: Philippe Mathieu-Daude