public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Sami Mujawar" <sami.mujawar@arm.com>
To: mikuback@linux.microsoft.com, devel@edk2.groups.io
Cc: Ilias Apalodimas <ilias.apalodimas@linaro.org>, nd@arm.com
Subject: Re: [edk2-platforms][PATCH v1 10/10] PlatformStandaloneMmPkg: Add VariableFlashInfoLib
Date: Mon, 25 Apr 2022 17:06:12 +0100	[thread overview]
Message-ID: <8fa4f1bb-1ebe-d903-af4f-b9c5d476b5c4@arm.com> (raw)
In-Reply-To: <20220420204420.1132-11-mikuback@linux.microsoft.com>

Hi Michael,

Thank you for this patch.

These changes look good to me.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

On 20/04/2022 09:44 pm, mikuback@linux.microsoft.com wrote:
> From: Michael Kubacki <michael.kubacki@microsoft.com>
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
>
> Adds an instance for the library class VariableFlashInfoLib that
> was recently introduced in MdeModulePkg. This change is made to
> allow the new variable driver to build that has a dependency on
> this library class and does not require any further platform
> changes.
>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Ilias Apalodimas <ilias.apalodimas@linaro.org>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
>   Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc b/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc
> index 33364deb1ef0..653029c52fdb 100644
> --- a/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc
> +++ b/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc
> @@ -34,6 +34,7 @@ [LibraryClasses]
>     ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf
>     BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
>     SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf
> +  VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf
>     VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
>     BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
>     DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDebugPrintErrorLevelLib.inf

  reply	other threads:[~2022-04-25 16:06 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-20 20:44 [edk2-platforms][PATCH v1 00/10] Add variableFlashInfoLib Michael Kubacki
2022-04-20 20:44 ` [edk2-platforms][PATCH v1 01/10] OverdriveBoard: Add VariableFlashInfoLib Michael Kubacki
2022-04-20 20:44 ` [edk2-platforms][PATCH v1 02/10] BeagleBoardPkg: " Michael Kubacki
2022-04-20 20:44 ` [edk2-platforms][PATCH v1 03/10] MinPlatformPkg: " Michael Kubacki
2022-04-20 20:44 ` [edk2-platforms][PATCH v1 04/10] CelloBoard: " Michael Kubacki
2022-04-20 20:44 ` [edk2-platforms][PATCH v1 05/10] SbsaQemu: " Michael Kubacki
2022-04-20 20:44 ` [edk2-platforms][PATCH v1 06/10] RaspberryPi: " Michael Kubacki
2022-04-22 14:41   ` Jeremy Linton
2022-04-22 14:44     ` Michael Kubacki
2022-04-20 20:44 ` [edk2-platforms][PATCH v1 07/10] U5SeriesPkg: " Michael Kubacki
2022-04-21  2:03   ` [edk2-devel] " Abner Chang
2022-04-20 20:44 ` [edk2-platforms][PATCH v1 08/10] Socionext: " Michael Kubacki
2022-04-20 20:44 ` [edk2-platforms][PATCH v1 09/10] Softiron: " Michael Kubacki
2022-04-20 20:44 ` [edk2-platforms][PATCH v1 10/10] PlatformStandaloneMmPkg: " Michael Kubacki
2022-04-25 16:06   ` Sami Mujawar [this message]
2022-04-29 18:55     ` Ilias Apalodimas
2022-04-22 23:15 ` [edk2-devel] [edk2-platforms][PATCH v1 00/10] Add variableFlashInfoLib Michael D Kinney
2022-04-25 16:06 ` Sami Mujawar
2022-04-25 22:17   ` Michael Kubacki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8fa4f1bb-1ebe-d903-af4f-b9c5d476b5c4@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox