From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (EUR04-VI1-obe.outbound.protection.outlook.com [40.107.8.44]) by mx.groups.io with SMTP id smtpd.web10.31654.1650902784387746169 for ; Mon, 25 Apr 2022 09:06:24 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=Mx93EV5q; spf=pass (domain: arm.com, ip: 40.107.8.44, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s6xj1TOHKCMfjY6gloDzvXIMjnc2aGEFkMT565Dn/kw=; b=Mx93EV5qK/H1K/pobJB34CBRgsIDpCxnY1amskICTquHNibbSBRSE2FB+u7NKFbND4t2rDnXDM2vP2RTpShxdUWA64GjoLHucQuzo9WFuqPZzmLa5J8D2YAcg9h80iBZW6eDXMom5o4ayEo3pjdV9xWP2Eev1UWq20H+WLNZf9k= Received: from DB8PR09CA0004.eurprd09.prod.outlook.com (2603:10a6:10:a0::17) by AM7PR08MB5446.eurprd08.prod.outlook.com (2603:10a6:20b:107::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Mon, 25 Apr 2022 16:06:21 +0000 Received: from DB5EUR03FT033.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:a0:cafe::e5) by DB8PR09CA0004.outlook.office365.com (2603:10a6:10:a0::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13 via Frontend Transport; Mon, 25 Apr 2022 16:06:21 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT033.mail.protection.outlook.com (10.152.20.76) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14 via Frontend Transport; Mon, 25 Apr 2022 16:06:21 +0000 Received: ("Tessian outbound 2d401af10eb3:v118"); Mon, 25 Apr 2022 16:06:21 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: f3f9b0c31b02b68f X-CR-MTA-TID: 64aa7808 Received: from 339506825c86.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id ADAEB1E3-A560-4DCA-9DAB-F08256E62F94.1; Mon, 25 Apr 2022 16:06:14 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 339506825c86.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 25 Apr 2022 16:06:14 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SU4rujW4STe6SJwMlvKCqVjk3Zsp76GTpUM4Y1p3UT6ydIHHK/QIomIgQ4eYLbzd30rLfIyW5E8a3QxylJQZEVUsBqre4GZQF0RvldQdT6j5GcWEN7fIjEUbdMVeOejfOLiIUSVFZuHYrYhODnIt4QV/HbxAPhB+Fz6+Ec1TGjNV8szdapdrl9HLT93ki8paMeoEvJV6xLkwe6IQWmwn/gEWKWXsQRg2436LqQj/LDFPO7SPBg02ACCNrvYcsWhVafU/t4iS8v15ZiVjZsTqdXv+PiCYFiVV5FkkhbvV1+aEg8+UqsQU6CmC8JAmflfmMPZxTfvxV1h1kOI38PiY6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s6xj1TOHKCMfjY6gloDzvXIMjnc2aGEFkMT565Dn/kw=; b=dtp9Ag2QM5oC/rA0lfWpIo0wZkBRj+zG9RApKX7amGtYa4mm0j/DRs8v8Vn3s6geu86krBlu1RU3w51tCHugxerYKxC0Ig4LakZPP3FLfrOsjkA5Kk0qcG65S7UJDiuAkvt4O7t2v7NmzXmdUA0KC6mgYdciXoPhzFGGGDDWdjXwD+foRLUAPrunGYsKLr0Xf9dyi73jxBEGn9SOQObCmSjFtx/V7JEC52RkkZca0zuYMhEc0U8Rg1NFufJSG9b9gF/cM6PIiTAbQjJhAPx8dix3VhBfGCoy+OkTxx5iTfu6hiwgYEXgetCXuYjO7qQEqjmzbb1SX4K0wDBF+JdAbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s6xj1TOHKCMfjY6gloDzvXIMjnc2aGEFkMT565Dn/kw=; b=Mx93EV5qK/H1K/pobJB34CBRgsIDpCxnY1amskICTquHNibbSBRSE2FB+u7NKFbND4t2rDnXDM2vP2RTpShxdUWA64GjoLHucQuzo9WFuqPZzmLa5J8D2YAcg9h80iBZW6eDXMom5o4ayEo3pjdV9xWP2Eev1UWq20H+WLNZf9k= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AS8PR08MB6693.eurprd08.prod.outlook.com (2603:10a6:20b:39c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Mon, 25 Apr 2022 16:06:12 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::fd9a:40d3:976a:5a95]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::fd9a:40d3:976a:5a95%4]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022 16:06:12 +0000 Message-ID: <8fa4f1bb-1ebe-d903-af4f-b9c5d476b5c4@arm.com> Date: Mon, 25 Apr 2022 17:06:12 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [edk2-platforms][PATCH v1 10/10] PlatformStandaloneMmPkg: Add VariableFlashInfoLib To: mikuback@linux.microsoft.com, devel@edk2.groups.io Cc: Ilias Apalodimas , nd@arm.com References: <20220420204420.1132-1-mikuback@linux.microsoft.com> <20220420204420.1132-11-mikuback@linux.microsoft.com> From: "Sami Mujawar" In-Reply-To: <20220420204420.1132-11-mikuback@linux.microsoft.com> X-ClientProxiedBy: LO4P123CA0122.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:192::19) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: d98b0a21-e258-49a9-7938-08da26d589f8 X-MS-TrafficTypeDiagnostic: AS8PR08MB6693:EE_|DB5EUR03FT033:EE_|AM7PR08MB5446:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 6CyZQMgih0vvzF7ypX2bare+0x8Hrf235XS1g5WnKg9RKNfLwBVZg34KYD65aUuHWfMfsNZtzP2VeDUjWvJn93ETPSrvXiNMHFIcR9vty8gCsWVxSU4EtTdPGC+cMceqiKWiTK0euIS7M90wEuXVQpMNQUXZ7JJQ0RUeZUs1O4SgFQWnoGnuzFWo18E3Z8PWAq7PhnMrrxpKj7GtTYBiTaDzuw8ATZrHSte8iJlUpgagq+hPfnLSenvHTdFXzC1lZo+FyTTuAD0jl16Ru3kBsbXm0K+bJa2tgzHDr9nvdu4WDAha7thj4ONf8AA7/biD3S4UPTxE3ntIVgKhglhdyOSU3bfDDrQNCUK1DvD0daIiozuCkDoVvfTZ843lmU3m/FpfSUbb5v738DDXFRnhgtHLBtlIP6NKyTyQkgPc6Uacp5RWjCnaVxAHL7fvjP0z7J6lV57ivi+a0FBkW5DGwKreXftepYpD7Mlc9Rpt8Ama7RJV0tPWexqvjLqWr0qrXmGtr+ZjyTfy7zlY3tBswIXEeWLuiD1VEbtJyjPd1461TMpVPlJ+40ehSWa2FzxXdDXcavCiP8hJ/5pu1YMCM/SshazDa7kFVQuEVgYwtb8x01YLiyx+Dg72ZuBZnXczXROs3CYiD+qFh6zOheJXy13/94dT+2xXxLhEzat67S6J0GSxmzMKLGyt/blYg9GzRLbJ/pa7gJniqLCHz6t4i4Bk5S8QGFJVCStU9nbF5Kou4xNq+vgVWa7jr2xwv6HBhTW07Mj52MWhV4GCdk6/H8oOiBxfeaQnLkZP16R4+33nlHuyuTPdM17FD/dIt3Wy X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(6029001)(4636009)(366004)(6486002)(45080400002)(36756003)(5660300002)(316002)(53546011)(31686004)(6506007)(26005)(8676002)(2906002)(508600001)(6512007)(44832011)(2616005)(4326008)(66946007)(66556008)(66476007)(31696002)(86362001)(38100700002)(8936002)(83380400001)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6693 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: bd49951d-6583-4b46-da84-08da26d584c1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MNf9BAwrJzEEQwV/61FGZqIE9p5PUYFJzOYUVtbWZPNKUHIKOcMb0OiebrnVdwPmhKeRNB+IoyK0D9v1GFyDPyIWO7qdELReRDDaYkxGZ1xJpuWJmto7JZxn5V5txDhssUDuiM27KhrsW3/NWdRl8hcA5d5DyFdMb1vb2AlluQVN31AoJAlmVSZ0ZqV8voERM2uyg/tuuieeclkskTJ1GBM2rpmkFG7yRoj8tWeSeSUuRcSjcP0nZFTBZTZDYWgYPCBXIgOkSC59n8XjehT4a6l0FXnXQBlhOcDPjNIrLWU1QZQ7XdWrpAkfxT0NiiabAjOLfpxXroaoAOpwThqheO97PwlJ5rtaw/0luxHm3wBsGdIjK0D2/TRUQh1yWfgHvgZ3XdOcKATM3/+mlw1JdLfu4pDqU3OUUONgRUXu9/IYAO791Kb3nki7GfYwKKKTb3vIEE2DRFwtzpYlf8oRIe7rXJppTdknJXXml4yhWI0qVOK61kIZ0NOKkGGvqv2fzv5rtyAUf3hsUXffghtuwZC3kYL36uUKqRIE0XisxCgp8clBPv3divG87XHFykZCuJcPPC81C8CY4C7Z2jX2D9gwywYKVgkcUutrIXdfAHHMo0qqGeddk7ft0D1VzVPrZMlaFSs6PydIL5ixFs/Oup3qc0/5qM435FTPt5C6iDFMdcPOAVveWQKyz1x4PuzXphKPUxpIQjVdHxBho3sEgPf6BOEp9E1B7kpTsBZq8T48DFQSFNPDylS2qd7SsD+k3ylPc21hCKjM1U4nfdsQBYScJXc9sawj6aEk4E+v6IE= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(6029001)(4636009)(40470700004)(46966006)(36840700001)(2616005)(336012)(47076005)(508600001)(6506007)(6512007)(53546011)(45080400002)(86362001)(356005)(81166007)(186003)(31696002)(8936002)(44832011)(82310400005)(4326008)(8676002)(31686004)(36756003)(5660300002)(2906002)(70206006)(26005)(70586007)(316002)(36860700001)(83380400001)(40460700003)(6486002)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 16:06:21.0843 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d98b0a21-e258-49a9-7938-08da26d589f8 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5446 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Michael, Thank you for this patch. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 20/04/2022 09:44 pm, mikuback@linux.microsoft.com wrote: > From: Michael Kubacki > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479 > > Adds an instance for the library class VariableFlashInfoLib that > was recently introduced in MdeModulePkg. This change is made to > allow the new variable driver to build that has a dependency on > this library class and does not require any further platform > changes. > > Cc: Sami Mujawar > Cc: Ilias Apalodimas > Signed-off-by: Michael Kubacki > --- > Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc b/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc > index 33364deb1ef0..653029c52fdb 100644 > --- a/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc > +++ b/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc > @@ -34,6 +34,7 @@ [LibraryClasses] > ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf > BaseLib|MdePkg/Library/BaseLib/BaseLib.inf > SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf > + VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf > VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf > BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf > DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDebugPrintErrorLevelLib.inf