public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Rebecca Cran" <quic_rcran@quicinc.com>
To: <devel@edk2.groups.io>, <kraxel@redhat.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>,
	Julien Grall <julien@xen.org>,
	Oliver Steffen <osteffen@redhat.com>,
	Pawel Polawski <ppolawsk@redhat.com>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Anthony Perard <anthony.perard@citrix.com>,
	Jiewen Yao <jiewen.yao@intel.com>
Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/SmbiosPlatformDxe: use PcdFirmwareVersionString
Date: Mon, 10 Oct 2022 10:27:39 -0600	[thread overview]
Message-ID: <8fde917f-c932-0e0c-499f-bbe9daa95ac9@quicinc.com> (raw)
In-Reply-To: <20221010144213.1470478-1-kraxel@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 883 bytes --]

On 10/10/2022 8:42 AM, Gerd Hoffmann wrote:

> Instead of using hard-coded string "0.0.0" for BiosVersion (which is
> quite useless) read PcdFirmwareVersionString and append that to the
> type0 entry string table.
>
> Signed-off-by: Gerd Hoffmann<kraxel@redhat.com>
> ---
>
>   #define TYPE0_STRINGS \
>     "EFI Development Kit II / OVMF\0"     /* Vendor */ \
> -  "0.0.0\0"                             /* BiosVersion */ \
> -  "02/06/2015\0"                        /* BiosReleaseDate */
> +  "02/06/2015"                          /* BiosReleaseDate */

I know this is unrelated to this patch, but should we update the release date at some point?

> +    DEBUG ((DEBUG_INFO, "FirmwareVersionString: \"%s\" (%d chars)\n", Str16, Chars));
> +
> +    Type0 = AllocateZeroPool (sizeof (mOvmfDefaultType0) + Chars + 2);

Should we check for an allocation failure here?

-- 
Rebecca Cran

[-- Attachment #2: Type: text/html, Size: 1469 bytes --]

  reply	other threads:[~2022-10-10 16:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-10 14:42 [PATCH 1/1] OvmfPkg/SmbiosPlatformDxe: use PcdFirmwareVersionString Gerd Hoffmann
2022-10-10 16:27 ` Rebecca Cran [this message]
2022-10-11  7:59   ` [edk2-devel] " Gerd Hoffmann
2022-10-11 15:34     ` Rebecca Cran
2022-10-12  8:52       ` Gerd Hoffmann
2022-10-24 14:03         ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8fde917f-c932-0e0c-499f-bbe9daa95ac9@quicinc.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox