On 10/10/2022 8:42 AM, Gerd Hoffmann wrote:

Instead of using hard-coded string "0.0.0" for BiosVersion (which is
quite useless) read PcdFirmwareVersionString and append that to the
type0 entry string table.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---

 #define TYPE0_STRINGS \
   "EFI Development Kit II / OVMF\0"     /* Vendor */ \
-  "0.0.0\0"                             /* BiosVersion */ \
-  "02/06/2015\0"                        /* BiosReleaseDate */
+  "02/06/2015"                          /* BiosReleaseDate */

I know this is unrelated to this patch, but should we update the release date at some point?

+    DEBUG ((DEBUG_INFO, "FirmwareVersionString: \"%s\" (%d chars)\n", Str16, Chars));
+
+    Type0 = AllocateZeroPool (sizeof (mOvmfDefaultType0) + Chars + 2);

Should we check for an allocation failure here? 

-- 
Rebecca Cran