From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by mx.groups.io with SMTP id smtpd.web11.8161.1665419286119079236 for ; Mon, 10 Oct 2022 09:28:06 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=D4CMePUW; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: quicinc.com, ip: 205.220.168.131, mailfrom: quic_rcran@quicinc.com) Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29ADt26r026618; Mon, 10 Oct 2022 16:27:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=content-type : message-id : date : mime-version : subject : to : cc : references : from : in-reply-to; s=qcppdkim1; bh=zaCw1vxpNe0H/AVKUg0+MGGIPR8ZonDR5kcp1FMHmv0=; b=D4CMePUWvR0YCupfFNsuMG07r7J234E1OgStXMz7Ll5HeEYJC/WZbboz/ealL0qS3BPe av/x1+J0KhdBmkC7Myt8illGDjtpAto9yUxDW9De8ZDfdZ2ff5Wkm7yFnVuzDoyZfVGC 4Mz8hDxOKXqMAeEtiUqvBTESbCjiBTv0JB3bCu+HLDPbJmb7vDWCl3rzR/T3ImL2ovUP 4+QjCbPTITwLi1XtF0mo95+6JPgeTH7Kgvx5HKWBD5NBRYLrz6LzFZS2E0XVTYVneTb0 tXF9FhdigukmYod2cnzLcTJL/v3/GNH7plW72VzrPO1laquIDHCgW/7Xg2DEePGHBEhD yg== Received: from nalasppmta02.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3k31jdmvaa-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 10 Oct 2022 16:27:57 +0000 Received: from pps.filterd (NALASPPMTA02.qualcomm.com [127.0.0.1]) by NALASPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTP id 29AGRuW1030138; Mon, 10 Oct 2022 16:27:56 GMT Received: from pps.reinject (localhost [127.0.0.1]) by NALASPPMTA02.qualcomm.com (PPS) with ESMTPS id 3k3jny56mq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 10 Oct 2022 16:27:56 +0000 Received: from NALASPPMTA02.qualcomm.com (NALASPPMTA02.qualcomm.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 29AGRuPl030133; Mon, 10 Oct 2022 16:27:56 GMT Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA02.qualcomm.com (PPS) with ESMTPS id 29AGRuYt030132 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 10 Oct 2022 16:27:56 +0000 Received: from [10.110.48.59] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Mon, 10 Oct 2022 09:27:55 -0700 Message-ID: <8fde917f-c932-0e0c-499f-bbe9daa95ac9@quicinc.com> Date: Mon, 10 Oct 2022 10:27:39 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/SmbiosPlatformDxe: use PcdFirmwareVersionString To: , CC: Jordan Justen , Julien Grall , Oliver Steffen , Pawel Polawski , Ard Biesheuvel , Anthony Perard , Jiewen Yao References: <20221010144213.1470478-1-kraxel@redhat.com> From: "Rebecca Cran" In-Reply-To: <20221010144213.1470478-1-kraxel@redhat.com> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: 1c16nk-cJ7H_nemF__EB3Mez9ZiGnPNs X-Proofpoint-ORIG-GUID: 1c16nk-cJ7H_nemF__EB3Mez9ZiGnPNs X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-10-10_10,2022-10-10_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 adultscore=0 clxscore=1011 bulkscore=0 lowpriorityscore=0 malwarescore=0 mlxscore=0 spamscore=0 mlxlogscore=999 priorityscore=1501 suspectscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2210100097 Content-Type: multipart/alternative; boundary="------------h59M0LYSTYJdEeYUSq8HcyiZ" Content-Language: en-US --------------h59M0LYSTYJdEeYUSq8HcyiZ Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit On 10/10/2022 8:42 AM, Gerd Hoffmann wrote: > Instead of using hard-coded string "0.0.0" for BiosVersion (which is > quite useless) read PcdFirmwareVersionString and append that to the > type0 entry string table. > > Signed-off-by: Gerd Hoffmann > --- > > #define TYPE0_STRINGS \ > "EFI Development Kit II / OVMF\0" /* Vendor */ \ > - "0.0.0\0" /* BiosVersion */ \ > - "02/06/2015\0" /* BiosReleaseDate */ > + "02/06/2015" /* BiosReleaseDate */ I know this is unrelated to this patch, but should we update the release date at some point? > + DEBUG ((DEBUG_INFO, "FirmwareVersionString: \"%s\" (%d chars)\n", Str16, Chars)); > + > + Type0 = AllocateZeroPool (sizeof (mOvmfDefaultType0) + Chars + 2); Should we check for an allocation failure here? -- Rebecca Cran --------------h59M0LYSTYJdEeYUSq8HcyiZ Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: 7bit 
On 10/10/2022 8:42 AM, Gerd Hoffmann wrote:
Instead of using hard-coded string "0.0.0" for BiosVersion (which is
quite useless) read PcdFirmwareVersionString and append that to the
type0 entry string table.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---

 #define TYPE0_STRINGS \
   "EFI Development Kit II / OVMF\0"     /* Vendor */ \
-  "0.0.0\0"                             /* BiosVersion */ \
-  "02/06/2015\0"                        /* BiosReleaseDate */
+  "02/06/2015"                          /* BiosReleaseDate */
I know this is unrelated to this patch, but should we update the release date at some point?

+    DEBUG ((DEBUG_INFO, "FirmwareVersionString: \"%s\" (%d chars)\n", Str16, Chars));
+
+    Type0 = AllocateZeroPool (sizeof (mOvmfDefaultType0) + Chars + 2);
Should we check for an allocation failure here? 

-- 
Rebecca Cran
--------------h59M0LYSTYJdEeYUSq8HcyiZ--