From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id EDBE474004E for ; Mon, 5 Feb 2024 10:54:51 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=LgZbPIFO88AdsXzM+hkMS0gXNnvwmChwqhUHsWPzn64=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1707130490; v=1; b=XBrJZf5NcZARiWThU0RyXm/puNzKiicLL2BUsVf9XbxLLSSs3EzOyDMcOAqvTrWdVoG7bDmZ yGMA6XpEhyI1LQkXqX+5XukCVAAkpiIoc8hnzJ852NmX2MS0Keep9WIX5YYhPYmvJkWitoTp1hI j4wPu//ELGdqVw3CDBi1lJBE= X-Received: by 127.0.0.2 with SMTP id MzFXYY7687511xd3UTK7mGtG; Mon, 05 Feb 2024 02:54:50 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.59973.1707130489558264858 for ; Mon, 05 Feb 2024 02:54:50 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 960A91FB; Mon, 5 Feb 2024 02:55:31 -0800 (PST) X-Received: from [10.34.100.129] (e126645.nice.arm.com [10.34.100.129]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CA60C3F762; Mon, 5 Feb 2024 02:54:47 -0800 (PST) Message-ID: <8fe74a33-32bd-45b5-a031-2556e14e418e@arm.com> Date: Mon, 5 Feb 2024 11:54:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [edk2][PATCH V2 0/2] Update handling of interrupt node for SSDT Serial Port Fixup Library To: Himanshu Sharma , devel@edk2.groups.io Cc: Ard Biesheuvel , Leif Lindholm , Sami Mujawar References: <20240104080257.319631-1-Himanshu.Sharma@arm.com> From: "PierreGondois" In-Reply-To: <20240104080257.319631-1-Himanshu.Sharma@arm.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: nU0ApXowktHOxdbRxnv8siu2x7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=XBrJZf5N; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hello Himanshu, I don't have other comments than what Sami had: Reviewed-by: Pierre Gondois Regards, Pierre On 1/4/24 09:02, Himanshu Sharma wrote: > Currently in the Dynamic Tables Framework, the interrupt node for the > AML description of the serial-ports is populated using the template > and so is mandatorily added even if the serial-port is enumerated as > a DBG2 port in the platform's configuration manager where the > interrupt is not mandatory. The proposed implementation adds the > interrupt node only if the interrupt defined for the serial-port is a > valid SPI or a valid extended SPI. So, in case of DBG2 ports, the > platforms with interrupt defined as SPI (like Morello) can have the > interrupt node added to the description and the platforms where it is > not defined (like N1SDP) can ignore the addition of the interrupt node. >=20 > The changes include adding the SPI range macros in ArmGicArchLib > (ArmPkg) which can be used by the SSDTSerialPortFixupLib > (DynamicTablesPkg) to put a check for generating the interrupt node > using AML Codegen API. >=20 > Change log: >=20 > V2: > - Fix comments on V1 > - Add link to Arm GIC Specification. > - Fix uncrustify errors. > - Add a check more if the interrupt is 0, > to be used when an interrupt is not wired to the serial port. > - Update copyright year to 2024. > - Link to branch with the patches in this series > https://github.com/himsha01/edk2/tree/ssdt_serial_port_interrupt_v2 >=20 > V1: > - Link to branch with the patches in this series > https://github.com/himsha01/edk2/tree/ssdt_serial_port_interrupt >=20 > Himanshu Sharma (2): > ArmPkg/ArmGicArchLib: Add macros for SPI and extended SPI ranges > DynamicTablesPkg/SsdtSerialPortFixupLib: Add Interrupt node for SPIs o= nly >=20 > DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPortFi= xupLib.inf | 3 +- > ArmPkg/Include/Library/ArmGicArchLib.h = | 14 ++++++ > DynamicTablesPkg/Include/ArmNameSpaceObjects.h = | 6 ++- > DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPortFi= xupLib.c | 49 ++++++++++++++------ > DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPortTe= mplate.asl | 29 +++++++----- > 5 files changed, 72 insertions(+), 29 deletions(-) >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115113): https://edk2.groups.io/g/devel/message/115113 Mute This Topic: https://groups.io/mt/103518971/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-