Re: [edk2-devel] [PATCH v3 00/13] Add GHCBv2 macro and helpers

["Laszlo Ersek" <lersek@redhat.com>]

On 05/19/21 20:19, Brijesh Singh wrote:
> This series is taken from the SNP RFC. This series defines the GHCBv2
> macros and NAE events. Additionally, it also introduces a helper to
> clear the page encryption mask from the Mmio region.
> 
> The series is based on the commit:
>  15ee7b76891a CryptoPkg/BaseCryptLib: Fix possible uninitialized use
> 
> Cc: James Bottomley <jejb@linux.ibm.com>
> Cc: Min Xu <min.m.xu@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Erdem Aktas <erdemaktas@google.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> 
> Change since v2:
>  - fix commit message for typos and add R-b
> 
> Change since v1:
>  - address the review comments
>  - drop the Mmio specific changes from 'remove Flush .." patch
> 
> Brijesh Singh (11):
>   MdePkg/Register/Amd: expand the SEV MSR to include the SNP definition
>   MdePkg/Register/Amd: realign macros with more space for future
>     expansion
>   MdePkg/Register/Amd: define GHCB macros for hypervisor feature
>     detection
>   MdePkg/Register/Amd: define GHCB macro for Register GPA structure
>   MdePkg/Register/Amd: define GHCB macro for the Page State Change
>   MdePkg/BaseLib: add support for PVALIDATE instruction
>   OvmfPkg/BaseMemEncryptSevLib: introduce
>     MemEncryptSevClearMmioPageEncMask()
>   OvmfPkg/AmdSevDxe: use MemEncryptSevClearMmioPageEncMask() to clear
>     EncMask
>   OvmfPkg/QemuFlashFvbServicesRuntimeDxe: use Mmio helper to clear enc
>     mask
>   OvmfPkg/TpmMmioSevDecryptPei: use MemEncryptSevClearMmioPageEncMask()
>   OvmfPkg/BaseMemEncryptSevLib: remove Flush parameter
> 
> Tom Lendacky (2):
>   MdePkg/Register/Amd: define GHCB macros for SNP AP creation
>   MdePkg/BaseLib: add support for RMPADJUST instruction
> 
>  MdePkg/Library/BaseLib/BaseLib.inf            |   2 +
>  MdePkg/Include/Library/BaseLib.h              |  85 +++++++++++
>  MdePkg/Include/Register/Amd/Fam17Msr.h        |  46 +++++-
>  MdePkg/Include/Register/Amd/Ghcb.h            | 137 +++++++++++++++++-
>  OvmfPkg/Include/Library/MemEncryptSevLib.h    |  35 ++++-
>  .../BaseMemEncryptSevLib/X64/VirtualMemory.h  |  33 ++++-
>  OvmfPkg/AmdSevDxe/AmdSevDxe.c                 |  13 +-
>  OvmfPkg/IoMmuDxe/AmdSevIoMmu.c                |   6 +-
>  .../Ia32/MemEncryptSevLib.c                   |  41 +++++-
>  .../X64/MemEncryptSevLib.c                    |  49 +++++--
>  .../X64/PeiDxeVirtualMemory.c                 |  47 ++++--
>  .../X64/SecVirtualMemory.c                    |  38 ++++-
>  .../SmmCpuFeaturesLib/SmmCpuFeaturesLib.c     |   3 +-
>  OvmfPkg/PlatformPei/AmdSev.c                  |   3 +-
>  .../FwBlockServiceDxe.c                       |   5 +-
>  .../QemuFlashSmm.c                            |   5 +-
>  .../TpmMmioSevDecryptPeim.c                   |   5 +-
>  MdePkg/Include/X64/Nasm.inc                   |  16 ++
>  MdePkg/Library/BaseLib/X64/Pvalidate.nasm     |  42 ++++++
>  MdePkg/Library/BaseLib/X64/RmpAdjust.nasm     |  40 +++++
>  20 files changed, 562 insertions(+), 89 deletions(-)
>  create mode 100644 MdePkg/Library/BaseLib/X64/Pvalidate.nasm
>  create mode 100644 MdePkg/Library/BaseLib/X64/RmpAdjust.nasm
> 

Merged as commit range dbc22a178546..adfa3327d4fc, via
<https://github.com/tianocore/edk2/pull/1675>.

Thanks
Laszlo