From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61]) by mx.groups.io with SMTP id smtpd.web10.20449.1590695767324256925 for ; Thu, 28 May 2020 12:56:07 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Bt43X1d4; spf=pass (domain: redhat.com, ip: 205.139.110.61, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590695766; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ykWYY7ENoYhLCQ+eNGHKW+wAJddPF0HVqC4TsqyNJr0=; b=Bt43X1d4H7utU5iAOBPPzDOEwIt0TTNc0GgdOWP+3JxGdwalaLq1y4JWlZKTjvP0VgkbIe gEoVelzNaBKLAXo/fstm9dCI41qO6GAZUxcpW5lRRqSvMgj5BnuLI4EYVcp43g3+wqB/r4 ZNzq+9BnJTHbnEFS14F2NRbgRu1UPuk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-286-jd0nCypkPs6_IA5_kthyGA-1; Thu, 28 May 2020 15:56:04 -0400 X-MC-Unique: jd0nCypkPs6_IA5_kthyGA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7605E1005510; Thu, 28 May 2020 19:55:58 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-101.ams2.redhat.com [10.36.112.101]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2F12DA1031; Thu, 28 May 2020 19:55:56 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH 5/5] ShellPkg: add BootManager library to add UEFI Shell menu option To: Ard Biesheuvel , devel@edk2.groups.io Cc: jon@solid-run.com References: <20200526161359.4810-1-ard.biesheuvel@arm.com> <20200526161359.4810-6-ard.biesheuvel@arm.com> <9475af7a-f6f8-cbaf-5a31-fe2e42d3d522@arm.com> From: "Laszlo Ersek" Message-ID: <900104c2-a54d-df1c-b67f-5494ea6765fb@redhat.com> Date: Thu, 28 May 2020 21:55:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <9475af7a-f6f8-cbaf-5a31-fe2e42d3d522@arm.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit On 05/27/20 19:22, Ard Biesheuvel wrote: > On 5/27/20 5:57 PM, Laszlo Ersek wrote: >> On 05/26/20 18:13, Ard Biesheuvel wrote: >>> Add a plug-in library for UiApp that creates a 'UEFI Shell' menu >>> option at the root level which gives access to a form that allows >>> the UEFI Shell to be launched. >>> >>> This gives the PlatformBootManagerLib implementation of the platform >>> more flexibility in the way it handles boot options pointing to the >>> UEFI Shell, which will typically be invoked with only the boot path >>> connected on fast boots. >>> >>> This library may be incorporated to a platform build by adding a >>> NULL resolution to the section of the UiApp.inf >>> {} block in the platform .DSC >>> >>> Signed-off-by: Ard Biesheuvel >>> --- >>>   ShellPkg/Library/ShellBootManagerLib/ShellBootManagerLib.inf |  45 >>> ++++ >>>   ShellPkg/Library/ShellBootManagerLib/ShellBootManagerLib.h   |  44 >>> ++++ >>>   ShellPkg/Library/ShellBootManagerLib/ShellBootManagerLib.c   | 258 >>> ++++++++++++++++++++ >>>   ShellPkg/Library/ShellBootManagerLib/ShellBmStrings.uni      |  17 ++ >>>   ShellPkg/Library/ShellBootManagerLib/ShellBmVfr.Vfr          |  37 +++ >>>   5 files changed, 401 insertions(+) >> >> I've had to go back to the blurb and re-read this part, to understand >> the goal of this patch: >> >>> - finally, add a plugin library for UiApp to expose the UEFI Shell >>> via an >>>    ordinary main menu option (this works around the fact that patch >>> #3 will >>>    result in the UEFI Shell disappearing from the Boot Manager list). >>>    Entering the shell this way will resemble the old situation, given >>> that >>>    UiApp connects all devices and refreshes all boot options etc at >>> launch. >> >> If I understand correctly: >> >> - patch #3 does two things: it clears LOAD_OPTION_ACTIVE (preventing the >>    boot manager from auto-booting the shell), and sets LOAD_OPTION_HIDDEN >>    (hiding the boot option from UiApp), >> >> - patch #5 undoes LOAD_OPTION_HIDDEN, in effect -- it makes sure that we >>    still see the shell option "somewhere" in UiApp (not among the boot >>    options, but at the root level) >> >> Can we: >> >> - drop patch#5, and >> >> - pass zero (0) as "Attributes" to PlatformRegisterFvBootOption() in >>    patch#3, rather than LOAD_OPTION_HIDDEN? >> >> Because, per spec, Attributes=0 should prevent the auto-booting of the >> shell *without* hiding the shell boot option from the menu. >> > > I feel slightly silly having gone through all the trouble of writing > this patch. I tried playing with the ACTIVE and HIDDEN options, and > couldn't get this to work. If I understand these quotes correctly, this > is an error, and instead of working around this, we should apply the > following patch to correct it: > > --- a/MdeModulePkg/Library/BootManagerUiLib/BootManager.c > +++ b/MdeModulePkg/Library/BootManagerUiLib/BootManager.c > @@ -537,7 +537,7 @@ UpdateBootManager ( >      // >      // Don't display the hidden/inactive boot option >      // > -    if (((BootOption[Index].Attributes & LOAD_OPTION_HIDDEN) != 0) || > ((BootOption[Index].Attributes & LOAD_OPTION_ACTIVE) == 0)) { > +    if (((BootOption[Index].Attributes & LOAD_OPTION_HIDDEN) != 0)) { >        continue; >      } > > > With this change applied, adding the shell option without the 'active' > or 'hidden' flags works as expected: it appears in the boot manager > menu, but is not booted automatically. I enthusiastically agree that we should apply your above BootManagerUiLib patch. I don't see why (per spec) the UI should hide a boot option just because it is inactive. Thanks! Laszlo