Re: [PATCH 13/15] ArmVirtPkg: implement ArmVirtMemInfo PPI, PEIM and library

[Laszlo Ersek <lersek@redhat.com>]

On 11/21/17 21:32, Ard Biesheuvel wrote:
> On 21 November 2017 at 20:17, Laszlo Ersek <lersek@redhat.com>
> wrote:
>> On 11/21/17 18:57, Ard Biesheuvel wrote:

>>> So how do you propose i go about creating two versions of
>>> QemuVirtMemInfoLib, only one of which has a constructor? Share
>>> the .c file between two infs in the same directory?
>> 
>> Hm, I think I missed the impact on ArmVirtQemuKernel. In the
>> current set, its DSC file is only modified in patch 12. (I missed
>> that too.) Are any changes necessary for ArmVirtQemuKernel that are
>> not contained in this set?
>> 
>> Either way, what you propose above seems to be the standard
>> approach to me: use two INF files, keep the bulk of the code in one
>> (shared) C file, and add the constructor to another (non-shared) C
>> file (i.e., referenced by only one of the INF files). Should the
>> constructor need shared utility functions from the shared C file,
>> add an internal header for those.
>> 
> 
> Would you object to having a single .c file, but only declare the 
> constructor in one of the two .INFs? The code will be pruned anyway, 
> due to our use of -ffunction-sections
> 

I would frown, but not object. :)

Please add a comment above the constructor function about the non-shared
use.

Thanks,
Laszlo