=EF=BB=BFOn 27. Jan 2023, at 15:33, Pedro Falcato <pe= dro.falcato@gmail.com> wrote:

On Fri, Jan 27, 2023 at 9:29 A= M Savva Mitrofanov <savvamtr@gmail.com> wrote:

Ac= cessing array using index of uint64 type makes MSVC compiler to
include `= __allmul` function in NOOPT which is not referenced in IA32.
So we null-t= erminates string using ReadSize, which should be equal to
SymlinkSizeTmp a= fter correct reading. Also adds missing MultU64x32
in Ext4Read.

Cc= : Marvin H=C3=A4user <mhaeuser@posteo.de>
Cc: Pedro Falcato <ped= ro.falcato@gmail.com>
Cc: Vitaly Cheptsov <vit9696@protonmail.com&g= t;
Fixes: 7c46116b0e18 ("Ext4Pkg: Add ext2/3 support")
Fixes: e81432fb= acb7 ("Ext4Pkg: Add symbolic links support")
Signed-off-by: Savva Mitrofa= nov <savvamtr@gmail.com>
---
Features/Ext4Pkg/Ext4Dxe/Inode.c &n= bsp; | 4 ++--
Features/Ext4Pkg/Ext4Dxe/Symlink.c | 12 ++++++--= ----
2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a= /Features/Ext4Pkg/Ext4Dxe/Inode.c b/Features/Ext4Pkg/Ext4Dxe/Inode.c
inde= x 90e3eb88f523..8db051d3c444 100644
--- a/Features/Ext4Pkg/Ext4Dxe/Inode.= c
+++ b/Features/Ext4Pkg/Ext4Dxe/Inode.c
@@ -152,7 +152,7 @@ Ext4Read (=
      } else {
    =     // Uninitialized extents behave exactly the same as f= ile holes, except they have
       &nb= sp;// blocks already allocated to them.
-      &= nbsp; HoleLen =3D (Ext4GetExtentLength (&Extent) * Partition->Bl= ockSize) - HoleOff;
+        HoleLen =3D= MultU64x32 (Ext4GetExtentLength (&Extent), Partition->BlockSize) - H= oleOff;
      }

   &n= bsp;  WasRead =3D HoleLen > RemainingRead ? RemainingRead : (UI= NTN)HoleLen;
@@ -166,7 +166,7 @@ Ext4Read (
    &n= bsp;            =           Partition->Bl= ockSize
           = ;            &nb= sp;   );
      ExtentLengthB= ytes =3D Extent.ee_len * Partition->BlockSize;
-   &nb= sp;  ExtentLogicalBytes =3D (UINT64)Extent.ee_block * Partition-&g= t;BlockSize;
+      ExtentLogicalBytes =3D MultU= 64x32 ((UINT64)Extent.ee_block, Partition->BlockSize);
  &nb= sp;   ExtentOffset       =3D Cu= rrentSeek - ExtentLogicalBytes;
      Exten= tMayRead      =3D (UINTN)(ExtentLengthBytes - Exten= tOffset);

diff --git a/Features/Ext4Pkg/Ext4Dxe/Symlink.c b/Features/= Ext4Pkg/Ext4Dxe/Symlink.c
index 19b357ac6ba0..8b1511a38b55 100644
--- a= /Features/Ext4Pkg/Ext4Dxe/Symlink.c
+++ b/Features/Ext4Pkg/Ext4Dxe/Symlin= k.c
@@ -1,7 +1,7 @@
/** @file
  Symbolic links routines
- Copyright (c) 2022 Savva Mitrofanov All rights reserved.
+ &= nbsp;Copyright (c) 2022-2023 Savva Mitrofanov All rights reserved.
= SPDX-License-Identifier: BSD-2-Clause-Patent
**/

@@ -155,11 += 155,6 @@ Ext4ReadSlowSymlink (
    return Status;
=   }

- //
- // Add null-terminator
- = ;//
- SymlinkTmp[SymlinkSizeTmp] =3D '\0';
-
  if (= SymlinkSizeTmp !=3D ReadSize) {
    DEBUG ((
= ;     DEBUG_FS,
@@ -168,6 +163,11 @@ Ext4ReadSlo= wSymlink (
    return EFI_VOLUME_CORRUPTED;
= }

+ //
+ // Add null-terminator
+ //

in EDK2 and EDK2 platforms but Ext4Pkg just does:
// C= omment

Also, why are you bringing this n= ull-termination down here?