From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.45294.1622473435399910066 for ; Mon, 31 May 2021 08:03:55 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ezAfLifc; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622473434; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UOzzTD5onrLdB5yAc4ExJ76iaYbs+xCtQtqhjumm9UY=; b=ezAfLifccTqTW/EjOk7idA3/Hs0x8aSWDykmw08knZi9eMx9fsPz3wQEn1R/2B1AtDnLr5 iM2mCKSq/JKfGvLDS2ZZ47hXg2yj/HibT1lxMjOnys8gr1fY+ToJCDnL3sRaivaZkYw5+W sjVGCOFuPHkuF/EdJo/mLOceSDejkf8= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-334-p2xYRMO6MCi03SzIjZF3nA-1; Mon, 31 May 2021 11:03:52 -0400 X-MC-Unique: p2xYRMO6MCi03SzIjZF3nA-1 Received: by mail-wm1-f71.google.com with SMTP id v20-20020a05600c2154b029019a6368bfe4so58920wml.2 for ; Mon, 31 May 2021 08:03:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=UOzzTD5onrLdB5yAc4ExJ76iaYbs+xCtQtqhjumm9UY=; b=mE4v85sgQXauAeMvkvrTlKAm864zez8KPaXwOoni/MDRp17ERbdyFCL9uhOe8dLFwO FXt+nd02fcewXo1r4JXn4Ns5eq/KOK3F8zzqLV4e8uQDx+XwSVggjdoVeCfHf6HNW8at qf/6xV8YDQt1iZBgbSUDrnl5khBYVHmlD0t0ICsDECMYqEscAdDsnVJHIDUmaKyiZV+G ybBCqKwg3KzqtttZVVHzeEfc6p7yHLTCl4w7kVWl2uhbI+jIX2G8AXb1YYMJvSbEctrP hhZ5G4WiyGCHbvOD717RnTERi4+51biXa+dBRGsETF+OK3L9usVfpAWALeBCBhJ6nIsr Iarg== X-Gm-Message-State: AOAM533J1bGlMaGvM64GGjYK6wtkH7rWA52qBigtymGWEVHKFM77NCYu vySD7IULljj2Vu2oqG9Uht5Y69/K4c5Za+apBmRt52kdPV262qkH5lQ2p1zUYC8jhSr0QRFaf5c LuvtDWUhlYegbYA== X-Received: by 2002:adf:f80f:: with SMTP id s15mr22655763wrp.341.1622473431611; Mon, 31 May 2021 08:03:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxQ1z5hBayNM5JwtzhUlNyk9gQlZ2mR3oBo2gaojSNb2o/hieA/czinWvsylfVPfjkStdnPsw== X-Received: by 2002:adf:f80f:: with SMTP id s15mr22655698wrp.341.1622473431046; Mon, 31 May 2021 08:03:51 -0700 (PDT) Return-Path: Received: from [192.168.1.36] (235.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.235]) by smtp.gmail.com with ESMTPSA id t14sm21301626wmq.16.2021.05.31.08.03.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 May 2021 08:03:50 -0700 (PDT) Subject: Re: [PATCH 42/43] OvmfPkg/SmbiosPlatformDxe: split Xen entry point from QEMU entry point To: Laszlo Ersek , devel@edk2.groups.io Cc: Anthony Perard , Ard Biesheuvel , Jordan Justen , Julien Grall References: <20210526201446.12554-1-lersek@redhat.com> <20210526201446.12554-43-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <902b3b10-7abc-5cd6-335a-c07f6eb2dc07@redhat.com> Date: Mon, 31 May 2021 17:03:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210526201446.12554-43-lersek@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 5/26/21 10:14 PM, Laszlo Ersek wrote: > Remove the SmbiosTablePublishEntry() function from "SmbiosPlatformDxe.c". > "SmbiosPlatformDxe.c" becomes hypervisor-agnostic. > > Add SmbiosTablePublishEntry() back, simplified for QEMU, to the existent > file "Qemu.c". The GetQemuSmbiosTables() function no longer needs to be > declared in "SmbiosPlatformDxe.h"; "SmbiosPlatformDxe.h" becomes > hypervisor-agnostic. > > Add SmbiosTablePublishEntry() back, renamed and simplified for Xen, to the > new, arch-independent file "Xen.c". (The existent Xen-specific C files are > arch-dependent.) :) Reviewed-by: Philippe Mathieu-Daude > Update both INF files; remove the dependencies that are now superfluous in > each. > > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Julien Grall > Cc: Philippe Mathieu-Daudé > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 > Signed-off-by: Laszlo Ersek > --- > OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.inf | 14 ------ > OvmfPkg/SmbiosPlatformDxe/XenSmbiosPlatformDxe.inf | 12 ++--- > OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.h | 11 ----- > OvmfPkg/SmbiosPlatformDxe/Qemu.c | 33 +++++++++++++ > OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 49 -------------------- > OvmfPkg/SmbiosPlatformDxe/Xen.c | 49 ++++++++++++++++++++ > 6 files changed, 86 insertions(+), 82 deletions(-)