From: Marc Zyngier <marc.zyngier@arm.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: Leif Lindholm <leif.lindholm@linaro.org>, Alan Ott <alan@softiron.co.uk>
Subject: Re: [PATCH edk2-non-osi 2/2] Silicon/AMD/Styx: update ArmTrustedFirmware.bin
Date: Thu, 1 Feb 2018 16:53:47 +0000 [thread overview]
Message-ID: <9033881e-9469-581e-b391-93b7962fa5a0@arm.com> (raw)
In-Reply-To: <CAKv+Gu8LJs6ca6prpz3=iQ6bpRMK1eaoBw=m+7GT2EDhmjMO5A@mail.gmail.com>
On 01/02/18 16:42, Ard Biesheuvel wrote:
> On 1 February 2018 at 16:04, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
>> The ARM Trusted Firmware build we have been using up until now was built
>> with optimizations disabled (which means every variable manipulation
>> involves a load, the operation itself and a store), and runs with the
>> MMU disabled, making it needlessly slow.
>>
>> This appears to be due to the fact that
>> a) the page tables are not set up correctly, so not all memory can be
>> accessed from EL3
>> b) the handling of SMC service calls does not take into account that
>> these calls may be made with the MMU off (e.g., by UEFI PEI).
>>
>> These issues have been fixed in the source code, which should hopefully
>> remove any performance bottlenecks that may become more noticeable now
>> that we are going to call into the secure firmware more often to perform
>> Spectre variant 2 mitigations, which have been backported as well.
>>
>> So update the binary image to a RELEASE build that was created with
>> optimizations enabled, and has the above fixes incorporated.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> ---
>> Silicon/AMD/Styx/ArmTrustedFirmware.bin | Bin 75344 -> 34320 bytes
>> 1 file changed, 0 insertions(+), 0 deletions(-)
>>
>
> Note to Marc: this is the exact image I shared with you as
> bl31.bin-release earlier today, so if that works as expected, could
> you report back here please? Thanks.
Absolutely. I'll give it a shot at the weekend (or earlier if I can).
Thanks,
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2018-02-01 16:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-01 16:04 [PATCH edk2-non-osi 0/2] Platform/Cello, Overdrive: upgrade firmware for Spectre Ard Biesheuvel
2018-02-01 16:04 ` [PATCH edk2-non-osi 1/2] Platform/Cello, Overdrive: split SCP and secure AP firmware Ard Biesheuvel
2018-02-01 16:04 ` [PATCH edk2-non-osi 2/2] Silicon/AMD/Styx: update ArmTrustedFirmware.bin Ard Biesheuvel
2018-02-01 16:42 ` Ard Biesheuvel
2018-02-01 16:53 ` Marc Zyngier [this message]
2018-02-03 13:44 ` Marc Zyngier
2018-02-03 15:13 ` Ard Biesheuvel
2018-02-01 16:39 ` [PATCH edk2-non-osi 0/2] Platform/Cello, Overdrive: upgrade firmware for Spectre Leif Lindholm
2018-02-06 9:55 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9033881e-9469-581e-b391-93b7962fa5a0@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox