From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, michael.d.kinney@intel.com,
Rebecca Cran <rebecca@bsdio.com>,
"rfc@edk2.groups.io" <rfc@edk2.groups.io>
Subject: Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process
Date: Mon, 11 May 2020 22:05:09 +0200 [thread overview]
Message-ID: <905f40b4-bb38-d704-069f-990120ac6a0c@redhat.com> (raw)
In-Reply-To: <MN2PR11MB4461481112608EF0D7F4DDECD2A10@MN2PR11MB4461.namprd11.prod.outlook.com>
On 05/11/20 03:37, Michael D Kinney wrote:
> There was feedback from Laszlo related to rebase for
> pull requests using the current CI process.
To clarify, I don't think we should allow any github-side automatism to
auto-rebase pull requests. I think such rebases need to occur on
personal developer machines, under human oversight, and then resubmitted
(likely: force-pushed). My request is that the build costs (time,
energy) associated with such force-pushes be reduced somehow.
For example, on a local machine, the following sequence:
$ git checkout master
$ git pull
$ git rebase -i master my_topic_branch
$ build ...
would trigger an incremental build. *.c files not touched by either
operation would not have to be re-built (assuming their dependencies
didn't change either, such as lib class headers, protocol headers, ...)
Thanks,
Laszlo
next prev parent reply other threads:[~2020-05-11 20:05 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-09 2:59 [edk2-rfc] GitHub Pull Request based Code Review Process Michael D Kinney
2020-05-09 4:22 ` Ni, Ray
2020-05-11 17:30 ` Michael D Kinney
2020-05-11 19:47 ` [edk2-devel] " Laszlo Ersek
2020-05-09 18:24 ` Rebecca Cran
2020-05-10 21:29 ` Michael D Kinney
2020-05-10 21:43 ` Rebecca Cran
2020-05-11 1:37 ` Michael D Kinney
2020-05-11 20:05 ` Laszlo Ersek [this message]
2020-05-11 20:00 ` Laszlo Ersek
2020-05-11 19:50 ` Laszlo Ersek
2020-05-11 17:27 ` Michael D Kinney
2020-05-11 19:39 ` [edk2-devel] " Laszlo Ersek
2020-05-11 20:09 ` [EXTERNAL] " Bret Barkelew
2020-05-11 20:43 ` Michael D Kinney
2020-05-14 21:26 ` Bret Barkelew
2020-05-14 21:46 ` Rebecca Cran
2020-05-26 10:08 ` Tomas Pilar (tpilar)
2020-05-15 1:19 ` Michael D Kinney
2020-05-15 4:49 ` Bret Barkelew
2020-05-15 9:07 ` Laszlo Ersek
2020-05-15 15:43 ` Bret Barkelew
2020-05-18 11:48 ` Philippe Mathieu-Daudé
2020-05-15 7:34 ` [EXTERNAL] " Laszlo Ersek
2020-05-15 15:36 ` Bret Barkelew
2020-05-18 2:29 ` Rebecca Cran
2020-05-11 22:07 ` Laszlo Ersek
-- strict thread matches above, loose matches on Subject: below --
2020-05-19 7:21 Nate DeSimone
2020-05-19 8:39 ` Laszlo Ersek
2020-05-19 18:02 ` Nate DeSimone
2020-05-19 16:54 ` Sean
2020-05-19 18:02 ` Nate DeSimone
2020-05-19 19:34 ` Bret Barkelew
2020-05-19 19:59 ` Nate DeSimone
2020-05-19 20:10 ` Bret Barkelew
2020-05-19 21:02 ` Nate DeSimone
2020-05-19 21:07 ` Bret Barkelew
2020-05-20 17:05 ` Laszlo Ersek
2020-05-20 17:21 ` Sean
2020-05-22 1:56 ` Andrew Fish
2020-05-20 21:53 ` Laszlo Ersek
2020-05-19 21:22 ` Laszlo Ersek
2020-05-19 21:35 ` Nate DeSimone
2020-05-19 21:38 ` Bret Barkelew
2020-05-19 20:41 ` Laszlo Ersek
2020-05-19 22:25 ` Sean
2020-05-21 13:30 ` Laszlo Ersek
2020-05-21 17:53 ` Sean
2020-05-22 2:59 ` Andrew Fish
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=905f40b4-bb38-d704-069f-990120ac6a0c@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox