From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120])
 by mx.groups.io with SMTP id smtpd.web12.603.1589227515252479773
 for <devel@edk2.groups.io>;
 Mon, 11 May 2020 13:05:15 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Z8lAS9lG;
 spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1589227514;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=SIXx8gPZMNr9fJpb9fl9ulTyPsU8abKOHzXVnXbot6w=;
	b=Z8lAS9lGOfSRG6H6fsOnVI70zciK5paJu9Az5boHPxj49fbvw+VOF+uv5BjcXXv2+TYQVh
	YFDT5fpauo7aIKAQxB/dtuzN2zWKAaOhzEKzUaBCkn0nf3G0t6YKMgJGPYPu+lEW7lOk00
	TAU/ub9UiquWo1oROcZMJEwJbwXT29c=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-421-Y0Dxu3oFOFmvIWuKzZ7DqA-1; Mon, 11 May 2020 16:05:12 -0400
X-MC-Unique: Y0Dxu3oFOFmvIWuKzZ7DqA-1
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6FA08BFC0;
	Mon, 11 May 2020 20:05:11 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-11.ams2.redhat.com [10.36.113.11])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 605ED5C1D3;
	Mon, 11 May 2020 20:05:10 +0000 (UTC)
Subject: Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process
To: devel@edk2.groups.io, michael.d.kinney@intel.com,
 Rebecca Cran <rebecca@bsdio.com>, "rfc@edk2.groups.io" <rfc@edk2.groups.io>
References: <MN2PR11MB446135275482094CDD3BA273D2A30@MN2PR11MB4461.namprd11.prod.outlook.com>
 <8ff350e5-64ed-d338-af93-6d12f80004f5@bsdio.com>
 <MN2PR11MB446130217BADAAD1A4740426D2A00@MN2PR11MB4461.namprd11.prod.outlook.com>
 <e68c4f1c-5e21-87bd-e1af-35acbd75daee@bsdio.com>
 <MN2PR11MB4461481112608EF0D7F4DDECD2A10@MN2PR11MB4461.namprd11.prod.outlook.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <905f40b4-bb38-d704-069f-990120ac6a0c@redhat.com>
Date: Mon, 11 May 2020 22:05:09 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <MN2PR11MB4461481112608EF0D7F4DDECD2A10@MN2PR11MB4461.namprd11.prod.outlook.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

On 05/11/20 03:37, Michael D Kinney wrote:

> There was feedback from Laszlo related to rebase for
> pull requests using the current CI process.

To clarify, I don't think we should allow any github-side automatism to
auto-rebase pull requests. I think such rebases need to occur on
personal developer machines, under human oversight, and then resubmitted
(likely: force-pushed). My request is that the build costs (time,
energy) associated with such force-pushes be reduced somehow.

For example, on a local machine, the following sequence:

$ git checkout master
$ git pull
$ git rebase -i master my_topic_branch
$ build ...

would trigger an incremental build. *.c files not touched by either
operation would not have to be re-built (assuming their dependencies
didn't change either, such as lib class headers, protocol headers, ...)

Thanks,
Laszlo