From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.2256.1587718846108469745 for ; Fri, 24 Apr 2020 02:00:46 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E401A1FB; Fri, 24 Apr 2020 02:00:44 -0700 (PDT) Received: from [10.37.8.121] (unknown [10.37.8.121]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1173E3F73D; Fri, 24 Apr 2020 02:00:42 -0700 (PDT) Subject: Re: [PATCH 0/7] OvmfPkg, ArmVirtPkg: control PXE v4/v6 boot support from the QEMU cmdline To: Laszlo Ersek , edk2-devel-groups-io Cc: Jordan Justen , Leif Lindholm , Per Sundstrom , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= References: <20200424075353.8489-1-lersek@redhat.com> From: "Ard Biesheuvel" Message-ID: <9072e8cd-fbca-78f4-8f18-4eb85d58e658@arm.com> Date: Fri, 24 Apr 2020 11:00:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200424075353.8489-1-lersek@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 4/24/20 9:53 AM, Laszlo Ersek wrote: > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2681 > Repo: https://pagure.io/lersek/edk2.git > Branch: pxe_fw_cfg >=20 > With this series applied, the QEMU command line options listed below > control whether the guest firmware supports PXEv4 / PXEv6 boot. And > correspondingly, whether UefiBootManagerLib generates *new* PXEv4 / > PXEv6 boot options automatically. (Existent boot options are never > deleted in response to just the flags below.) >=20 > -fw_cfg name=3Dopt/org.tianocore/IPv4PXESupport,string=3D[yn] >=20 > -fw_cfg name=3Dopt/org.tianocore/IPv6PXESupport,string=3D[yn] >=20 > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Leif Lindholm > Cc: Per Sundstrom > Cc: Philippe Mathieu-Daud=C3=A9 >=20 > Thanks > Laszlo >=20 > Laszlo Ersek (7): > OvmfPkg: introduce QemuFwCfgSimpleParserLib > OvmfPkg/PlatformPei: parse "X-PciMmio64Mb" with > QemuFwCfgSimpleParserLib > OvmfPkg/PlatformPei: use QemuFwCfgParseBool in > UPDATE_BOOLEAN_PCD_FROM_... > OvmfPkg/QemuFwCfgDxeLib: allow UEFI_DRIVER modules > OvmfPkg: control PXEv4 / PXEv6 boot support from the QEMU command li= ne > ArmVirtPkg/QemuFwCfgLib: allow UEFI_DRIVER modules > ArmVirtPkg: control PXEv4 / PXEv6 boot support from the QEMU command > line >=20 Very useful,thanks! For the series, Reviewed-by: Ard Biesheuvel > ArmVirtPkg/ArmVirtQemu.dsc = | 13 + > ArmVirtPkg/ArmVirtQemuKernel.dsc = | 13 + > ArmVirtPkg/Library/QemuFwCfgLib/QemuFwCfgLib.inf = | 2 +- > OvmfPkg/Include/Library/QemuFwCfgSimpleParserLib.h = | 128 +++++++ > OvmfPkg/Library/PxeBcPcdProducerLib/PxeBcPcd.c = | 39 ++ > OvmfPkg/Library/PxeBcPcdProducerLib/PxeBcPcdProducerLib.inf = | 33 ++ > OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgDxeLib.inf = | 2 +- > OvmfPkg/Library/QemuFwCfgSimpleParserLib/QemuFwCfgSimpleParser.c = | 398 ++++++++++++++++++++ > OvmfPkg/Library/QemuFwCfgSimpleParserLib/QemuFwCfgSimpleParserLib.inf= | 27 ++ > OvmfPkg/OvmfPkg.dec = | 4 + > OvmfPkg/OvmfPkgIa32.dsc = | 10 + > OvmfPkg/OvmfPkgIa32X64.dsc = | 11 + > OvmfPkg/OvmfPkgX64.dsc = | 10 + > OvmfPkg/PlatformPei/MemDetect.c = | 36 +- > OvmfPkg/PlatformPei/Platform.c = | 47 +-- > OvmfPkg/PlatformPei/PlatformPei.inf = | 1 + > 16 files changed, 712 insertions(+), 62 deletions(-) > create mode 100644 OvmfPkg/Include/Library/QemuFwCfgSimpleParserLib.h > create mode 100644 OvmfPkg/Library/PxeBcPcdProducerLib/PxeBcPcd.c > create mode 100644 OvmfPkg/Library/PxeBcPcdProducerLib/PxeBcPcdProduc= erLib.inf > create mode 100644 OvmfPkg/Library/QemuFwCfgSimpleParserLib/QemuFwCfg= SimpleParser.c > create mode 100644 OvmfPkg/Library/QemuFwCfgSimpleParserLib/QemuFwCfg= SimpleParserLib.inf >=20