From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web08.4249.1622105025842497264 for ; Thu, 27 May 2021 01:43:46 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=aJ3L8+I6; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622105025; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jmpaIIEXW/Ej/MAbbwZIFvek3d93qv6/8Mzsd+93o6M=; b=aJ3L8+I6P2yGKUPWmGNL0otguqW1IKaK/ytDVWHGbxkweOdqRrwb7BlaF++gEP8ZSaDEOV tvHCeZKRhZn9yiErAN9XdwFWkre25kH0RU3N4sV2gkQuXr0Aodn/p1W3YgXZCHyBj9Njud YpHqF/8hZoPjUeBStZG/wdhMWNf30ck= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-316-8FhaiKs6OIih_UXs8oPj0Q-1; Thu, 27 May 2021 04:43:43 -0400 X-MC-Unique: 8FhaiKs6OIih_UXs8oPj0Q-1 Received: by mail-wm1-f69.google.com with SMTP id y65-20020a1ce1440000b0290195e7df1743so25183wmg.3 for ; Thu, 27 May 2021 01:43:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=jmpaIIEXW/Ej/MAbbwZIFvek3d93qv6/8Mzsd+93o6M=; b=cPyy38X9kj9kYgsbYAGA4K8jXIIdjO8M1Ul71ejc9ZVY9sYQvE2Rxk3htbn/1+AbOK 2N2ic2YiNWKWtZofCrBvzapxjpzRnJbJ3HF5T4mrJjowxg9qFbFr0vZSH/XHM+yvjoLl WcGl7FpVzp14rEEIbB2DYT97iE09TP9BrJ5HbSHDD+RDGl2NJ19Y2ZJBr77ai6C7sj1n AnUDoACv8SzsEf5eDTfCazCgZfUf33w4piMfVOCqfGtKVTA0Opeq3K9b1ls6KUjvK89j t4BcVK3fxhnnZOeI9dvyFk17JQ6UyO+ZtxtbduTIT+ek97ONc8J+FgagkQlWnei67Rn1 jnrA== X-Gm-Message-State: AOAM5319u7dRY3jP9BfeLnyLLbCz9KWXsSYbroe6xtY9dvGa1E6uW+PB lhYMepY4vdtSq0BTHxeuOh02fj+xCE21z+tzI5kXVechcqMgpbjWa5F73VpL+xErEnKDij/Uc8R UX9JeckTQ098n+w== X-Received: by 2002:a7b:cc94:: with SMTP id p20mr7299919wma.39.1622105022222; Thu, 27 May 2021 01:43:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxOOXeH2nMr7HKnCjOpdcfW7lJjWY76VcvCL5qXctcNJQgCBTSKiYeHcX/x7peCkugr0/HEwQ== X-Received: by 2002:a7b:cc94:: with SMTP id p20mr7299905wma.39.1622105022078; Thu, 27 May 2021 01:43:42 -0700 (PDT) Return-Path: Received: from [192.168.1.36] (235.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.235]) by smtp.gmail.com with ESMTPSA id b15sm2192035wru.64.2021.05.27.01.43.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 May 2021 01:43:41 -0700 (PDT) Subject: Re: [PATCH 24/43] OvmfPkg/Bhyve: make "PcdPciDisableBusEnumeration" Fixed-at-Build To: Laszlo Ersek , devel@edk2.groups.io Cc: Ard Biesheuvel , Jordan Justen , Peter Grehan , Rebecca Cran References: <20210526201446.12554-1-lersek@redhat.com> <20210526201446.12554-25-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <90c5bbe4-d04f-f4dd-575f-6a90f308ff9f@redhat.com> Date: Thu, 27 May 2021 10:43:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210526201446.12554-25-lersek@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 5/26/21 10:14 PM, Laszlo Ersek wrote: > The Bhyve platform specifies the dynamic access method for > "PcdPciDisableBusEnumeration" needlessly. > > After the DSC file sets the PCD to TRUE by default, the PCD is never > written again. In particular, the > "OvmfPkg/Bhyve/PlatformPei/PlatformPei.inf" file references the PCD > superfluously. > > Make the PCD Fixed-At-Build, and remove the PCD reference from the INF > file. > > (Note that further simplifications are possible in > "OvmfPkg/Bhyve/AcpiPlatformDxe", but those are out of scope for this patch > series.) > > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Peter Grehan > Cc: Philippe Mathieu-Daudé > Cc: Rebecca Cran > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 > Signed-off-by: Laszlo Ersek > --- > OvmfPkg/Bhyve/BhyveX64.dsc | 2 +- > OvmfPkg/Bhyve/PlatformPei/PlatformPei.inf | 1 - > 2 files changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Philippe Mathieu-Daude