From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) by mx.groups.io with SMTP id smtpd.web10.24164.1683739951652751511 for ; Wed, 10 May 2023 10:32:31 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@linaro.org header.s=google header.b=BtV57HfO; spf=pass (domain: linaro.org, ip: 209.85.218.43, mailfrom: marcin.juszkiewicz@linaro.org) Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-965c3f9af2aso1126021266b.0 for ; Wed, 10 May 2023 10:32:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683739950; x=1686331950; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=r2aTNBOPlXtOWTYiQqUvyT6eTYbkG0BhYGc9pdVE3LI=; b=BtV57HfOrod82ijU494cGxBojuf28Ky1Y5GI1EJKDcqfw1filogfBqTmm0N2b9G61W OZLYiM445oUl+etA0L8yJh6dCzskNQm6Abu4caB6/QnEIsDN1lIkYeKalNFbnqEzXUgw uNJZxw6dazvSsft5NIN+2ZAttkfBFOStY9XsOLpxs/K1SYkePk++P6GGJwi3HyVYdLqQ /B6eUj/xoAjvcHZxIrxWJyNBjfLzOPluqGb0R7+lFRPsgHuGU/G3A4RdRymh+XnW1WU1 qYI5nns5DV8K0TBx3rf6MqhhULbIAiHekVcthGAsCGP657wEgcc2ayBLm16aaBACspSb mEcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683739950; x=1686331950; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=r2aTNBOPlXtOWTYiQqUvyT6eTYbkG0BhYGc9pdVE3LI=; b=Fslby7NSzB4vJZmv+0c85leuy/Hte79ZWrlYd4uP3LuvpK/fPweY4x7NyMCo143fFV RYFFC0vY+Ia619Iqp+mwx3l0vv00c2du9q1kMlg8TnwLJOxA853eyYb1sQbnkcD6XZg7 +OWctKjq3i7Y9ehrvp0NEBmK+uaJLgwDhGf2AiDA0jeCLS36ug7OXkIdZGch1kAp3fZw 4Pqozue0wR9MuX6jwDjteToLmz7eXZJa6/E9kkMG9kciLcVFsJ6hyR6pMnyb0jQUY500 ywb4VP/4md9BP8YkUks6Bd87ZT4QDw+QCPV7RzKb9MfrAyDQD65xymntt6WvybH9LGan nAcg== X-Gm-Message-State: AC+VfDwLpBjQV99rKQuQEWDODPrhbYQ+/Djvdvma620DrHuKqKBv6gWq LhvTcTDRVVhznPOHpN7OmHGpyw== X-Google-Smtp-Source: ACHHUZ6wIUD4hsW6WjbywTGZdj7NrPX8Lna+Ez85s610aPLwpZ5tej7aZIQ3JvDeRKdnIIdp/K2IOA== X-Received: by 2002:a17:907:3181:b0:959:b745:d16f with SMTP id xe1-20020a170907318100b00959b745d16fmr15337739ejb.51.1683739950084; Wed, 10 May 2023 10:32:30 -0700 (PDT) Return-Path: Received: from [192.168.200.206] (83.11.34.59.ipv4.supernova.orange.pl. [83.11.34.59]) by smtp.gmail.com with ESMTPSA id h9-20020a170906584900b0094e597f0e4dsm2885544ejs.121.2023.05.10.10.32.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 May 2023 10:32:29 -0700 (PDT) Message-ID: <90d7e9ab-9396-3141-1ab9-06d5344ad385@linaro.org> Date: Wed, 10 May 2023 19:32:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v3 1/1] Platform/SbsaQemu: read platform version To: Rebecca Cran , devel@edk2.groups.io Cc: Ard Biesheuvel , Leif Lindholm , Sami Mujawar References: <40996fe8-7fc3-40cc-a106-a2e85e952703@bsdio.com> <20230510160611.202580-1-marcin.juszkiewicz@linaro.org> From: "Marcin Juszkiewicz" Organization: Linaro In-Reply-To: Content-Language: pl-PL, en-GB, en-HK Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit W dniu 10.05.2023 o 18:14, Rebecca Cran pisze: > Sorry, but there are new problems. No problem. Thanks for reviewing. > There should be a space before the parenthesis in the 'DEBUG' line. No problem. I hope that one day someone will run source formatter on whole edk2-platforms so it would be possible to autoformat changes before posting. > PcdGet32 doesn't return a RETURN_STATUS or EFI_STATUS, so > ASSERT_EFI_ERROR is incorrect. fixed