From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from alexa-out-sd-01.qualcomm.com (alexa-out-sd-01.qualcomm.com [199.106.114.38])
 by mx.groups.io with SMTP id smtpd.web10.2906.1649284446748536078
 for <devel@edk2.groups.io>;
 Wed, 06 Apr 2022 15:34:06 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=zlUpkDGD;
 spf=pass (domain: quicinc.com, ip: 199.106.114.38, mailfrom: quic_rcran@quicinc.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
  d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim;
  t=1649284446; x=1680820446;
  h=message-id:date:mime-version:subject:to:cc:references:
   from:in-reply-to:content-transfer-encoding;
  bh=STMb9unXDKafmDzvVWdNePfhIVnPoUf9CXJgn4bAOCI=;
  b=zlUpkDGDIkt5vx3dThWJSSy/nRcrn0UiiOMQSDOQ67D47Wrc0D74Q+Ma
   1CVFjsrcx+pYaU8PWNe26B7KT5jUi8jWYOgtgT65pO4qFFScrwbA7Ouhd
   PACNB5Rt8qRRJ3ZpAEL47pKbppNderHkIt1rixdu5Dk7nwtjrprSN9rzn
   E=;
Received: from unknown (HELO ironmsg04-sd.qualcomm.com) ([10.53.140.144])
  by alexa-out-sd-01.qualcomm.com with ESMTP; 06 Apr 2022 15:34:06 -0700
X-QCInternal: smtphost
Received: from nasanex01b.na.qualcomm.com ([10.46.141.250])
  by ironmsg04-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Apr 2022 15:34:06 -0700
Received: from [10.110.14.194] (10.80.80.8) by nasanex01b.na.qualcomm.com
 (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Wed, 6 Apr 2022
 15:34:05 -0700
Message-ID: <90db1689-9d3d-8eb3-1e1e-0dbe347530c3@quicinc.com>
Date: Wed, 6 Apr 2022 16:34:04 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v2 0/3] BaseTools: Add support for gdb and lldb
To: <devel@edk2.groups.io>, Leif Lindholm <quic_llindhol@quicinc.com>,
	"Michael D Kinney" <michael.d.kinney@intel.com>, Hao A Wu
	<hao.a.wu@intel.com>, "Bob Feng" <bob.c.feng@intel.com>, Liming Gao
	<gaoliming@byosoft.com.cn>, "Yuwei Chen" <yuwei.chen@intel.com>
CC: Andrew Fish <afish@apple.com>
References: <20220321202048.13567-1-quic_rcran@quicinc.com>
From: "Rebecca Cran" <quic_rcran@quicinc.com>
In-Reply-To: <20220321202048.13567-1-quic_rcran@quicinc.com>
Return-Path: quic_rcran@quicinc.com
X-Originating-IP: [10.80.80.8]
X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To
 nasanex01b.na.qualcomm.com (10.46.141.250)
Content-Language: en-US
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit

Could I have some more reviews on this please? I'd like to get this into 
the tree soon.

-- 
Rebecca Cran

On 3/21/22 14:20, Rebecca Cran wrote:
> This patch set adds debugging support for gdb and lldb.
> It also adds generic debugging classes that use a file like object to
> make it easy to import into any debugger that supports Python.
>
> Changes from v1 to v2:
> - Moved scripts from the root of the repo into BaseTools/Scripts.
> - Fixed typo of "RISCV" as "RISKV".
>
> Testing:
> - Tested gdb on Ubuntu and lldb on macOS for IA32 and X64.
> - Tested gdb on openSUSE for AARCH64.
>
> Rebecca Cran (3):
>    BaseTools: efi_debugging.py: Add debugger agnostic dbg Python Classes
>    BaseTools: Scripts/efi_gdb.py: Add gdb EFI commands and pretty Print
>    BaseTools: Scripts/efi_lldb.py: Add lldb EFI commands and pretty Print
>
>   BaseTools/Scripts/efi_debugging.py | 2185 ++++++++++++++++++++
>   BaseTools/Scripts/efi_gdb.py       |  918 ++++++++
>   BaseTools/Scripts/efi_lldb.py      | 1044 ++++++++++
>   3 files changed, 4147 insertions(+)
>   create mode 100755 BaseTools/Scripts/efi_debugging.py
>   create mode 100755 BaseTools/Scripts/efi_gdb.py
>   create mode 100755 BaseTools/Scripts/efi_lldb.py
>