From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.42]) by mx.groups.io with SMTP id smtpd.web12.11446.1620158135445717219 for ; Tue, 04 May 2021 12:55:35 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=Gco79tGm; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.220.42, mailfrom: brijesh.singh@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dI10nJzRYDpSZ9hChjKMuWlNiiG4/DZ3n2K5bvz46zK6cdGJA7N6s164eFKU9UJ+MwixwG3yYjpug/Ik4UKmnn6Mt8Arobq2oLKWjOfQvecm2x3LfAEkSU5b9n22m3FT8lE3p2X0J6i/WYgmbTVEtnrq39qwzYqOW0qfOJxwWX8esJAgeolL6UdqvzREhJvGH+cybU9Hyz/10eqiSllq3cRKEY/BFM1XOapKurXM2++kO7MLPgD+c+ItlLujKpFvU2jNBJtMlryYqBopBbYBGnkAy30PLhJM7s9YAEqMo4cSeF8dG3kVTZEywl5GdMkx0M3LXcDor/Z8wISIISg3bA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d6qew4Mh4khXMQ93hDbInrFkTTk3Ir4heEfKfVqf8q0=; b=KF9/noQ3gsQhqGnN+IMRJ/rIukBTuknh7VIpsNaJ3jrop10l84kWOcpABrVlMkWkOsZWI8oRUMVGAFYqrq2Ub0GBx0kMWFflaOXBr9ZXtGAQTUvv14t0ZopPNfjMekckp3Rkq1yDJWh6Y0pOjjPQpfXZc8zZDekRr1MptJsZVpKeWNDrk54Z3Fr37lo5dO4WOVWuzzbkRNyZmdka8UmjnyyhhiUM7H3omkiCdS0iavyane1kSCWMGJL5WGYQyEPySGQIB37wrqKg1FVp3FGlq7p+GhEk8pIr3HmqKkQnY/G5CmlN1V30l2UfhpQpViVvNJ8IL5dtSkKWbkhfqM7ClA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d6qew4Mh4khXMQ93hDbInrFkTTk3Ir4heEfKfVqf8q0=; b=Gco79tGm2WiZuapX+pIB+vfQwOo+Hl+8Cjisg7muiOgl+YJGRKTor7qIVr+tMNJ2BR3Qlss1MOWWq7T3Vg8KOUmO7k+/YL7ZicFpBJlu68mjUGTCbvG1Ot8fiTr6KpxMJaRcTvaBHqQhYc5Q/jH090592+UygcTMqXKUkHsUxc8= Authentication-Results: google.com; dkim=none (message not signed) header.d=none;google.com; dmarc=none action=none header.from=amd.com; Received: from SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) by SN1PR12MB2542.namprd12.prod.outlook.com (2603:10b6:802:26::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.24; Tue, 4 May 2021 19:55:33 +0000 Received: from SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::9898:5b48:a062:db94]) by SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::9898:5b48:a062:db94%6]) with mapi id 15.20.4108.025; Tue, 4 May 2021 19:55:33 +0000 Cc: brijesh.singh@amd.com, James Bottomley , Min Xu , Jiewen Yao , Tom Lendacky , Jordan Justen , Ard Biesheuvel , Erdem Aktas Subject: Re: [edk2-devel] [PATCH RFC v2 05/28] MdePkg: Add AsmPvalidate() support To: devel@edk2.groups.io, Laszlo Ersek References: <20210430115148.22267-1-brijesh.singh@amd.com> <20210430115148.22267-6-brijesh.singh@amd.com> <167BF2A01FA60569.6407@groups.io> From: "Brijesh Singh" Message-ID: <90dec0ee-0d4b-e72e-ce4d-b8b8e69f2b80@amd.com> Date: Tue, 4 May 2021 14:55:30 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 In-Reply-To: <167BF2A01FA60569.6407@groups.io> X-Originating-IP: [70.112.153.56] X-ClientProxiedBy: SN7PR04CA0013.namprd04.prod.outlook.com (2603:10b6:806:f2::18) To SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) Return-Path: brijesh.singh@amd.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from Brijeshs-MacBook-Pro.local (70.112.153.56) by SN7PR04CA0013.namprd04.prod.outlook.com (2603:10b6:806:f2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.27 via Frontend Transport; Tue, 4 May 2021 19:55:31 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5f57a15d-d95e-4ef1-b619-08d90f369337 X-MS-TrafficTypeDiagnostic: SN1PR12MB2542: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CCJPIU+fX7sf+9eFM0xnwNzSYnccFiZeQpZl6q+hzZpFeJR0thQ4RxRw+BQC+fp0EufnfJYRXfRskEa8aj/t31PikBQrxpxrzGt8+jknVC+D8aPecMvrRU9gxhmtLNXSUbzTINCp+uOsFwxuMTGav3VtAqQ45hqvlG5MFE64CHjMA8SVzM1u7tT4kN4uctl37mEKZicZTlgg5xilnNTSmJPbK7nR0s++64IOUlGhbvt/howPosVD4NnzA11VSiUGeI8SQSxzvgKSIzeLpnFsX/jlABiIcCK58/fyu+/gexkL3T5a1sAOayFVYi+QCfUOpfzsXmtWqIEtMcQJT57YhnfdVmzK59Q5/cp5IzSCGadrU8wmXcRqeExcMAVbPzEmR3RZ23bfRWTvjYRS7W5L5r84U15Ztf28Ab2NJl5H+cZfARW/HNus/HiU+FHuyAWW1GUM+rMWEo8iiHBFldo5EV+3sv3ZJKETskfxRIhn9V43PJ7KA7EuOa5X4iKnAmxih0IycPPfaf9jrQvDfYzVo+1e2dxKPLUFP8YMYaFNJJhiegQhwnAjURSbJWbFgqs8Z09YYwi9hnnxjMEjFuYxqpnIYANH3O53PgIEIZNW46Kgx7WqN139RnMDV+pLFfmaPYWH2VUoXLrOreWrJWiXLSCt1ENQK9Bdwe+yQmH8qbYHP6+fjsrehT4vBIQQs4VgB+Rf40dW0cajHZc/eWNitI2kMjMTlBw9UwLiJ33rUTc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2718.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(136003)(366004)(39860400002)(396003)(376002)(66946007)(66556008)(66476007)(38100700002)(6512007)(6506007)(52116002)(8676002)(53546011)(31696002)(316002)(26005)(478600001)(86362001)(54906003)(8936002)(31686004)(44832011)(956004)(6916009)(16526019)(4326008)(2906002)(36756003)(83380400001)(186003)(6486002)(5660300002)(38350700002)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?V3hyUkdDMXdJWnk5bmFQVGtpQ2lvZkU0Q2J6THh0WkorSGJ5VzNBTCt2KzlK?= =?utf-8?B?WWxGZitGdnVZS0U5OURFNDZtdzZsOXJzdnM2eVFhbmlnWkl2U3VHSE1mR2tQ?= =?utf-8?B?NE9qK2FyNmpwZVltOGlDS3J6aEIxWGJTNkVqbnlQYUxsNjdlN2cvZ0YyRlpS?= =?utf-8?B?YTFMSjV2ck4rNkY5Q1ZyN1F0d01zMDFUamhYZkdsT1ZYT3hPYjFkclFMZDFr?= =?utf-8?B?U0ZEa1RlajFvUkJSVjhwS09aMDBhOWtMNmk4L3dMYm5rbTRmbmpXcC9TWXdt?= =?utf-8?B?eDBYZk41Y25wSXpXT2NqMlh3UUhiT1E3Z3dYd2prNk9aYXFwRStENitLZFkw?= =?utf-8?B?anJFMGtJa3F5cWZJSHpMWHFhQlB6d3NsbFoyckN3UWJHaEJLclJTQ2I3cXUx?= =?utf-8?B?SmROYS92KzJXUG1jWkI1TWdUdkJCbzVuTHNuOWpWTUY3OTNFMHhSc3cvQklo?= =?utf-8?B?MDZZZzB4SXorQXRSeVJmazdsSzJPWmxhMXlkYWUwZkI0Yyt6Wlo3REJ0dGFo?= =?utf-8?B?Q0lyOXRDK0lkeXlzeDFrRFVISXA0TEV3MnZVeWIxVzJSdG85Kzc4STlSTXRR?= =?utf-8?B?bFo0VnpSeENvbERQYUVVQ1FKNE10YmxNRmp3d3VmLzhTYVR0ZGdoSE5mVjNV?= =?utf-8?B?UTl6bkhiN3RvTktaMVFjUzFPK2pWSlE0aGN3ZlFqcTMySDlCdmtrL0RnK0ZI?= =?utf-8?B?R3g3cnI4WFpPS0pMSzdkVytER2ppdmFobnV4V1B3VXdJbXFhaDVuQWZPRThz?= =?utf-8?B?ZEhHRnNFMTFFV3o5WWdOdzgxUXpmRmJEL3FTM0pKSDBDTmgrdW42SzBRZksr?= =?utf-8?B?b01jc2FQd1U1T0J1NE1SUnpnVmRKMXdocjU2MUhXcjBYTVpQeFJJajd1aTZi?= =?utf-8?B?V0szckkvZklxbnMzNzBUNVlrNDhlU3llYjVBTXR4Q2ZqQlRmSDU5OTMyaGVH?= =?utf-8?B?ajdQSDJha3ViQXV6VGViK2M5clo2LzdGZ1lXN0REZlFwRkV6VDI0WFVzMm9T?= =?utf-8?B?WFIzVU80ZnovM1NjdTJkWEVyQUw5Vkx5T1EycHpGWWphYXFxdEZBT3M5VVp6?= =?utf-8?B?ZXkvUmtnR09kUngyYkx5amgvNlpvUEtONmlQVFk2SU03bGJGWngyaHlRYkNi?= =?utf-8?B?bWdnek9nRjhVUGp5MjBIcGduais0ZE9MUm5naldCbVRlb0V6YiszeGtHU0JZ?= =?utf-8?B?RExxdnlmMytoUDByWlpSOVE2clFiY1g0Tjl0VEFFK3RnT01HaXcwMXFRaFM3?= =?utf-8?B?eXF1OGJZbmtMSGNCZmsrMlczdGgxc1RDcW4yZTFDbFpxN3RvUEZrNXY5MTFU?= =?utf-8?B?bTJSQTJHVEVRUDdMbkh5Sk91WStwQ0tUUHdJRTMvb3IvVzdxenQ5S1NBVWFM?= =?utf-8?B?MjVDYU54ZjRRcjhoR3lPM3NaeitFbmZmR1cyK29FMjJZUDF6U010cFh4cnJy?= =?utf-8?B?MGhvUkhxMkhDUVZwbGF6aXVRZllkeXRXcGw2N25ZL3RQV3J0dTdpYXR2VGZI?= =?utf-8?B?OXAwVmNvc0o5VSt6QXVNZmd6bXZ4R3R5ZE5MczdzQ0l3V1F0aFg3TzZiNURC?= =?utf-8?B?Wkx2cUJIZGlXbXcxOEI4dmhyR2hqTGF2M1AySFJjd2wwdTJBTEdyMy9KYVUr?= =?utf-8?B?MVQ5TlFsQUNHMlJUTVoxd0xRM2RVNDBPRVhPYy82OFF2THJpTk9TODNEREpN?= =?utf-8?B?T1M0OWZUQmVQRVEyeXcvdnFyaWNTOHE2NVhFMWlZMUtDZGl1VnpjV1l5QTRk?= =?utf-8?Q?126QSqEF0jp0v0Vw2IdF35gWQYzrEeDywKK/dkJ?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5f57a15d-d95e-4ef1-b619-08d90f369337 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2718.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2021 19:55:32.8954 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Iqoavzp0VHqnn/6UZ9zqN1umv35jHXv2BWQOAbU2th1qFazIlTNoHBF8iLNqDrgP7oyV+pO93wkv9jvDz13S5Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB2542 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US On 5/4/21 2:07 PM, Brijesh Singh via groups.io wrote: >> Return EFI_UNSUPPORTED (0x8000_0003), or even EFI_NO_MAPPING >> (0x8000_0017), for value 6 (FAIL_SIZEMISMATCH). > I am not sure if we really want to do this. You will see later in the > patches that in some cases the PVALIDATE will return a failure and we > will need to know the failure code to determine the next steps. > Especially this particular error code is used later. This error happens > when the page size of the backing pages does not match with the > pvalidated size. In those cases we need to retry the PVALIDATE with > lower page size so that a validation succeed. One such a example is: > > - Guest ask hypervisor to add the page as 2M in RMP table. > > - Hypervisor added the page as 512 4K pages - because it was not able to > find a large backing pages. > > - Guest attempts to pvalidate the page as a 2M. The pvalidate will > return a failure saying its a size mismatch between the requested > pvalidated and RMP table. The recommendation is that guest should try > with a smaller page size. > > I would prefer to pass the pvalidate error as-is to caller so that it > can make the correct decision. > I am perfectly fine if the function return UINTN and then use #define instead of the enum to define the PVALIDATE return code. So that caller can check the error code. Let me know your thought on #define instead of the enum. -Brijesh