public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, rameshr@ami.com
Subject: Re: [edk2-devel] Issue in ShellPkg
Date: Fri, 19 Mar 2021 20:25:43 +0100	[thread overview]
Message-ID: <90fae744-e47a-d3c4-6903-b3659eb6547a@redhat.com> (raw)
In-Reply-To: <DM5PR1001MB23617E96D065F038BE433647A2689@DM5PR1001MB2361.namprd10.prod.outlook.com>

On 03/19/21 17:21, Ramesh R. wrote:
> In ShellPkg, file Cp.C, Function CopySingleFile Could see allocating the buffer to read/write on the BlockIo device. Don't see code that we are free the memory. So every time user copy the files in Shell, available memory going to reduce.
> 
>       //
>       // copy data between files
>       //
>       Buffer = AllocateZeroPool(ReadSize);

I think you are right. Please file a new bug report at
<https://bugzilla.tianocore.org/>, and please consider sending a patch
for this leak, to the list, with git-send-email.

Official workflow documentation:

https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process

Some unofficial hints:

https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers

Thanks!
Laszlo

> 
> Thanks,
> Ramesh
> 
> Please consider the environment before printing this email.
> 
> The information contained in this message may be confidential and proprietary to American Megatrends (AMI).  This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited.  Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.
> 
> 
> 
> 
> 
> 


      reply	other threads:[~2021-03-19 19:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-19 16:21 Issue in ShellPkg Ramesh R.
2021-03-19 19:25 ` Laszlo Ersek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=90fae744-e47a-d3c4-6903-b3659eb6547a@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox