From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124])
 by mx.groups.io with SMTP id smtpd.web08.2061.1616181950273030918
 for <devel@edk2.groups.io>;
 Fri, 19 Mar 2021 12:25:50 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=bKxG+Qf9;
 spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1616181949;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=IfvgHylJjelthjIcZ3oGaBykwim3AyshQBHZmSSI5Ts=;
	b=bKxG+Qf9YVNanamP6TV+GCinqfMzfJ/1f33KBACj3irIp+0/qaLi6ZcLFa9niEIXamKwmM
	PcRWNsO8LN5CC4MFeOSX3pw9t8eO/GrvRQiOucZMPC7FH4VwafSVm225bvqFwqdTN+DzZ4
	ryuRMnMo8f0rZcFxXkALLN6K3xgX1uw=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-375-BtRlTKM2NzSAjjmj-dod-w-1; Fri, 19 Mar 2021 15:25:46 -0400
X-MC-Unique: BtRlTKM2NzSAjjmj-dod-w-1
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DCB3D801817;
	Fri, 19 Mar 2021 19:25:44 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-31.ams2.redhat.com [10.36.114.31])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 416B52915E;
	Fri, 19 Mar 2021 19:25:44 +0000 (UTC)
Subject: Re: [edk2-devel] Issue in ShellPkg
To: devel@edk2.groups.io, rameshr@ami.com
References: <DM5PR1001MB23617E96D065F038BE433647A2689@DM5PR1001MB2361.namprd10.prod.outlook.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <90fae744-e47a-d3c4-6903-b3659eb6547a@redhat.com>
Date: Fri, 19 Mar 2021 20:25:43 +0100
MIME-Version: 1.0
In-Reply-To: <DM5PR1001MB23617E96D065F038BE433647A2689@DM5PR1001MB2361.namprd10.prod.outlook.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=windows-1252
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 03/19/21 17:21, Ramesh R. wrote:
> In ShellPkg, file Cp.C, Function CopySingleFile Could see allocating the buffer to read/write on the BlockIo device. Don't see code that we are free the memory. So every time user copy the files in Shell, available memory going to reduce.
> 
>       //
>       // copy data between files
>       //
>       Buffer = AllocateZeroPool(ReadSize);

I think you are right. Please file a new bug report at
<https://bugzilla.tianocore.org/>, and please consider sending a patch
for this leak, to the list, with git-send-email.

Official workflow documentation:

https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process

Some unofficial hints:

https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers

Thanks!
Laszlo

> 
> Thanks,
> Ramesh
> 
> Please consider the environment before printing this email.
> 
> The information contained in this message may be confidential and proprietary to American Megatrends (AMI).  This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited.  Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.
> 
> 
> 
> 
> 
>