Issue in ShellPkg

Issue in ShellPkg

[Ramesh R.]

[-- Attachment #1: Type: text/plain, Size: 953 bytes --]

In ShellPkg, file Cp.C, Function CopySingleFile Could see allocating the buffer to read/write on the BlockIo device. Don't see code that we are free the memory. So every time user copy the files in Shell, available memory going to reduce.

      //
      // copy data between files
      //
      Buffer = AllocateZeroPool(ReadSize);

Thanks,
Ramesh

Please consider the environment before printing this email.

The information contained in this message may be confidential and proprietary to American Megatrends (AMI).  This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited.  Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.

[-- Attachment #2: Type: text/html, Size: 4346 bytes --]

Re: [edk2-devel] Issue in ShellPkg

[Laszlo Ersek]

On 03/19/21 17:21, Ramesh R. wrote:
> In ShellPkg, file Cp.C, Function CopySingleFile Could see allocating the buffer to read/write on the BlockIo device. Don't see code that we are free the memory. So every time user copy the files in Shell, available memory going to reduce.
> 
>       //
>       // copy data between files
>       //
>       Buffer = AllocateZeroPool(ReadSize);

I think you are right. Please file a new bug report at
<https://bugzilla.tianocore.org/>, and please consider sending a patch
for this leak, to the list, with git-send-email.

Official workflow documentation:

https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process

Some unofficial hints:

https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers

Thanks!
Laszlo

> 
> Thanks,
> Ramesh
> 
> Please consider the environment before printing this email.
> 
> The information contained in this message may be confidential and proprietary to American Megatrends (AMI).  This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited.  Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.
> 
> 
> 
> 
> 
>