From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id E12C49415DD for ; Tue, 17 Oct 2023 10:07:07 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=rINCPNPl8zbct/JAR1wppcgmTagnpTGj6u3yZh/4fTw=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Message-ID:Date:User-Agent:Subject:To:Cc:References:From:In-Reply-To:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1697537226; v=1; b=TjQMBJCIs5ZoM545CPhXGOLAQ+COlwv0TpCsdPbwL2JGemJDMFVO/CogKJY4BMKjEvgZrXB9 ZLdcvIB7gOptvrGBYoyZ0d2bRT0Lgrch8c3TNmJCsa7dYpmMnJ6n4WUbQ9iEsZCH2mGdLJHnJNS CTYnBJw64WQbZswFA5Um5P0w= X-Received: by 127.0.0.2 with SMTP id ZWw0YY7687511xoQQX3qE9E8; Tue, 17 Oct 2023 03:07:06 -0700 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.135]) by mx.groups.io with SMTP id smtpd.web10.204999.1697537225618303665 for ; Tue, 17 Oct 2023 03:07:05 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nxek+RraYZx1vBZXToSY81ho2W1OHcuCH2QDXlVI53FoxdZYpDxMT37tKrl0DnteRUQ1HZSB0BqrHebxr9NEnLA/UDuh1PSNkWRoXzdjIpEEHrWJ2a0nlEJRnPMZ29gzzlzhEUBtnJf4Olu3y59DtE0K9l62hrmWsuZGQa4+L/ZUbMhHKjxUfAU5CNLTxQ7/8GF45bVyFvesFoDuLpmIrY39vyqV8vzU+POqWOr2n52+k/qviGrfod80Rlc0FlCBtAdVECQFYPURo1uWAIhhq8+WnwDWJQjQH6pUYenA5KgErO+eVCydcf9Z2clqQTxbpJtmFr1eZFZvfxeA11ZmxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IWmSV/5uPg2WMHw4J54IGWXRTbDrjrl322wyikvkJ6U=; b=DFx27qr8IBSanGo5cJ4TDx3Wc4cuhSYNj8AaSk23aTbWNGiuCWmuZcKQQa1fJwOLd51WHrIx7bC7UvHhNYdtzB9UAyFKL5FVUDOnWbJWWCubJz0d3n11Tl2Ihmx/XgV2h8AEqM7016OkFiVy4yjXn2tENoiZJ9THBkQMHdetq8cYH5vzWxjewapMWWEDh9q23s8tjZJGt/sWxc5QllgzSvXXbTYkp8tIA8pmjpjedbdK9gNPRai8FSwm2riMxsIP2XfIjbc3Umo+/1AObW5ddU3POGDYZmynRVmt3GSjOht3oqFkSFwT/5XjcbVbachFD70U8/rhrOVQTFO/YMtlvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from LV3PR01MB8464.prod.exchangelabs.com (2603:10b6:408:1a3::7) by SJ0PR01MB8181.prod.exchangelabs.com (2603:10b6:a03:4e2::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.35; Tue, 17 Oct 2023 10:06:59 +0000 X-Received: from LV3PR01MB8464.prod.exchangelabs.com ([fe80::c4f1:5794:f1e6:5fdd]) by LV3PR01MB8464.prod.exchangelabs.com ([fe80::c4f1:5794:f1e6:5fdd%4]) with mapi id 15.20.6863.043; Tue, 17 Oct 2023 10:06:58 +0000 Message-ID: <912d1ff6-1bca-4eae-8007-cae4ba11022d@os.amperecomputing.com> Date: Tue, 17 Oct 2023 04:06:50 -0600 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [edk2-platforms PATCH 1/1] AmpereAltraPkg/Ac01PcieLib: drop useless link status register read To: Laszlo Ersek , devel@edk2.groups.io Cc: Chuong Tran , Leif Lindholm , Nhi Pham References: <20231017100507.43573-1-lersek@redhat.com> From: "Rebecca Cran via groups.io" In-Reply-To: <20231017100507.43573-1-lersek@redhat.com> X-ClientProxiedBy: CH5P222CA0009.NAMP222.PROD.OUTLOOK.COM (2603:10b6:610:1ee::25) To LV3PR01MB8464.prod.exchangelabs.com (2603:10b6:408:1a3::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV3PR01MB8464:EE_|SJ0PR01MB8181:EE_ X-MS-Office365-Filtering-Correlation-Id: 39b34fbd-a167-41a4-c107-08dbcef8cc9b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: 5pzk/oaCfxMeXJoBJC/inXlspxj8V2tOJH8U0wscM0HkokgVG2QNh07I5nrfgfal8i6nNwIyQ4M0pVBq2TAHYc5Krhsw//l8r+B6jfIheHFSTywJGuGHZDl3Mw0B7+3Fuzi2xobuigB6VnOxCIMAorlPMigEbfVnhnUwzbazqDmAhgoxyjAg49+mq20VtmxoFsjwZ+ncHvBYWvGZuX1J1Ve0rc+Qybv2/pbbTDPmYAgSoLOcieQea1+oYBsOFUzWtNbm3dqNUHXV0y8k7h9prQBhLftbbZiSIAw6cvCFwZwNapBVlN5hVwxWxEuP313BONU4SVO/445B2rO2GuljsV1UpqtdrEs6Du1z0BNTt9jvysGygqdSw+NyPhTBeurUqNiFmckOQx41x1y4aTRkkSX1XM3XcEyZ12bOGQeIY4z2zjHo8vtQ7YUeL1MFSRP877GbkdFFjozFL2YSBNg4Y0VoIZvN/VlZ25kz7KlWfKsGb2kVgwadMFAeDlaeAblIdB7jIBT8B/g3wEFC9CM0+IEh48v3JZQIRFQWNpCg9nKwmKjHmf91oymJFecGXZSdox1b+RXL3KaO8rFrCYcY7B9YkCrSkffslH/0bfxl/61IIXvNm1hRFnL5KbnIMDrj X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dmQ5L3oxYjdVQlVxVjkxcXRqWG5jSWFoM3IrZUFLTWNIZnJ5TnFWaHoxWXlp?= =?utf-8?B?T1RpNk5qZmJJSllDVnFzNzNHMSt1WUR1VUd1eWRHbDJZK2dCaGp6OVV5Q1RS?= =?utf-8?B?TTh1UUduNUZ4THFTZnhFN2oxbFV6VllURmd5bll5UWczbXcvdm5WUVVHNnBk?= =?utf-8?B?TnU2TDhmUWpQK2dSYmh1dVdxeDZYTEdyclJLU09VK3B3N09Da2pRR0tQRmNw?= =?utf-8?B?ZVFNNU5oZ1NmenlvRnFFT0tKZ1VBUWJvdWxZZkxEeEg5U1gzUTROaW1hMHBN?= =?utf-8?B?RmJVRkRZRm9LOXJMa0RxV25JZUpXUFlYbW1EeWdNcWdhZGlxOTFFbXI3aHlP?= =?utf-8?B?UGdnTDRBS3Y4Q1Rmb2xTYnFxZ2twcjhnanZpV2R6VDFVdGcxbmU5KzdLc25j?= =?utf-8?B?YnZxT1Yxc2tqMm9VdjI0aGtQR2xJeWZpY2lsRG0vSW5tTmRwLzBjdVZUNE42?= =?utf-8?B?Z0c1d290TEYzZy9PdnBzanVFYlpLV25vRXZTY3JZbDBCWkRNQkQwN0tabDJV?= =?utf-8?B?ZTdrVVFnd3pKUHBqaTlKS1JMdGZNWjhDaUtYQVB6RUN0TjlKYWpnT2taVUQx?= =?utf-8?B?am1JeVFUcVdDMW8rbFlWWmlVSys5d2M0WjQ3UGEvTk9aVFMvcG9mTERBYUg4?= =?utf-8?B?cmIyTFpVbmVxV2g5QlRvazBPVVYyd0tmS3E3S3RSNGZJQi9hTk5EbXhWbnZE?= =?utf-8?B?b3l5TkprR0hWZFlFSE8rUjMyRWxGbG5OdUl1N3d3SUc1cTZqV1VTUTJjRGtF?= =?utf-8?B?N3BOanBGdG9jNGY4QVN2VkNIWWkwMHZtVXJsQWs4K1JvNERWL3liRDZrOVRr?= =?utf-8?B?cERPUEhFQm5IMU9RQ3lJbm44OWZTL2NFTll6U0dTMTZ3RDVZdVB2OG9Sellx?= =?utf-8?B?d1BqS0lMOEtzYUhHNXZJdGs2eC81bU1SWG1oOXlvNC8xdUpNR1NyaGxsb2xE?= =?utf-8?B?TjNEVVYxdzVPVnh3aXd0VjkyZDJGK3ZqQmlOb3dOcUdjR2tmT2ltdWR0Rmpo?= =?utf-8?B?OUMyQVVCYjI4bnJBVHJJWXR4Q0NnZmhwUVNOVzl1YU1GYWRLb1hpcjVRRkM5?= =?utf-8?B?dzEyWDdSaXhrLzBBVHplU2premVCYk5jdVpDcE1DZTdCK2o0bE45QVNqSUtQ?= =?utf-8?B?U2hTTEJ1YkVCOHhxR21xcjFuaUQ0SmJneWFjeW9rV2FsMW1xSG9FMkhuZGxM?= =?utf-8?B?Z3hCWGVlc3VYaWR0ZjN4NWg0UnJIdFJCeDBLeXViSXVOMVlYQ0FxY0dSdjd0?= =?utf-8?B?SlorZlpaWUlONitVV1BvRzVacFBqbUlwZ2RpMWpxcC9IZG5wZzlmSmFIeUlQ?= =?utf-8?B?WndVYlkvaVNLUVFvbzV5VnBVSElRVU9YUXUyUHhiQmtoaGp0a1VQSEhHMXp5?= =?utf-8?B?aDg1M2FLcm5pU0ZVZEpYQlR4cEZMOTF3TVE1N3RQMkdxSkYzbFlpRVNldDdO?= =?utf-8?B?SmJZT0swSzU2c01LM3l6a3JNa2RrVnNTTm5EYWNuL1prTmY2dDllVWdBTDFx?= =?utf-8?B?L256MXhjaHFiYUtBajlRWkNVR2lQbU9MODY4VVJHWXIvU1MyZ1phMjdNa2RG?= =?utf-8?B?QmVvek1IUVZGbngvcEF0cGh4ZHl1Z0duV3ZraHkrNmxUS1FXTWpIakdvQ1R2?= =?utf-8?B?WmtUN0h5TjZnR0JDeUZETCtTWUxTbWwvZXBONjA3ZDVQalM1YU5PUlFSekZC?= =?utf-8?B?M2xZc0RzbFJNRzBNVlBsZkhEQnF0aW55UC80K1FBKzhHamRvZzZ2RmdKV2VD?= =?utf-8?B?QUsreU81QlBUbXRudnNpeFJqZkJXb1NkamYyd1czYWFKRGtXR0UzbHYrVW9v?= =?utf-8?B?d3IrS3NqTnJPMm5ZclRhMFBid2MvNTBMQ2IrZEtNVFdPM0h2bFEzNExsV2hC?= =?utf-8?B?cWRVMWg2OWlvUHlVZk9ZSDNQZmY2d1ZPTG80cnNZayszZXR3STJoMjFVdE1H?= =?utf-8?B?Skl0QVlzSlBBR29QclFJNFNXWTlmTnJUMURqZFl0UHl6Q3YyWHoxV3h1U041?= =?utf-8?B?TkdaMVNUMmhxNW9WTHhVK3l0TU9Zc053cmY0T2g5Zmd3cmluK2NlbnhJTndw?= =?utf-8?B?dlBiOFp1dis5b3h0Lzc0b1hpTGxOS2NJUllyS3g4UmhGcFRrVmtoQ2dHSmJQ?= =?utf-8?B?RGlwN3E3UDN1VlVJcndoc1lncC9QMmNoWFBmaGhyd3NVZmRqRHlMN0QrSVJ3?= =?utf-8?Q?s6nLBsj2nGE2ptkl2BDTqHg=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 39b34fbd-a167-41a4-c107-08dbcef8cc9b X-MS-Exchange-CrossTenant-AuthSource: LV3PR01MB8464.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2023 10:06:58.4551 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PGcPqguPRKjfsKY3EjrLQpeITIuOwDYoTGO29h1dUEyOY1STz6gJ+nzkwrIxkt21HyWEPT82AAOXgky/q3pQrMp4rlzTbqjylBZcLfLskMgoo2MwTleQ44xjAPfPusA5 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR01MB8181 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,rebecca@os.amperecomputing.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 4mPBMmFzh5FDihKgjqQF4uvOx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=TjQMBJCI; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 10/17/2023 4:05 AM, Laszlo Ersek wrote: > Nhi says that reading LINK_CONTROL_LINK_STATUS_REG is redundant; its only > use was debugging (before commit 380b4b40c60d). Thus, we can go farther > than commit 2e27c62ef000, and remove the MmioRead32() call altogether. >=20 > Build-tested with "Jade.dsc". >=20 > Cc: Chuong Tran > Cc: Leif Lindholm > Cc: Nhi Pham > Cc: Rebecca Cran > Suggested-by: Nhi Pham > Signed-off-by: Laszlo Ersek > --- > Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c | 3 --- > 1 file changed, 3 deletions(-) >=20 > diff --git a/Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c= b/Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c > index fa00c1e36999..dea2e6406dfd 100644 > --- a/Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c > +++ b/Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c > @@ -1744,7 +1744,6 @@ Ac01PcieCoreUpdateLink ( > ) > { > AC01_PCIE_CONTROLLER *Pcie; > - PHYSICAL_ADDRESS CfgBase; > UINT8 PcieIndex; > UINT32 Index; > =20 > @@ -1761,12 +1760,10 @@ Ac01PcieCoreUpdateLink ( > // Loop for all controllers > for (PcieIndex =3D 0; PcieIndex < RootComplex->MaxPcieController; Pci= eIndex++) { > Pcie =3D &RootComplex->Pcie[PcieIndex]; > - CfgBase =3D RootComplex->MmcfgBase + (RootComplex->Pcie[PcieIndex].D= evNum << DEV_SHIFT); > =20 > if (Pcie->Active && !Pcie->LinkUp) { > if (PcieLinkUpCheck (Pcie)) { > Pcie->LinkUp =3D TRUE; > - (VOID)MmioRead32 (CfgBase + PCIE_CAPABILITY_BASE + LINK_CONTROL_= LINK_STATUS_REG); > =20 > // Doing link checking and recovery if needed > Ac01PcieCoreQoSLinkCheckRecovery (RootComplex, PcieIndex); Reviewed-by: Rebecca Cran --=20 Rebecca Cran -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109670): https://edk2.groups.io/g/devel/message/109670 Mute This Topic: https://groups.io/mt/102014532/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-