From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 84531D8066D for ; Sun, 31 Mar 2024 12:03:39 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=S2XBKFHL8Fy6QlqvKr13jVsaGQvnn4KxHIZdlU5Woaw=; c=relaxed/simple; d=groups.io; h=Received-SPF:Message-ID:Date:User-Agent:Subject:To:Cc:References:From:In-Reply-To:MIME-Version:NoDisclaimer:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1711886618; v=1; b=zZSTZdEoq83kkvaSDCs7Hnq1AliEGmAOw1cfcbMo8NDYMfaIQDR2xDB2YXPBD10O1boiPIng AE+U9alDh/zKeJS1FkXVSxNv7+Qj0oaXzZk8OPNoKmp5rvrXgbtOkT81CbHU3FkHPuOCuGEwMpg CmvSEseSpFCDxXg9ujzmquK5wr9Tnfzo80y4Gk8RzKQmWP/Rgj1eKgcHHne/p0NmnRhsVR7AoQL Y7E+MdBxlcHvMzsQ/pdxOjK97mxCKHPt31k9Y3ekkOAngXco3Qohr+G8CYAzbP+VsuOb2eokORQ nNOcyCefQ3uGNFB+hEcUzUmw8BIv5e36uBzbR7XMqZIMg== X-Received: by 127.0.0.2 with SMTP id CcsVYY7687511x4JISfMia0K; Sun, 31 Mar 2024 05:03:38 -0700 X-Received: from EUR05-VI1-obe.outbound.protection.outlook.com (EUR05-VI1-obe.outbound.protection.outlook.com [40.107.21.59]) by mx.groups.io with SMTP id smtpd.web11.15708.1711886617079458804 for ; Sun, 31 Mar 2024 05:03:37 -0700 X-Received: from AS9PR05CA0257.eurprd05.prod.outlook.com (2603:10a6:20b:493::9) by GV1PR08MB10608.eurprd08.prod.outlook.com (2603:10a6:150:15e::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.43; Sun, 31 Mar 2024 12:03:31 +0000 X-Received: from AMS0EPF000001B7.eurprd05.prod.outlook.com (2603:10a6:20b:493:cafe::b0) by AS9PR05CA0257.outlook.office365.com (2603:10a6:20b:493::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46 via Frontend Transport; Sun, 31 Mar 2024 12:03:31 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AMS0EPF000001B7.mail.protection.outlook.com (10.167.16.171) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.10 via Frontend Transport; Sun, 31 Mar 2024 12:03:31 +0000 X-Received: ("Tessian outbound e26069fc76b9:v300"); Sun, 31 Mar 2024 12:03:31 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: dca2d4c4917cf331 X-CR-MTA-TID: 64aa7808 X-Received: from da80030ccabc.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 22180ED3-FD49-4574-87CC-F7A52EAF1DCF.1; Sun, 31 Mar 2024 12:03:19 +0000 X-Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id da80030ccabc.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sun, 31 Mar 2024 12:03:19 +0000 X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by GVXPR08MB10430.eurprd08.prod.outlook.com (2603:10a6:150:14e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.42; Sun, 31 Mar 2024 12:03:17 +0000 X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::1e13:dc65:224e:219c]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::1e13:dc65:224e:219c%5]) with mapi id 15.20.7409.042; Sun, 31 Mar 2024 12:03:17 +0000 Message-ID: <915f77a0-b96d-43e0-a517-d2e72ec9251b@arm.com> Date: Sun, 31 Mar 2024 13:03:15 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [edk2-platforms][PATCH v5 6/9] Platform/Sgi: Add initial support for RD-Fremont platform To: Prabin CA , devel@edk2.groups.io Cc: Ard Biesheuvel , Leif Lindholm , Thomas Abraham , "nd@arm.com" References: <20240311131416.823580-1-prabin.ca@arm.com> <20240311131416.823580-7-prabin.ca@arm.com> From: "Sami Mujawar" In-Reply-To: <20240311131416.823580-7-prabin.ca@arm.com> X-ClientProxiedBy: LO4P123CA0358.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18d::21) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|GVXPR08MB10430:EE_|AMS0EPF000001B7:EE_|GV1PR08MB10608:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: L5p2Xiaz/35yC57VAyVEZwsf750zF7u5v6ki78wan0Qy8wwOCBLC7f0vPbSlzY1uIyAYRKdZCORH8kvNN/b3Lr6MMCuxAYHvK4XoBbqJO1EmIxJ45MuyVH5R8bsKBSI6YaVk8sX12i1IpS+1deItEWeA/I2kJCBgyvp+UQGh/Nqs+bTq0aULe+gH8EK/5wuhTttZ4Ift9ZGShpHjUojkmq5oFTVLeigEViFAmqlYbzZVnO1KoIVzzWSRVptf+6/KWi5Ayyy5SmPy4GpwPK1yGxMTfZ8gQaw5HG7xjUqqUSuhIbJareaKid4JlmfFexKtP8/j/MXnP92LKZ+RTM5AgacAjwzBL2k/MVlIj/uVvnfLFJx2shAQeAMdoQuAH5Mf2OIVIJ8U1yspoSGggXcacsZ8Ex4EMIF60p3LzoX5NNdYtV3e37Lf7DCzSaw0VdNbcwn0FxpYPaNkIvCTbTL67inaU+7EP15pLsyDzbE4RUiIHC0xmaS3nmELDDkjaYjor5+WN9ih45jOWqwU5NzJfDyiZKZglpupemy7yoejoCRZiIFnV4jO/quQ5bEW92VwJCQ+CVBAF6pFoFwbBT7fUOD+GmGwzIMv+cdbSN07EkPAmohoaiVBBXk9nr3x6CYXUqFTYlazVaByPhWuCYVabC4kV05p5shVMegIonWH7Pc= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366007)(376005)(1800799015);DIR:OUT;SFP:1102; X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR08MB10430 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AMS0EPF000001B7.eurprd05.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 13488d33-034c-47a7-4f37-08dc517a9560 X-Microsoft-Antispam-Message-Info: 73BpqgpUoKlkldkLUxZAFzc+KhPSgUVLcST0q7xmu3cD7yeoEsGzBktb232DOqNe1LvlkX6aEnLJQy5YTVxI7eiDS/mWqt6rJInFx4yOQ9vO6+0/WhdbVwlEMeyYQcPje+9lSz9JjlxQArIjn78bef/pitouVZAVcuDgtzqkgKuqxoMUzo9mwHxFWgpp7vsZjn186uaE/N0T9Ldv58+Kcd7ajjz9QG/euBMJmoHwSWtCQmuo0H8Ygurbd8TapfwDzUTfffLoaHLAMqCoN02DhE53nR8vxY6At63ezctF49kNa8Jnp5mMbyLXIaGOiBQd5r4XvuoqGqG68rmYYfoRwT8+vNYeZ+Y8nkeiuJorsHMy7VdeuBGzWCVJDLUOnpr4zb0zDn53UaVuQvZYCRwcpPt8aD6FLCG+wFACsV123DPPmru2cLzbfIXSNVMVRB9AF8MJ0B2PqM98jq+dynz5YahFgu4WdyaeYvskIWlbYr+TA0e+pcA+FiVi/XbSaxPCNpIV/GPUq+b7S6+y9AcTLkyZgk0vilnshfaSv0coqbzzwsRYU0pER0Ye2z/+ORhY+h3FcecrXOod+fSPsueVzz/aG0gcQKPS9ME+664Y7PBLago6RQ614oXgoFZHnI7jj418xFBto6xRcOUMGuuzS7/hYvKO3f3TgrpB9nesPWaSWrO/8V7ttn3bTp/sQrPbPNniUmM5hFd6chfkf7JBmzAIURgSZ+mXlWFfoeQCrB1lKAcmhEJFFa2VsFn186wE X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2024 12:03:31.3119 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 13488d33-034c-47a7-4f37-08dc517a9560 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AMS0EPF000001B7.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB10608 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Sun, 31 Mar 2024 05:03:37 -0700 Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: HEOQzHVx06LWKLXcxPRqBVIZx7686176AA= Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=zZSTZdEo; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none) Hi Prabin, Thank you for this patch. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 11/03/2024 01:14 pm, Prabin CA wrote: > The RD-Fremont fixed virtual platform simulates 16 CPUs and 8GB of RAM. > Add initial support for this platform by adding the required platform > build configuration files. This platform has considerable differences in > its memory map compared to its predecessors. So add a corresponding > memory map file as well to define the PCDs for its generation of > platforms. > > Signed-off-by: Prabin CA > --- > Platform/ARM/SgiPkg/SgiMemoryMap3.dsc.inc | 71 ++++++++++++++++++= ++ > Platform/ARM/SgiPkg/RdFremont/RdFremont.dsc | 55 +++++++++++++++ > Platform/ARM/SgiPkg/RdFremont/RdFremont.fdf.inc | 10 +++ > 3 files changed, 136 insertions(+) > > diff --git a/Platform/ARM/SgiPkg/SgiMemoryMap3.dsc.inc b/Platform/ARM/Sgi= Pkg/SgiMemoryMap3.dsc.inc > new file mode 100644 > index 000000000000..06c3b37388c1 > --- /dev/null > +++ b/Platform/ARM/SgiPkg/SgiMemoryMap3.dsc.inc > @@ -0,0 +1,71 @@ > +# > +# Copyright (c) 2024, Arm Limited. All rights reserved. > +# > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > + > +[PcdsFixedAtBuild.common] > + # System Peripherals > + gArmSgiTokenSpaceGuid.PcdSmcCs0Base|0x08000000 > + gArmSgiTokenSpaceGuid.PcdSmcCs1Base|0x0600000000 > + gArmSgiTokenSpaceGuid.PcdSysPeriphBase|0x0C000000 > + gArmSgiTokenSpaceGuid.PcdSysPeriphSysRegBase|0x0C010000 > + > + # SP804 dual timer > + gArmSgiTokenSpaceGuid.PcdSp804DualTimerBaseAddress|0x0C110000 > + gArmSgiTokenSpaceGuid.PcdSp804DualTimerSize|0x00010000 > + gArmSgiTokenSpaceGuid.PcdSp804DualTimerInterrupt|216 > + > + # Virtio Disk > + gArmSgiTokenSpaceGuid.PcdVirtioBlkBaseAddress|0x0C130000 > + gArmSgiTokenSpaceGuid.PcdVirtioBlkSize|0x10000 > + gArmSgiTokenSpaceGuid.PcdVirtioBlkInterrupt|184 > + > + # GPIO controller > + gArmSgiTokenSpaceGuid.PcdGpioController0BaseAddress|0x0C1D0000 > + gArmSgiTokenSpaceGuid.PcdGpioController0Size|0x00010000 > + gArmSgiTokenSpaceGuid.PcdGpioController0Interrupt|168 > + > + # Ethernet > + gArmSgiTokenSpaceGuid.PcdVirtioNetBaseAddress|0x0C150000 > + gArmSgiTokenSpaceGuid.PcdVirtioNetInterrupt|186 > + > + # PL031 RealTimeClock > + gArmPlatformTokenSpaceGuid.PcdPL031RtcBase|0x0C170000 > + > + # Virtio P9 > + gArmSgiTokenSpaceGuid.PcdVirtioP9BaseAddress|0x0C190000 > + gArmSgiTokenSpaceGuid.PcdVirtioP9Size|0x10000 > + gArmSgiTokenSpaceGuid.PcdVirtioP9Interrupt|185 > + > + # PL370 - HDLCD1 > + gArmPlatformTokenSpaceGuid.PcdArmHdLcdBase|0x0EF60000 > + > + # PL011 - Serial Debug UART > + gArmPlatformTokenSpaceGuid.PcdSerialDbgRegisterBase|0x0EF70000 > + gArmPlatformTokenSpaceGuid.PcdSerialDbgInterrupt|179 > + > + # PL011 - Serial Terminal > + gArmPlatformTokenSpaceGuid.PL011UartInterrupt|112 > + > + # System Memory (2GB - 128MB of Trusted DRAM at the top of the 32bit a= ddress space) > + gArmTokenSpaceGuid.PcdSystemMemoryBase|0x80000000 > + gArmTokenSpaceGuid.PcdSystemMemorySize|0x78000000 > + > + # SMMU > + gArmSgiTokenSpaceGuid.PcdSmmuBase|0x280000000 > + gArmSgiTokenSpaceGuid.PcdSmmuSize|0x4000000 > + > + # Non-Volatile variable storage > + gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase64|0x06000= 00000 > + gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwWorkingBase64|0x060= 1400000 > + gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareBase64|0x06028= 00000 > + > + # Address bus width - 64TB address space > + gArmSgiTokenSpaceGuid.PcdMaxAddressBitsPerChip|46 > + > + # Timer & Watchdog interrupts > + gArmSgiTokenSpaceGuid.PcdGtFrame0Gsiv|109 > + gArmSgiTokenSpaceGuid.PcdGtFrame1Gsiv|108 > + gArmSgiTokenSpaceGuid.PcdWdogWS0Gsiv|110 > + gArmSgiTokenSpaceGuid.PcdWdogWS1Gsiv|111 > diff --git a/Platform/ARM/SgiPkg/RdFremont/RdFremont.dsc b/Platform/ARM/S= giPkg/RdFremont/RdFremont.dsc > new file mode 100644 > index 000000000000..b52d2f59e15d > --- /dev/null > +++ b/Platform/ARM/SgiPkg/RdFremont/RdFremont.dsc > @@ -0,0 +1,55 @@ > +# > +# Copyright (c) 2024, Arm Limited. All rights reserved. > +# > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > + > +########################################################################= ######## > +# > +# Defines Section - statements that will be processed to create a Makefi= le. > +# > +########################################################################= ######## > +[Defines] > + PLATFORM_NAME =3D RdFremont > + PLATFORM_GUID =3D fd140b0f-4467-4314-aa69-cd0bd712e08= e > + PLATFORM_VERSION =3D 0.1 > + DSC_SPECIFICATION =3D 0x0001001B > + OUTPUT_DIRECTORY =3D Build/$(PLATFORM_NAME) > + SUPPORTED_ARCHITECTURES =3D AARCH64 > + BUILD_TARGETS =3D NOOPT|DEBUG|RELEASE > + SKUID_IDENTIFIER =3D DEFAULT > + FLASH_DEFINITION =3D Platform/ARM/SgiPkg/SgiPlatform.fdf > + BOARD_DXE_FV_COMPONENTS =3D Platform/ARM/SgiPkg/RdFremont/RdFre= mont.fdf.inc > + BUILD_NUMBER =3D 1 > + > +# include common definitions from SgiPlatform.dsc > +!include Platform/ARM/SgiPkg/SgiPlatform.dsc.inc > +!include Platform/ARM/SgiPkg/SgiMemoryMap3.dsc.inc > + > +# include common/basic libraries from MdePkg. > +!include MdePkg/MdeLibs.dsc.inc > + > +########################################################################= ######## > +# > +# Pcd Section - list of all EDK II PCD Entries defined by this Platform > +# > +########################################################################= ######## > + > +[PcdsFixedAtBuild.common] > + # GIC Base Addresses > + gArmTokenSpaceGuid.PcdGicDistributorBase|0x30000000 > + gArmTokenSpaceGuid.PcdGicRedistributorsBase|0x301C0000 > + gArmSgiTokenSpaceGuid.PcdGicSize|0x200000 > + > + # ARM Cores and Clusters > + gArmPlatformTokenSpaceGuid.PcdCoreCount|1 > + gArmPlatformTokenSpaceGuid.PcdClusterCount|16 > + > +########################################################################= ######## > +# > +# Components Section - list of all EDK II Modules needed by this Platfor= m > +# > +########################################################################= ######## > + > +[Components.common] > + Platform/ARM/SgiPkg/AcpiTables/RdFremontAcpiTables.inf > diff --git a/Platform/ARM/SgiPkg/RdFremont/RdFremont.fdf.inc b/Platform/A= RM/SgiPkg/RdFremont/RdFremont.fdf.inc > new file mode 100644 > index 000000000000..a465b7426653 > --- /dev/null > +++ b/Platform/ARM/SgiPkg/RdFremont/RdFremont.fdf.inc > @@ -0,0 +1,10 @@ > +# > +# Copyright (c) 2024, Arm Limited. All rights reserved. > +# > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > + > +# Per-platform additional content of the DXE phase firmware volume > + > + # ACPI support > + INF RuleOverride=3DACPITABLE Platform/ARM/SgiPkg/AcpiTables/RdFremontA= cpiTables.inf -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117264): https://edk2.groups.io/g/devel/message/117264 Mute This Topic: https://groups.io/mt/104862634/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-