From: Laszlo Ersek <lersek@redhat.com>
To: Eric Dong <eric.dong@intel.com>, edk2-devel@lists.01.org
Cc: Ray Ni <ray.ni@intel.com>, Aleksiy <oleksiyy@ami.com>
Subject: Re: [Patch 0/2] Use correct field name.
Date: Fri, 11 Jan 2019 11:45:06 +0100 [thread overview]
Message-ID: <91711939-5a5e-11d3-691b-830cb8062584@redhat.com> (raw)
In-Reply-To: <20190111054639.25528-1-eric.dong@intel.com>
On 01/11/19 06:46, Eric Dong wrote:
> ((Facs->Flags & EFI_ACPI_4_0_OSPM_64BIT_WAKE__F) != 0))
>
> In above code, Facs->OspmFlags should be used instead.
> EFI_ACPI_4_0_OSPM_64BIT_WAKE__F is a bit in OSPM Enabled Firmware
> Control Structure Flags field, not in Firmware Control Structure
> Feature Flags.
>
> Update all related code to use correct field name.
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1430
>
> Cc: Aleksiy <oleksiyy@ami.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Jian Wang <jian.j.wang@intel.com>
> Eric Dong (2):
> UefiCpuPkg/S3Resume2Pei: Use correct field name.
> MdeModulePkg/BootScriptExecuteorDxe: Use correct field name.
>
> MdeModulePkg/Universal/Acpi/BootScriptExecutorDxe/ScriptExecute.c | 4 ++--
> MdeModulePkg/Universal/Acpi/BootScriptExecutorDxe/X64/SetIdtEntry.c | 4 ++--
> UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c | 6 +++---
> 3 files changed, 7 insertions(+), 7 deletions(-)
>
Regression-tested-by: Laszlo Ersek <lersek@redhat.com>
next prev parent reply other threads:[~2019-01-11 10:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190111054639.25528-1-eric.dong@intel.com>
2019-01-11 5:46 ` [Patch 1/2] UefiCpuPkg/S3Resume2Pei: Use correct field name Eric Dong
2019-01-11 9:52 ` Laszlo Ersek
2019-01-11 5:46 ` [Patch 2/2] MdeModulePkg/BootScriptExecuteorDxe: " Eric Dong
2019-01-11 9:46 ` Laszlo Ersek
2019-01-11 10:45 ` Laszlo Ersek [this message]
2019-01-14 3:18 ` [Patch 0/2] " Zeng, Star
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91711939-5a5e-11d3-691b-830cb8062584@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox