From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lersek@redhat.com>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com;
 receiver=edk2-devel@lists.01.org 
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id BDEFF2119BBD9
 for <edk2-devel@lists.01.org>; Fri, 11 Jan 2019 02:45:09 -0800 (PST)
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com
 [10.5.11.16])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 11EDE356F2;
 Fri, 11 Jan 2019 10:45:09 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-3.rdu2.redhat.com
 [10.10.120.3])
 by smtp.corp.redhat.com (Postfix) with ESMTP id DD8425E1A7;
 Fri, 11 Jan 2019 10:45:07 +0000 (UTC)
To: Eric Dong <eric.dong@intel.com>, edk2-devel@lists.01.org
Cc: Ray Ni <ray.ni@intel.com>, Aleksiy <oleksiyy@ami.com>
References: <20190111054639.25528-1-eric.dong@intel.com>
From: Laszlo Ersek <lersek@redhat.com>
Message-ID: <91711939-5a5e-11d3-691b-830cb8062584@redhat.com>
Date: Fri, 11 Jan 2019 11:45:06 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20190111054639.25528-1-eric.dong@intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.30]); Fri, 11 Jan 2019 10:45:09 +0000 (UTC)
Subject: Re: [Patch 0/2] Use correct field name.
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Jan 2019 10:45:09 -0000
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 01/11/19 06:46, Eric Dong wrote:
> ((Facs->Flags & EFI_ACPI_4_0_OSPM_64BIT_WAKE__F) != 0))
> 
> In above code, Facs->OspmFlags should be used instead.
> EFI_ACPI_4_0_OSPM_64BIT_WAKE__F is a bit in OSPM Enabled Firmware
> Control Structure Flags field, not in Firmware Control Structure
> Feature Flags.
> 
> Update all related code to use correct field name.
> 
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1430
> 
> Cc: Aleksiy <oleksiyy@ami.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Jian Wang <jian.j.wang@intel.com>
> Eric Dong (2):
>   UefiCpuPkg/S3Resume2Pei: Use correct field name.
>   MdeModulePkg/BootScriptExecuteorDxe: Use correct field name.
> 
>  MdeModulePkg/Universal/Acpi/BootScriptExecutorDxe/ScriptExecute.c   | 4 ++--
>  MdeModulePkg/Universal/Acpi/BootScriptExecutorDxe/X64/SetIdtEntry.c | 4 ++--
>  UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c                   | 6 +++---
>  3 files changed, 7 insertions(+), 7 deletions(-)
> 

Regression-tested-by: Laszlo Ersek <lersek@redhat.com>