Re: [PATCH v1 0/4] Bug fixes for DynamicTablesPkg and ArmVirtPkg/kvmtool

["PierreGondois" <pierre.gondois@arm.com>]

Hello Sami,

Just for the record, for PATCH 3/4, a similar solution was used in:
commit 0b58c4894dad ("MdeModulePkg/PciHostBridgeDxe: Add CpuArch protocol dependency")

Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>

Regards,
Pierre

On 3/20/23 15:05, Sami Mujawar wrote:
> This patch series has the following fixes for DynamicTablesPkg and
> ArmVirtPkg/Kvmtool:
> 
>    1. Reduces the log output from TableHelperLib in DynamicTablesPkg.
>    2. Fixes issue with parsing of the serial port node in
>       ArmSerialPortParser in DynamicTablesPkg and
>       EarlyFdt16550SerialPortHookLib in ArmVirtPkg. This issue
>       was not observed until another entry was added in the 'chosen'
>       node in the DT when doing some experiments.
>    3. Fixes the DEPEX in the Kvmtool guest RTC library as the missing
>       dependency on CPU Architecture protocol would cause occasional
>       failures.
> 
> The changes can be seen at:
> https://github.com/samimujawar/edk2/tree/2596_bug_fix_dynamictables_kvmtool_v1
> 
> Sami Mujawar (4):
>    DynamicTablesPkg: Reduce log output from TableHelperLib
>    DynamicTablesPkg: Fix parsing of serial port node
>    ArmVirtPkg: Fix parsing of serial port node
>    ArmVirtPkg: Fix depex in kvmtool guest Rtc library
> 
>   ArmVirtPkg/Library/Fdt16550SerialPortHookLib/EarlyFdt16550SerialPortHookLib.c     |  4 +--
>   ArmVirtPkg/Library/KvmtoolRtcFdtClientLib/KvmtoolRtcFdtClientLib.inf              |  4 +--
>   DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c | 28 ++++++++++----------
>   DynamicTablesPkg/Library/FdtHwInfoParserLib/Serial/ArmSerialPortParser.c          |  4 +--
>   4 files changed, 20 insertions(+), 20 deletions(-)
>