From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.13700.1679406883914525327 for ; Tue, 21 Mar 2023 06:54:44 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: pierre.gondois@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5B3BBAD7; Tue, 21 Mar 2023 06:55:27 -0700 (PDT) Received: from [10.34.100.129] (pierre123.nice.arm.com [10.34.100.129]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id F01E33F6C4; Tue, 21 Mar 2023 06:54:41 -0700 (PDT) Message-ID: <9190c957-8967-339b-fe0c-76a1bf0a9354@arm.com> Date: Tue, 21 Mar 2023 14:54:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v1 0/4] Bug fixes for DynamicTablesPkg and ArmVirtPkg/kvmtool To: Sami Mujawar , devel@edk2.groups.io Cc: ardb+tianocore@kernel.org, quic_llindhol@quicinc.com, kraxel@redhat.com, Alexei.Fedorov@arm.com, Matteo.Carlini@arm.com, Akanksha.Jain2@arm.com, Ben.Adderson@arm.com, nd@arm.com References: <20230320140557.40348-1-sami.mujawar@arm.com> From: "PierreGondois" In-Reply-To: <20230320140557.40348-1-sami.mujawar@arm.com> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hello Sami, Just for the record, for PATCH 3/4, a similar solution was used in: commit 0b58c4894dad ("MdeModulePkg/PciHostBridgeDxe: Add CpuArch protocol dependency") Reviewed-by: Pierre Gondois Regards, Pierre On 3/20/23 15:05, Sami Mujawar wrote: > This patch series has the following fixes for DynamicTablesPkg and > ArmVirtPkg/Kvmtool: > > 1. Reduces the log output from TableHelperLib in DynamicTablesPkg. > 2. Fixes issue with parsing of the serial port node in > ArmSerialPortParser in DynamicTablesPkg and > EarlyFdt16550SerialPortHookLib in ArmVirtPkg. This issue > was not observed until another entry was added in the 'chosen' > node in the DT when doing some experiments. > 3. Fixes the DEPEX in the Kvmtool guest RTC library as the missing > dependency on CPU Architecture protocol would cause occasional > failures. > > The changes can be seen at: > https://github.com/samimujawar/edk2/tree/2596_bug_fix_dynamictables_kvmtool_v1 > > Sami Mujawar (4): > DynamicTablesPkg: Reduce log output from TableHelperLib > DynamicTablesPkg: Fix parsing of serial port node > ArmVirtPkg: Fix parsing of serial port node > ArmVirtPkg: Fix depex in kvmtool guest Rtc library > > ArmVirtPkg/Library/Fdt16550SerialPortHookLib/EarlyFdt16550SerialPortHookLib.c | 4 +-- > ArmVirtPkg/Library/KvmtoolRtcFdtClientLib/KvmtoolRtcFdtClientLib.inf | 4 +-- > DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c | 28 ++++++++++---------- > DynamicTablesPkg/Library/FdtHwInfoParserLib/Serial/ArmSerialPortParser.c | 4 +-- > 4 files changed, 20 insertions(+), 20 deletions(-) >