From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.groups.io with SMTP id smtpd.web10.4164.1571226707796808119 for ; Wed, 16 Oct 2019 04:51:47 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: philmd@redhat.com) Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 58AACC057F23 for ; Wed, 16 Oct 2019 11:51:47 +0000 (UTC) Received: by mail-wr1-f71.google.com with SMTP id f4so7890536wrj.12 for ; Wed, 16 Oct 2019 04:51:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=FDHZipQEZdf3hlDqt1slPoSmSqBo1wJf0gXDV+iA4UE=; b=npY85E28EuYYXXI2Wk/sbZp/Ev53VndUUpOdPaIpFqjwVKYERgVWdUdbV3ZJ4JHxCE hRrVAhpMW6CVCl4L4XF5tusQRlcGOKyM8ab/ShZSRlaN8WieEBomt2cBkaERz/yqA0tZ fB1fHSsVx1pLubKfMYgUivLcq0YOpiODkJmwooVM4oT+if1c3AkaAPkPoDZ2XeiueoVx f5t2qc03ISjtp/0tpPr0pZKk3H5oh0CmSJt8LttSvodFZPWxlx92t+1LYCOoQQMxw2+q OjN5FwyhJpYE0XPIZPrYLgKLOLqx0co2Hg8JXVZq0rE1U6/RGwjU/6LMAr694RvJI16f Va4g== X-Gm-Message-State: APjAAAX6Blx1vRBwujVn/1OGCNMJEFPlg8bG0w8I5l5pa1M+c0rRxzAc YkpvYRHUVf+k59cCl6Lj0Zd9fLCV0k9PEo9oOal4geFIrQSJ9Sdr7696HtsI6ORvec7xmo6Lyps pQB5K7pykpUdiaQ== X-Received: by 2002:a7b:c8c5:: with SMTP id f5mr2991531wml.170.1571226706033; Wed, 16 Oct 2019 04:51:46 -0700 (PDT) X-Google-Smtp-Source: APXvYqwW0M2R9QO+tVizC6ELkj83lPCxaNZx0r6/07zTT4R5mzIdRLwDkJH4EkLl6JuCz31unbqHzw== X-Received: by 2002:a7b:c8c5:: with SMTP id f5mr2991514wml.170.1571226705773; Wed, 16 Oct 2019 04:51:45 -0700 (PDT) Received: from [192.168.1.36] (14.red-88-21-201.staticip.rima-tde.net. [88.21.201.14]) by smtp.gmail.com with ESMTPSA id t8sm23179748wrx.76.2019.10.16.04.51.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Oct 2019 04:51:45 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH 1/1] DynamicTablesPkg: include ARM intrinsics library to fix 32-bit build To: devel@edk2.groups.io, ard.biesheuvel@linaro.org Cc: lersek@redhat.com, sami.mujawar@arm.com, leif.lindholm@linaro.org References: <20191015110742.15551-1-ard.biesheuvel@linaro.org> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <919c21bb-ce6b-5432-3d5f-4380795f2f3c@redhat.com> Date: Wed, 16 Oct 2019 13:51:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 MIME-Version: 1.0 In-Reply-To: <20191015110742.15551-1-ard.biesheuvel@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 10/15/19 1:07 PM, Ard Biesheuvel wrote: > DynamicTablesPkg can be built for ARM as well as for AARCH64, but on > the former, doing so will result in a build failure due to the lack > of 64-bit division helpers provided by the ArmPkg intrinsics library. > So add the missing reference, for both ARM and AARCH64 (which may > start relying on intrinsics due to future changes) > > Link: https://bugzilla.tianocore.org/show_bug.cgi?id=2269 > Reported-by: Laszlo Ersek > Signed-off-by: Ard Biesheuvel > --- > DynamicTablesPkg/DynamicTablesPkg.dsc | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/DynamicTablesPkg/DynamicTablesPkg.dsc b/DynamicTablesPkg/DynamicTablesPkg.dsc > index ef958077ed48..19beaaf370f8 100644 > --- a/DynamicTablesPkg/DynamicTablesPkg.dsc > +++ b/DynamicTablesPkg/DynamicTablesPkg.dsc > @@ -32,6 +32,7 @@ [LibraryClasses] > UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf > > [LibraryClasses.ARM, LibraryClasses.AARCH64] > + NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf > PL011UartLib|ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.inf > > [Components.common] > Reviewed-by: Philippe Mathieu-Daude