From: "Marvin Häuser" <mhaeuser@posteo.de>
To: Pedro Falcato <pedro.falcato@gmail.com>
Cc: Ard Biesheuvel <ardb@kernel.org>,
edk2-devel-groups-io <devel@edk2.groups.io>
Subject: Re: [PATCH 1/1] Ext4Pkg: Move unicode collation initialization to Start()
Date: Tue, 21 Feb 2023 19:37:10 +0000 [thread overview]
Message-ID: <91E4C588-DC5F-454B-818B-6875A2826CFE@posteo.de> (raw)
In-Reply-To: <CAKbZUD3RSs27K0F5WvqCR0BG-hB=5T9poojYTfDD=GXztAQFVA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 425 bytes --]
> On 21. Feb 2023, at 20:25, Pedro Falcato <pedro.falcato@gmail.com> wrote:
>
> Marvin,
>
> Do you want me to spin up a quick v2 without the
> Ext4IsCollationInitialized? Just doing the check internally in
> Ext4InitialiseUnicodeCollation.
It'd be my preferred solution, but it's just a detail.
Reviewed-by: Marvin Häuser <mhaeuser@posteo.de <mailto:mhaeuser@posteo.de>> in any case
>
> --
> Pedro
[-- Attachment #2: Type: text/html, Size: 5645 bytes --]
next prev parent reply other threads:[~2023-02-21 19:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-17 20:14 [PATCH 1/1] Ext4Pkg: Move unicode collation initialization to Start() Pedro Falcato
2023-02-18 12:30 ` Marvin Häuser
2023-02-18 15:14 ` Pedro Falcato
2023-02-18 17:04 ` Marvin Häuser
2023-02-20 7:52 ` Ard Biesheuvel
2023-02-20 8:00 ` Marvin Häuser
2023-02-21 19:25 ` Pedro Falcato
2023-02-21 19:37 ` Marvin Häuser [this message]
2023-02-24 0:34 ` Pedro Falcato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91E4C588-DC5F-454B-818B-6875A2826CFE@posteo.de \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox