public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Sami Mujawar" <sami.mujawar@arm.com>
To: Pranav Madhu <pranav.madhu@arm.com>, devel@edk2.groups.io
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Pierre Gondois <pierre.gondois@arm.com>,
	nd@arm.com
Subject: Re: [edk2-platforms][PATCH V3 00/14] Platform/Sgi: Add PPTT table for Neoverse Reference Design platforms
Date: Tue, 11 May 2021 12:09:25 +0100	[thread overview]
Message-ID: <91a0f4f6-fe21-d00b-2916-c7db41e4053d@arm.com> (raw)
In-Reply-To: <20210510200615.26879-1-pranav.madhu@arm.com>

Hi Pranav,

Comparing with the V2 series, I see that updates to the following files 
or corresponding patches are missing in this series.

-  RdV1Mc/Pptt.aslc
-  RdN2/Pptt.aslc

Is this intentional?

Regards,

Sami Mujawar

On 10/05/2021 09:06 PM, Pranav Madhu wrote:
> Changes since V2:
> - Introduced CPU container object into DSDT
> - Addressed comments from Sami
>
> Changes since V1:
> - Rebase the patches on top of latest master branch
> - Addressed comments from Pierre
>
> Processor Properties Topology Table (PPTT) describes the topological
> structure of processors, and their shared resources such as caches.
> This patch series adds PPTT table for Arm's Neoverse Reference Design
> platforms.
>
> The first patch in this series adds helper macros for PPTT table, and
> the subsequent patches in this series adds PPTT table for Neoverse
> Reference Design platforms which is mandatory as per Arm SystemReady SR
> specification.
>
> Link to github branch with the patches in this series -
> https://github.com/Pranav-Madhu/edk2-platforms/tree/topics/rd_pptt
>
> Pranav Madhu (14):
>    Platform/Sgi: Helper macros for PPTT Table
>    Platform/Sgi: Add CPU container for SGI-575
>    Platform/Sgi: ACPI PPTT table for SGI-575 platform
>    Platform/Sgi: Add CPU container for RD-N1-Edge
>    Platform/Sgi: ACPI PPTT table for RD-N1-Edge platform
>    Platform/Sgi: Add DSDT ACPI table for RD-N1-Edge dual-chip platform
>    Platform/Sgi: ACPI PPTT table for RD-N1-Edge dual-chip
>    Platform/Sgi: ACPI PPTT table for RD-E1-Edge platform
>    Platform/Sgi: Add CPU container for RD-V1 platform
>    Platform/Sgi: ACPI PPTT Table for RD-V1 platform
>    Platform/Sgi: Add CPU container for RD-V1 quad-chip platform
>    Platform/Sgi: ACPI PPTT Table for RD-V1 quad-chip platform
>    Platform/Sgi: Add CPU container for RD-N2 platform
>    Platform/Sgi: ACPI PPTT table for RD-N2 platform
>
>   .../SgiPkg/AcpiTables/RdE1EdgeAcpiTables.inf  |   3 +-
>   .../SgiPkg/AcpiTables/RdN1EdgeAcpiTables.inf  |   3 +-
>   .../AcpiTables/RdN1EdgeX2AcpiTables.inf       |   3 +-
>   .../ARM/SgiPkg/AcpiTables/RdN2AcpiTables.inf  |   3 +-
>   .../ARM/SgiPkg/AcpiTables/RdV1AcpiTables.inf  |   3 +-
>   .../SgiPkg/AcpiTables/RdV1McAcpiTables.inf    |   1 +
>   .../SgiPkg/AcpiTables/Sgi575AcpiTables.inf    |   3 +-
>   Platform/ARM/SgiPkg/Include/SgiAcpiHeader.h   | 170 ++++++++++++
>   .../ARM/SgiPkg/AcpiTables/RdE1Edge/Pptt.aslc  | 252 ++++++++++++++++++
>   .../ARM/SgiPkg/AcpiTables/RdN1Edge/Dsdt.asl   |  88 +++---
>   .../ARM/SgiPkg/AcpiTables/RdN1Edge/Pptt.aslc  | 186 +++++++++++++
>   .../ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Dsdt.asl | 136 ++++++++++
>   .../SgiPkg/AcpiTables/RdN1EdgeX2/Pptt.aslc    | 207 ++++++++++++++
>   Platform/ARM/SgiPkg/AcpiTables/RdN2/Dsdt.asl  | 176 ++++++++----
>   Platform/ARM/SgiPkg/AcpiTables/RdN2/Pptt.aslc | 175 ++++++++++++
>   Platform/ARM/SgiPkg/AcpiTables/RdV1/Dsdt.asl  | 176 ++++++++----
>   Platform/ARM/SgiPkg/AcpiTables/RdV1/Pptt.aslc | 175 ++++++++++++
>   .../ARM/SgiPkg/AcpiTables/RdV1Mc/Dsdt.asl     | 177 ++++++++----
>   .../ARM/SgiPkg/AcpiTables/RdV1Mc/Pptt.aslc    | 184 +++++++++++++
>   .../ARM/SgiPkg/AcpiTables/Sgi575/Dsdt.asl     |  99 +++----
>   .../ARM/SgiPkg/AcpiTables/Sgi575/Pptt.aslc    | 172 ++++++++++++
>   21 files changed, 2156 insertions(+), 236 deletions(-)
>   create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdE1Edge/Pptt.aslc
>   create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdN1Edge/Pptt.aslc
>   create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Dsdt.asl
>   create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Pptt.aslc
>   create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdN2/Pptt.aslc
>   create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdV1/Pptt.aslc
>   create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdV1Mc/Pptt.aslc
>   create mode 100644 Platform/ARM/SgiPkg/AcpiTables/Sgi575/Pptt.aslc
>


  parent reply	other threads:[~2021-05-11 11:09 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-10 20:06 [edk2-platforms][PATCH V3 00/14] Platform/Sgi: Add PPTT table for Neoverse Reference Design platforms Pranav Madhu
2021-05-10 20:06 ` [edk2-platforms][PATCH V3 01/14] Platform/Sgi: Helper macros for PPTT Table Pranav Madhu
2021-05-10 20:06 ` [edk2-platforms][PATCH V3 02/14] Platform/Sgi: Add CPU container for SGI-575 Pranav Madhu
2021-05-10 20:06 ` [edk2-platforms][PATCH V3 03/14] Platform/Sgi: ACPI PPTT table for SGI-575 platform Pranav Madhu
2021-05-10 20:06 ` [edk2-platforms][PATCH V3 04/14] Platform/Sgi: Add CPU container for RD-N1-Edge Pranav Madhu
2021-05-10 20:06 ` [edk2-platforms][PATCH V3 05/14] Platform/Sgi: ACPI PPTT table for RD-N1-Edge platform Pranav Madhu
2021-05-10 20:06 ` [edk2-platforms][PATCH V3 06/14] Platform/Sgi: Add DSDT ACPI table for RD-N1-Edge dual-chip platform Pranav Madhu
2021-05-10 20:06 ` [edk2-platforms][PATCH V3 07/14] Platform/Sgi: ACPI PPTT table for RD-N1-Edge dual-chip Pranav Madhu
2021-05-10 20:06 ` [edk2-platforms][PATCH V3 08/14] Platform/Sgi: ACPI PPTT table for RD-E1-Edge platform Pranav Madhu
2021-05-11 11:05   ` Sami Mujawar
2021-05-11 11:25     ` Pranav Madhu
2021-05-10 20:06 ` [edk2-platforms][PATCH V3 09/14] Platform/Sgi: Add CPU container for RD-V1 platform Pranav Madhu
2021-05-10 20:06 ` [edk2-platforms][PATCH V3 10/14] Platform/Sgi: ACPI PPTT Table " Pranav Madhu
2021-05-10 20:06 ` [edk2-platforms][PATCH V3 11/14] Platform/Sgi: Add CPU container for RD-V1 quad-chip platform Pranav Madhu
2021-05-10 20:06 ` [edk2-platforms][PATCH V3 12/14] Platform/Sgi: ACPI PPTT Table " Pranav Madhu
2021-05-10 20:06 ` [edk2-platforms][PATCH V3 13/14] Platform/Sgi: Add CPU container for RD-N2 platform Pranav Madhu
2021-05-10 20:06 ` [edk2-platforms][PATCH V3 14/14] Platform/Sgi: ACPI PPTT table " Pranav Madhu
2021-05-11 11:09 ` Sami Mujawar [this message]
2021-05-11 11:17   ` [edk2-platforms][PATCH V3 00/14] Platform/Sgi: Add PPTT table for Neoverse Reference Design platforms Pranav Madhu
2021-05-11 14:14 ` Sami Mujawar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=91a0f4f6-fe21-d00b-2916-c7db41e4053d@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox