Re: [edk2-devel] [PATCH v3 6/7] OvmfPkg/PlatformCI: dummy grub.efi for AmdSev

["Dov Murik" <dovmurik@linux.ibm.com>]

Thanks for this addition to CI!


On 03/11/2021 11:11, Gerd Hoffmann wrote:
> Building grub.efi for AmdSev is difficult because it depends on patches
> not yet merged to upstream grub.  So shortcut the grub build by simply
> creating an empty grub.efi file.  That allows to at least build-test the
> AmdSev variant.

Note that it will also allow (later) to test with QEMU with -kernel (AKA
direct measured Linux boot), which doesn't reach the grub part.  (if the
CI supports such tests.)


> 
> Acked-by: Jiewen Yao <Jiewen.yao@intel.com>
> Acked-by: Ard Biesheuvel <ardb@kernel.org>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

Reviewed-by: Dov Murik <dovmurik@linux.ibm.com>




> ---
>  OvmfPkg/PlatformCI/AmdSevBuild.py | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/OvmfPkg/PlatformCI/AmdSevBuild.py b/OvmfPkg/PlatformCI/AmdSevBuild.py
> index 2dd72cfe80d9..816caafb0084 100644
> --- a/OvmfPkg/PlatformCI/AmdSevBuild.py
> +++ b/OvmfPkg/PlatformCI/AmdSevBuild.py
> @@ -6,6 +6,7 @@
>  ##
>  import os
>  import sys
> +import subprocess
>  
>  sys.path.append(os.path.dirname(os.path.abspath(__file__)))
>  from PlatformBuildLib import SettingsManager
> @@ -35,3 +36,7 @@ class CommonPlatform():
>  
>  import PlatformBuildLib
>  PlatformBuildLib.CommonPlatform = CommonPlatform
> +
> +# hack alert -- create dummy grub.efi
> +subprocess.run(['touch', 'OvmfPkg/AmdSev/Grub/grub.efi'])
> +subprocess.run(['ls', '-l', '--sort=time', 'OvmfPkg/AmdSev/Grub'])
>