From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.158.5]) by mx.groups.io with SMTP id smtpd.web10.9064.1636444764344558866 for ; Mon, 08 Nov 2021 23:59:24 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@ibm.com header.s=pp1 header.b=HgtXad2B; spf=pass (domain: linux.ibm.com, ip: 148.163.158.5, mailfrom: dovmurik@linux.ibm.com) Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1A94OtBO003959; Tue, 9 Nov 2021 07:59:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=RrVi7iSJB4TSu3KQ0Egn7lYOIt8SB4JKsV+fyq5zI8c=; b=HgtXad2B7rz9Istsdo2K5F4obbUsj/6GhX1tASxxSAnPIQmv7l7meXSqIkDkqA1ZFjUm St9AByIAHEanrndkoNJ86sjfmGSst/aQZV7q22pxL7yZCw3fuvUGajFpK/C5eR8mqCrj BsAbUxipBIy2zd0N8A0RhPSyQlsxnobJIUGbMDjssuDG5TZtxzU7xvSH8gart2pGN3FV C8OPO5lEIF/9EzySu/iyIEApM4hARUwa1A5vFFDM3l+9NQNtrVXLtIVpi7oJtper5W8i eul536DgDizixwcG2NNFMN0fAhkkrnHxdcDBLXTHjnCu/cmlPISADWTyLNWRoz2KXVhC kg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 3c7eet8jqg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 09 Nov 2021 07:59:14 +0000 Received: from m0098414.ppops.net (m0098414.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 1A97v0k1009907; Tue, 9 Nov 2021 07:59:13 GMT Received: from ppma02wdc.us.ibm.com (aa.5b.37a9.ip4.static.sl-reverse.com [169.55.91.170]) by mx0b-001b2d01.pphosted.com with ESMTP id 3c7eet8jq8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 09 Nov 2021 07:59:13 +0000 Received: from pps.filterd (ppma02wdc.us.ibm.com [127.0.0.1]) by ppma02wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 1A97wo3N010851; Tue, 9 Nov 2021 07:59:13 GMT Received: from b03cxnp08025.gho.boulder.ibm.com (b03cxnp08025.gho.boulder.ibm.com [9.17.130.17]) by ppma02wdc.us.ibm.com with ESMTP id 3c5hbayxw1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 09 Nov 2021 07:59:12 +0000 Received: from b03ledav004.gho.boulder.ibm.com (b03ledav004.gho.boulder.ibm.com [9.17.130.235]) by b03cxnp08025.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 1A97x8OP35914082 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 9 Nov 2021 07:59:08 GMT Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C57777805E; Tue, 9 Nov 2021 07:59:08 +0000 (GMT) Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 55F577805C; Tue, 9 Nov 2021 07:59:04 +0000 (GMT) Received: from [9.160.77.174] (unknown [9.160.77.174]) by b03ledav004.gho.boulder.ibm.com (Postfix) with ESMTP; Tue, 9 Nov 2021 07:59:03 +0000 (GMT) Message-ID: <91e08adf-ba90-150e-0ad3-a102f0342bcf@linux.ibm.com> Date: Tue, 9 Nov 2021 09:59:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [edk2-devel] [PATCH v3 6/7] OvmfPkg/PlatformCI: dummy grub.efi for AmdSev To: devel@edk2.groups.io, kraxel@redhat.com Cc: Bret Barkelew , Michael D Kinney , Sean Brogan , Ard Biesheuvel , Jordan Justen , Liming Gao , Jiewen Yao , Ard Biesheuvel , Dov Murik References: <20211103091123.2953172-1-kraxel@redhat.com> <20211103091123.2953172-7-kraxel@redhat.com> From: "Dov Murik" In-Reply-To: <20211103091123.2953172-7-kraxel@redhat.com> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: wHhXekKx98tyvHBSvBdPL8YE17L4DJZj X-Proofpoint-ORIG-GUID: oDlFfYLGg19qkgE9qwg8mYQm2S9TeQaa X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-11-09_02,2021-11-08_02,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 clxscore=1011 mlxscore=0 lowpriorityscore=0 malwarescore=0 bulkscore=0 impostorscore=0 priorityscore=1501 mlxlogscore=999 adultscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2111090043 Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Thanks for this addition to CI! On 03/11/2021 11:11, Gerd Hoffmann wrote: > Building grub.efi for AmdSev is difficult because it depends on patches > not yet merged to upstream grub. So shortcut the grub build by simply > creating an empty grub.efi file. That allows to at least build-test the > AmdSev variant. Note that it will also allow (later) to test with QEMU with -kernel (AKA direct measured Linux boot), which doesn't reach the grub part. (if the CI supports such tests.) > > Acked-by: Jiewen Yao > Acked-by: Ard Biesheuvel > Signed-off-by: Gerd Hoffmann Reviewed-by: Dov Murik > --- > OvmfPkg/PlatformCI/AmdSevBuild.py | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/OvmfPkg/PlatformCI/AmdSevBuild.py b/OvmfPkg/PlatformCI/AmdSevBuild.py > index 2dd72cfe80d9..816caafb0084 100644 > --- a/OvmfPkg/PlatformCI/AmdSevBuild.py > +++ b/OvmfPkg/PlatformCI/AmdSevBuild.py > @@ -6,6 +6,7 @@ > ## > import os > import sys > +import subprocess > > sys.path.append(os.path.dirname(os.path.abspath(__file__))) > from PlatformBuildLib import SettingsManager > @@ -35,3 +36,7 @@ class CommonPlatform(): > > import PlatformBuildLib > PlatformBuildLib.CommonPlatform = CommonPlatform > + > +# hack alert -- create dummy grub.efi > +subprocess.run(['touch', 'OvmfPkg/AmdSev/Grub/grub.efi']) > +subprocess.run(['ls', '-l', '--sort=time', 'OvmfPkg/AmdSev/Grub']) >