public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Bob Feng" <bob.c.feng@intel.com>
To: "Fan, ZhijuX" <zhijux.fan@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Gao, Liming" <liming.gao@intel.com>
Subject: Re: [PATCH 1/1] BaseTools:Fix build tools print traceback info issue
Date: Tue, 24 Mar 2020 01:04:10 +0000	[thread overview]
Message-ID: <91f2cb32f9d84453a2c0ae4d0112d57b@intel.com> (raw)
In-Reply-To: <20200320035755.13080-1-zhijux.fan@intel.com>

Reviewed-by: : Bob Feng <bob.c.feng@intel.com>

-----Original Message-----
From: Fan, ZhijuX 
Sent: Friday, March 20, 2020 11:58 AM
To: devel@edk2.groups.io
Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>; Fan, ZhijuX <zhijux.fan@intel.com>
Subject: [PATCH 1/1] BaseTools:Fix build tools print traceback info issue

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2610

We meet a case that the DEC file declaring the PCD isn't included in the INF.it cause build tools report Traceback error.

Remove raise statements that generate Tracebacks that were only intended for development/debug. With the raise statements removed proper error messages are shown.

Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Zhiju.Fan <zhijux.fan@intel.com>
---
 BaseTools/Source/Python/AutoGen/AutoGenWorker.py | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/BaseTools/Source/Python/AutoGen/AutoGenWorker.py b/BaseTools/Source/Python/AutoGen/AutoGenWorker.py
index 40b448f5b2db..563d91b421ce 100755
--- a/BaseTools/Source/Python/AutoGen/AutoGenWorker.py
+++ b/BaseTools/Source/Python/AutoGen/AutoGenWorker.py
@@ -256,7 +256,6 @@ class AutoGenWorkerInProcess(mp.Process):
                         CacheResult = Ma.CanSkipbyPreMakeCache()
                     except:
                         CacheResult = False
-                        traceback.print_exc(file=sys.stdout)
                         self.feedback_q.put(taskname)
 
                     if CacheResult:
@@ -273,7 +272,6 @@ class AutoGenWorkerInProcess(mp.Process):
                         CacheResult = Ma.CanSkipbyMakeCache()
                     except:
                         CacheResult = False
-                        traceback.print_exc(file=sys.stdout)
                         self.feedback_q.put(taskname)
 
                     if CacheResult:
@@ -285,7 +283,6 @@ class AutoGenWorkerInProcess(mp.Process):
         except Empty:
             pass
         except:
-            traceback.print_exc(file=sys.stdout)
             self.feedback_q.put(taskname)
         finally:
             self.feedback_q.put("Done")
--
2.14.1.windows.1


      parent reply	other threads:[~2020-03-24  1:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-20  3:57 [PATCH 1/1] BaseTools:Fix build tools print traceback info issue Fan, ZhijuX
2020-03-20  5:12 ` Bob Feng
2020-03-24  1:04 ` Bob Feng [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=91f2cb32f9d84453a2c0ae4d0112d57b@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox