From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web10.3421.1585011855047158342 for ; Mon, 23 Mar 2020 18:04:15 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: bob.c.feng@intel.com) IronPort-SDR: /2JQXVOfIw+tX6PXLyCm7vzo+0Cf9FvtrT2gBF5El4jKeD+8doInRNvePL6RFDuqs1+1BEOWiO L2UWRuENtb1Q== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2020 18:04:13 -0700 IronPort-SDR: oZgH+fCVO96xhmMTqvGnojuUEN+fosUn56NQy1VGqbJ5HfHwxIpzizsidG1Wu8qH5vDkeKgn/Q 4PfJ4sfxMKrg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,298,1580803200"; d="scan'208";a="239861109" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga008.fm.intel.com with ESMTP; 23 Mar 2020 18:04:13 -0700 Received: from shsmsx606.ccr.corp.intel.com (10.109.6.216) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 23 Mar 2020 18:04:13 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX606.ccr.corp.intel.com (10.109.6.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 24 Mar 2020 09:04:10 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.1713.004; Tue, 24 Mar 2020 09:04:10 +0800 From: "Bob Feng" To: "Fan, ZhijuX" , "devel@edk2.groups.io" CC: "Gao, Liming" Subject: Re: [PATCH 1/1] BaseTools:Fix build tools print traceback info issue Thread-Topic: [PATCH 1/1] BaseTools:Fix build tools print traceback info issue Thread-Index: AQHV/mvA+onzcN0KPEK9TLGgb5NTE6hW81fw Date: Tue, 24 Mar 2020 01:04:10 +0000 Message-ID: <91f2cb32f9d84453a2c0ae4d0112d57b@intel.com> References: <20200320035755.13080-1-zhijux.fan@intel.com> In-Reply-To: <20200320035755.13080-1-zhijux.fan@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.36] MIME-Version: 1.0 Return-Path: bob.c.feng@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: : Bob Feng -----Original Message----- From: Fan, ZhijuX=20 Sent: Friday, March 20, 2020 11:58 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming ;= Fan, ZhijuX Subject: [PATCH 1/1] BaseTools:Fix build tools print traceback info issue REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2610 We meet a case that the DEC file declaring the PCD isn't included in the IN= F.it cause build tools report Traceback error. Remove raise statements that generate Tracebacks that were only intended fo= r development/debug. With the raise statements removed proper error message= s are shown. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Zhiju.Fan --- BaseTools/Source/Python/AutoGen/AutoGenWorker.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/BaseTools/Source/Python/AutoGen/AutoGenWorker.py b/BaseTools/S= ource/Python/AutoGen/AutoGenWorker.py index 40b448f5b2db..563d91b421ce 100755 --- a/BaseTools/Source/Python/AutoGen/AutoGenWorker.py +++ b/BaseTools/Source/Python/AutoGen/AutoGenWorker.py @@ -256,7 +256,6 @@ class AutoGenWorkerInProcess(mp.Process): CacheResult =3D Ma.CanSkipbyPreMakeCache() except: CacheResult =3D False - traceback.print_exc(file=3Dsys.stdout) self.feedback_q.put(taskname) =20 if CacheResult: @@ -273,7 +272,6 @@ class AutoGenWorkerInProcess(mp.Process): CacheResult =3D Ma.CanSkipbyMakeCache() except: CacheResult =3D False - traceback.print_exc(file=3Dsys.stdout) self.feedback_q.put(taskname) =20 if CacheResult: @@ -285,7 +283,6 @@ class AutoGenWorkerInProcess(mp.Process): except Empty: pass except: - traceback.print_exc(file=3Dsys.stdout) self.feedback_q.put(taskname) finally: self.feedback_q.put("Done") -- 2.14.1.windows.1