From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web10.2331.1573122391710952714 for ; Thu, 07 Nov 2019 02:26:31 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=iTBnMtM6; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573122390; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XZE3Q25+Itpo6qFWth42gHo4VhODXkTdZP+1EwmL/4w=; b=iTBnMtM6j720V9vUwdCn26P9F/0S47uh2/cWkoaMPmvA9oLmA0CpWIFVzDwBsKAptpF0Cv ytJ4RtebMGGeWgU0W42KrU7T8rheQXGErdeTNEiJ8r6tRgprP7KQOT9zbsJCSlpZ/acKYV /8520krkdcod/4rjzxvWKUMbhLqakDc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-123-3OjzSJCCMeCR_y5E7FLvaA-1; Thu, 07 Nov 2019 05:26:27 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 00402107ACC4; Thu, 7 Nov 2019 10:26:26 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (unknown [10.36.118.71]) by smtp.corp.redhat.com (Postfix) with ESMTP id 91C735C578; Thu, 7 Nov 2019 10:26:20 +0000 (UTC) Subject: Re: [Patch v4 02/22] .gitignore: Ignore python compiled files, extdeps, and vscode To: Michael D Kinney , devel@edk2.groups.io Cc: Sean Brogan , Andrew Fish , Leif Lindholm , Philippe Mathieu-Daude References: <20191107011349.16524-1-michael.d.kinney@intel.com> <20191107011349.16524-3-michael.d.kinney@intel.com> From: "Laszlo Ersek" Message-ID: <91f679c9-2b72-4608-3f56-9fe5eaa76dd8@redhat.com> Date: Thu, 7 Nov 2019 11:26:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20191107011349.16524-3-michael.d.kinney@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: 3OjzSJCCMeCR_y5E7FLvaA-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 11/07/19 02:13, Michael D Kinney wrote: > From: Sean Brogan >=20 > Update .gitignore to ignore .pyc files and __pycache__ > directories. Python based plugins can be added to any > package or platform, so these files and directories may > be present outside of BaseTools. >=20 > Ignore _extdep directories that are generated by the > pytool external dependency feature. >=20 > Ignore .vscode directories generated by the VS Code > editor. >=20 > Cc: Andrew Fish > Cc: Laszlo Ersek > Cc: Leif Lindholm > Signed-off-by: Kinney > Reviewed-by: Leif Lindholm > Reviewed-by: Philippe Mathieu-Daude > --- > .gitignore | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) >=20 > diff --git a/.gitignore b/.gitignore > index 97f22c348c..1dd30c1410 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -1,3 +1,7 @@ > Build/ > -tags/ > .DS_Store > +*_extdep/ > +*.pyc > +__pycache__/ > +tags/ > +.vscode/ >=20 This seems to be sorted only if we ignore the various prefixes ("*", "_", "."). I tend to call such a list "sorted" if it filters through the "sort" utility (using the POSIX locale) without changes. But, this is certainly not important enough to justify another repost. Reviewed-by: Laszlo Ersek Thanks! Laszlo