From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: devel@edk2.groups.io, rebecca@bsdio.com,
Jordan Justen <jordan.l.justen@intel.com>,
Laszlo Ersek <lersek@redhat.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [edk2-devel] [PATCH v2 2/3] OvmfPkg/build.sh: use newer '-drive if=pflash' syntax when running qemu
Date: Thu, 25 Jul 2019 13:07:16 +0200 [thread overview]
Message-ID: <91f83b96-a972-5441-ba5a-b2695aeb05e2@redhat.com> (raw)
In-Reply-To: <20190724214405.16162-2-rebecca@bsdio.com>
On 7/24/19 11:44 PM, rebecca@bsdio.com wrote:
> Specify the firmware to use via the newer '-drive if=pflash' syntax
> which allows specifying the raw format parameter. This
> avoids warnings with newer version of QEMU.
>
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> ---
> OvmfPkg/build.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
> index 1c28e65404..0219791aa8 100755
> --- a/OvmfPkg/build.sh
> +++ b/OvmfPkg/build.sh
> @@ -263,7 +263,7 @@ if [[ "$RUN_QEMU" == "yes" ]]; then
> fi
> ln -sf $FV_DIR/OVMF.fd $QEMU_FIRMWARE_DIR/bios.bin
> if [[ "$ENABLE_FLASH" == "yes" ]]; then
> - QEMU_COMMAND="$QEMU_COMMAND -pflash $QEMU_FIRMWARE_DIR/bios.bin"
> + QEMU_COMMAND="$QEMU_COMMAND -drive if=pflash,format=raw,file=$QEMU_FIRMWARE_DIR/bios.bin"
> else
> QEMU_COMMAND="$QEMU_COMMAND -L $QEMU_FIRMWARE_DIR"
> fi
>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
next prev parent reply other threads:[~2019-07-25 11:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 21:44 [PATCH v2 1/3] OvmfPkg/build.sh: use POSIX 'command -v' instead of 'which' rebecca
2019-07-24 21:44 ` [PATCH v2 2/3] OvmfPkg/build.sh: use newer '-drive if=pflash' syntax when running qemu rebecca
2019-07-25 2:56 ` Jordan Justen
2019-07-25 11:07 ` Philippe Mathieu-Daudé [this message]
2019-07-24 21:44 ` [PATCH v2 3/3] OvmfPkg/build.sh: remove $ADD_QEMU_HDA rebecca
2019-07-24 22:56 ` Jordan Justen
2019-07-30 2:24 ` [edk2-devel] " rebecca
2019-07-30 5:53 ` Jordan Justen
2019-07-25 11:08 ` Philippe Mathieu-Daudé
2019-07-25 11:07 ` [edk2-devel] [PATCH v2 1/3] OvmfPkg/build.sh: use POSIX 'command -v' instead of 'which' Philippe Mathieu-Daudé
2019-07-25 12:45 ` rebecca
2019-07-25 13:36 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91f83b96-a972-5441-ba5a-b2695aeb05e2@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox