From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: redhat.com, ip: 209.85.221.67, mailfrom: philmd@redhat.com)
Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67])
 by groups.io with SMTP; Thu, 25 Jul 2019 04:07:20 -0700
Received: by mail-wr1-f67.google.com with SMTP id n4so50380848wrs.3
        for <devel@edk2.groups.io>; Thu, 25 Jul 2019 04:07:19 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:subject:to:references:from:openpgp:message-id
         :date:user-agent:mime-version:in-reply-to:content-language
         :content-transfer-encoding;
        bh=1hPWhiCkHN9swNSfsAzwMO3n3XuWT7DzoVs5b9rfd+g=;
        b=H5zCCZ6eBBG2gEMQ66mb2uEhy/haBryDuGV0fJMsgFwydcpPx1ouD9CpiGTspt/23Y
         UM23KODGqjijGXM9wd5VOs/tVshLacTF4ff2UG2vTxb+Lvi/GeIqrsa2FRzO9P7gQEe5
         bQosxbrSau0F/ApPYYQsjQLumh5IcAiLGl/Wvqf7Ry6Wq4MDdG127SYL5QpCj9QjNDOP
         l0FzJkIheWQOBhql1vK1ABkSdq0JJxfaFH5TRMWRCIrBZQHKDtWBk4e5NoU0v+ljXWZX
         ZN89PP/i81gdXUBbVTEDOI5TBAVk5PIXGaG9ppjALnf5G8mDjADVyRFAKvAf3pHtgOGp
         XNjw==
X-Gm-Message-State: APjAAAVDqPIQNdi5IkIi+P9ZM794HxvaZW0Nl7oLXIru+ED1HFUajn4U
	I1YlhXwFN1cP6MYF8y9IWAyZJQ==
X-Google-Smtp-Source: APXvYqxDvivZQOkZoOqAaZQlujrtJpQQC0hQ1sk3T+2ndxH5BrjYQy0xydkrlLCFdtcGZ4TrN3BOhg==
X-Received: by 2002:a5d:5302:: with SMTP id e2mr79125920wrv.347.1564052838119;
        Thu, 25 Jul 2019 04:07:18 -0700 (PDT)
Return-Path: <philmd@redhat.com>
Received: from [192.168.1.37] (190.red-81-40-121.staticip.rima-tde.net. [81.40.121.190])
        by smtp.gmail.com with ESMTPSA id 32sm42146149wrh.76.2019.07.25.04.07.17
        (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128);
        Thu, 25 Jul 2019 04:07:17 -0700 (PDT)
Subject: Re: [edk2-devel] [PATCH v2 2/3] OvmfPkg/build.sh: use newer '-drive if=pflash' syntax when running qemu
To: devel@edk2.groups.io, rebecca@bsdio.com,
 Jordan Justen <jordan.l.justen@intel.com>, Laszlo Ersek <lersek@redhat.com>,
 Ard Biesheuvel <ard.biesheuvel@linaro.org>
References: <20190724214405.16162-1-rebecca@bsdio.com>
 <20190724214405.16162-2-rebecca@bsdio.com>
From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= <philmd@redhat.com>
Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE;
 url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE
Message-ID: <91f83b96-a972-5441-ba5a-b2695aeb05e2@redhat.com>
Date: Thu, 25 Jul 2019 13:07:16 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.0
MIME-Version: 1.0
In-Reply-To: <20190724214405.16162-2-rebecca@bsdio.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 7/24/19 11:44 PM, rebecca@bsdio.com wrote:
> Specify the firmware to use via the newer '-drive if=pflash' syntax
> which allows specifying the raw format parameter. This
> avoids warnings with newer version of QEMU.
> 
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> ---
>  OvmfPkg/build.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
> index 1c28e65404..0219791aa8 100755
> --- a/OvmfPkg/build.sh
> +++ b/OvmfPkg/build.sh
> @@ -263,7 +263,7 @@ if [[ "$RUN_QEMU" == "yes" ]]; then
>    fi
>    ln -sf $FV_DIR/OVMF.fd $QEMU_FIRMWARE_DIR/bios.bin
>    if [[ "$ENABLE_FLASH" == "yes" ]]; then
> -    QEMU_COMMAND="$QEMU_COMMAND -pflash $QEMU_FIRMWARE_DIR/bios.bin"
> +    QEMU_COMMAND="$QEMU_COMMAND -drive if=pflash,format=raw,file=$QEMU_FIRMWARE_DIR/bios.bin"
>    else
>      QEMU_COMMAND="$QEMU_COMMAND -L $QEMU_FIRMWARE_DIR"
>    fi
> 

Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>