Re: [edk2-devel] [edk2] [PATCH] OvmfPkg: QemuVideoDxe: Int10h stub for Windows 2008 R2 SP1 (stdvga, QXL)

["Laszlo Ersek" <lersek@redhat.com>]

On 06/20/19 10:59, David Woodhouse wrote:
> On Wed, 2019-06-19 at 23:57 +0200, Laszlo Ersek wrote:
>> In 2013, you submitted the following patch:
>>
>>   OvmfPkg: Don't build in QemuVideoDxe when we have CSM
>>
>> The thread starts here:
>>
>>   https://www.mail-archive.com/edk2-devel@lists.sourceforge.net/msg01871.html
>>
>> After an update:
>>
>>   http://mid.mail-archive.com/1360493281.7383.26.camel@shinybook.infradead.org
>>
>> I had given my R-b:
>>
>>   http://mid.mail-archive.com/511816AD.9000603@redhat.com
>>
>> But, the patch was never merged.
>>
>> The commit hash referenced in those messages still works (pointing into your personal repo):
>>
>>   http://git.infradead.org/users/dwmw2/edk2.git/commitdiff/22253c949e5
>>
>> Can you resubmit that patch please?
> 
> 
> Makes sense. I've pushed it to
> http://git.infradead.org/users/dwmw2/edk2.git/shortlog/refs/heads/csm

Thanks -- it looks good to me (a09db38a866a).

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Still, can you please post the patch to the list, for review?

We've never merged pull requests before, but I remember that you prefer
those (because you dislike an edk2 subsys maintainer rebasing your
branch from your original fork-off point). So I'm not asking for the
patch email because I insist on using "git-am". I'm asking for it
because we'd like to review every patch on the list, for now.

Once you get the proper feedback tags (R-b and so on) on the list, you
can do the rebase / rewording yourself, and then you could submit a pull
request (*not* github pull request, but from "git-request-pull", in
email). We've never exercised that in the past, so our workflow is
totally immature on that. But I understand you insist on pull reqs, and
I think we should accommodate that (again, *not* github pull reqs). The
following QEMU wiki article could be the starting point for such a
pullreq workflow in edk2:

  https://wiki.qemu.org/Contribute/SubmitAPullRequest

That said, in case you were OK with git-am in this case, that would
likely expedite me applying your patch.

Thanks!
Laszlo